[Broken] t5300 fails at 2.32.0-rc0

Much of the t5300 tests fail on 2.32.0-rc0 on NonStop.

*** t5300-pack-object.sh ***
Initialized empty Git repository in /home/git/git/t/trash directory.t5300-pack-object/.git/
expecting success of 5300.1 'setup':
        rm -f .git/index* &&
        perl -e "print \"a\" x 4096;" >a &&
        perl -e "print \"b\" x 4096;" >b &&
        perl -e "print \"c\" x 4096;" >c &&
        test-tool genrandom "seed a" 2097152 >a_big &&
        test-tool genrandom "seed b" 2097152 >b_big &&
        git update-index --add a a_big b b_big c &&
        cat c >d && echo foo >>d && git update-index --add d &&
        tree=$(git write-tree) &&
        commit=$(git commit-tree $tree </dev/null) &&
        {
                echo $tree &&
                echo $commit &&
                git ls-tree $tree | sed -e "s/.* \\([0-9a-f]*\\)        .*/\\1/"
        } >obj-list &&
        {
                git diff-tree --root -p $commit &&
                while read object
                do
                        t=$(git cat-file -t $object) &&
                        git cat-file $t $object || return 1
                done <obj-list
        } >expect

ok 1 - setup

expecting success of 5300.2 'pack without delta':
        packname_1=$(git pack-objects --progress --window=0 test-1 \
                        <obj-list 2>stderr) &&
        check_deltas stderr = 0

not ok 2 - pack without delta # # packname_1=$(git pack-objects --progress --window=0 test-1 \ # <obj-list 2>stderr) && # check_deltas stderr = 0 #

expecting success of 5300.3 'pack-objects with bogus arguments':
        test_must_fail git pack-objects --window=0 test-1 blah blah <obj-list

usage: git pack-objects --stdout [<options>...] [< <ref-list> | < <object-list>]
   or: git pack-objects [<options>...] <base-name> [< <ref-list> | < <object-list>]

    -q, --quiet           do not show progress meter
    --progress            show progress meter
    --all-progress        show progress meter during object writing phase
    --all-progress-implied
                          similar to --all-progress when progress meter is shown
    --index-version <version>[,<offset>]
                          write the pack index file in the specified idx format version
    --max-pack-size <n>   maximum size of each output pack file
    --local               ignore borrowed objects from alternate object store
    --incremental         ignore packed objects
    --window <n>          limit pack window by objects
    --window-memory <n>   limit pack window by memory in addition to object limit
    --depth <n>           maximum length of delta chain allowed in the resulting pack
    --reuse-delta         reuse existing deltas
    --reuse-object        reuse existing objects
    --delta-base-offset   use OFS_DELTA objects
    --threads <n>         use threads when searching for best delta matches
    --non-empty           do not create an empty pack output
    --revs                read revision arguments from standard input
    --unpacked            limit the objects to those that are not yet packed
    --all                 include objects reachable from any reference
    --reflog              include objects referred by reflog entries
    --indexed-objects     include objects referred to by the index
    --stdin-packs         read packs from stdin
    --stdout              output pack to stdout
    --include-tag         include tag objects that refer to objects to be packed
    --keep-unreachable    keep unreachable objects
    --pack-loose-unreachable
                          pack loose unreachable objects
    --unpack-unreachable[=<time>]
                          unpack unreachable objects newer than <time>
    --sparse              use the sparse reachability algorithm
    --thin                create thin packs
    --shallow             create packs suitable for shallow fetches
    --honor-pack-keep     ignore packs that have companion .keep file
    --keep-pack <name>    ignore this pack
    --compression <n>     pack compression level
    --keep-true-parents   do not hide commits by grafts
    --use-bitmap-index    use a bitmap index if available to speed up counting objects
    --write-bitmap-index  write a bitmap index together with the pack index
    --filter <args>       object filtering
    --missing <action>    handling for missing objects
    --exclude-promisor-objects
                          do not pack objects in promisor packfiles
    --delta-islands       respect islands during delta compression
    --uri-protocol <protocol>
                          exclude any configured uploadpack.blobpackfileuri with this protocol

ok 3 - pack-objects with bogus arguments

-- Brief whoami: NonStop developer since approximately 211288444200000000 UNIX developer since approximately 421664400 -- In my real life, I talk too much.

On Wed, May 19, 2021 at 11:52:48AM -0400, Randall S. Becker wrote:

That was one I touched recently (to add the check_deltas stuff). Can you run with "-x"? And/or run with "-i", and show the contents of the "stderr" file?

The check_deltas helper is supposed to complain to stderr when it fails. So I'm guessing perhaps pack-objects itself failed, and the reason is hidden in the stderr file.

Also, of course, bisecting the failure would be helpful (I can't reproduce here; I tried building with NO_PTHREADS, given our recent discussion, but it doesn't seem to matter).

-Peff

On May 19, 2021 12:24 PM. Jeff King wrote:

*** t5300-pack-object.sh ***
Initialized empty Git repository in /home/git/git/t/trash directory.t5300-pack-object/.git/
expecting success of 5300.1 'setup':
        rm -f .git/index* &&
        perl -e "print \"a\" x 4096;" >a &&
        perl -e "print \"b\" x 4096;" >b &&
        perl -e "print \"c\" x 4096;" >c &&
        test-tool genrandom "seed a" 2097152 >a_big &&
        test-tool genrandom "seed b" 2097152 >b_big &&
        git update-index --add a a_big b b_big c &&
        cat c >d && echo foo >>d && git update-index --add d &&
        tree=$(git write-tree) &&
        commit=$(git commit-tree $tree </dev/null) &&
        {
                echo $tree &&
                echo $commit &&
                git ls-tree $tree | sed -e "s/.* \\([0-9a-f]*\\)        .*/\\1/"
        } >obj-list &&
        {
                git diff-tree --root -p $commit &&
                while read object
                do
                        t=$(git cat-file -t $object) &&
                        git cat-file $t $object || return 1
                done <obj-list
        } >expect

++ rm -f '.git/index*' ++ perl -e 'print "a" x 4096;' ++ command /usr/bin/perl -e 'print "a" x 4096;' ++ /usr/bin/perl -e 'print "a" x 4096;' ++ perl -e 'print "b" x 4096;' ++ command /usr/bin/perl -e 'print "b" x 4096;' ++ /usr/bin/perl -e 'print "b" x 4096;' ++ perl -e 'print "c" x 4096;' ++ command /usr/bin/perl -e 'print "c" x 4096;' ++ /usr/bin/perl -e 'print "c" x 4096;' ++ test-tool genrandom 'seed a' 2097152 ++ test-tool genrandom 'seed b' 2097152 ++ git update-index --add a a_big b b_big c ++ cat c ++ echo foo ++ git update-index --add d +++ git write-tree ++ tree=3c5699c72c7dae4ca3b3ca9de37d68a592b50a45 +++ git commit-tree 3c5699c72c7dae4ca3b3ca9de37d68a592b50a45 ++ commit=ee88dc8f46b17a7cf0af1141d84677fff4ba1cfe ++ echo 3c5699c72c7dae4ca3b3ca9de37d68a592b50a45 ++ echo ee88dc8f46b17a7cf0af1141d84677fff4ba1cfe ++ git ls-tree 3c5699c72c7dae4ca3b3ca9de37d68a592b50a45 ++ sed -e 's/.* \([0-9a-f]*\) .*/\1/' ++ git diff-tree --root -p ee88dc8f46b17a7cf0af1141d84677fff4ba1cfe ++ read object +++ git cat-file -t 3c5699c72c7dae4ca3b3ca9de37d68a592b50a45 ++ t=tree ++ git cat-file tree 3c5699c72c7dae4ca3b3ca9de37d68a592b50a45 ++ read object +++ git cat-file -t ee88dc8f46b17a7cf0af1141d84677fff4ba1cfe ++ t=commit ++ git cat-file commit ee88dc8f46b17a7cf0af1141d84677fff4ba1cfe ++ read object +++ git cat-file -t 9d235ed07cd19811a6ceb342de82f190e49c9f68 ++ t=blob ++ git cat-file blob 9d235ed07cd19811a6ceb342de82f190e49c9f68 ++ read object +++ git cat-file -t 012b05d476b4ffc9e62d036156b99467206f1efa ++ t=blob ++ git cat-file blob 012b05d476b4ffc9e62d036156b99467206f1efa ++ read object +++ git cat-file -t c82de19312b6c3695c0c18f70709a6c535682a67 ++ t=blob ++ git cat-file blob c82de19312b6c3695c0c18f70709a6c535682a67 ++ read object +++ git cat-file -t 6a9aaa62f091ea4b20590414e8b58c1b0b32b5bf ++ t=blob ++ git cat-file blob 6a9aaa62f091ea4b20590414e8b58c1b0b32b5bf ++ read object +++ git cat-file -t 0be779221aca65277fd447c8207e1b3c2706ae20 ++ t=blob ++ git cat-file blob 0be779221aca65277fd447c8207e1b3c2706ae20 ++ read object +++ git cat-file -t b010fe5253f7dc59c6605dacb92fcea00d199d4e ++ t=blob ++ git cat-file blob b010fe5253f7dc59c6605dacb92fcea00d199d4e ++ read object ok 1 - setup

expecting success of 5300.2 'pack without delta':
        packname_1=$(git pack-objects --progress --window=0 test-1 \
                        <obj-list 2>stderr) &&
        check_deltas stderr = 0

+++ git pack-objects --progress --window=0 test-1 ++ packname_1= error: last command exited with $?=128 not ok 2 - pack without delta # # packname_1=$(git pack-objects --progress --window=0 test-1 \ # <obj-list 2>stderr) && # check_deltas stderr = 0 #