threads / patch / 55677

patchRe: [PATCH] Optimize the description of the configuration in packfile-uris doc

Subject: Re: [PATCH] Optimize the description of the configuration in packfile-uris doc

## tl;dr

One message between May 13, 2021 and May 13, 2021. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Teng Long· May 13, 2021, 02:45 UTC · lore
Jonathan Tan <jonathantanmy@google.com> writes:
>As for the commit message, limit the title to 50 characters or fewer if
>possible. Maybe something like "packfile-uri.txt: fix blobPackfileUri
>description" or something like that.

Thanks for mention this, "packfile-uri.txt: fix blobPackfileUri description" is good and meets the "50 characters" requirement.

So, you are right and the title will be changed in the next patch.
>Also in the commit message, maybe mention that the correct format can be
>seen in t5702.

Because I am implementing another patch[1] about supporting the commit object in packfile-uri, so I noticed the `configure_exclusion` function in t5702.

Agree and will include it in the next patch.
Thanks.
[1] https://public-inbox.org/git/20210507021140.31372-1-dyroneteng@gmail.com

← back to recent threads