# [PATCH] Fix a small flaw in the comment of strmap.h 3 messages from 2021-05-06 to 2021-05-06. Participants: Teng Long, Junio C Hamano, dyrone teng. Thread: https://gitlist.dev/t/55632 ## Teng Long, 2021-05-06 08:19 Subject: [PATCH] Fix a small flaw in the comment of strmap.h Message-ID: <20210506081936.29887-1-dyroneteng@gmail.com> URL: https://gitlist.dev/e/20210506081936.29887-1-dyroneteng%40gmail.com ``` Signed-off-by: Teng Long --- strmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/strmap.h b/strmap.h index 1e152d832d..0d1d00d14e 100644 --- a/strmap.h +++ b/strmap.h @@ -78,7 +78,7 @@ struct strmap_entry *strmap_get_entry(struct strmap *map, const char *str); void *strmap_get(struct strmap *map, const char *str); /* - * Return non-zero iff "str" is present in the map. This differs from + * Return non-zero if "str" is present in the map. This differs from * strmap_get() in that it can distinguish entries with a NULL data pointer. */ int strmap_contains(struct strmap *map, const char *str); -- 2.31.1 ``` ## Junio C Hamano, 2021-05-06 08:46 Subject: Re: [PATCH] Fix a small flaw in the comment of strmap.h Message-ID: URL: https://gitlist.dev/e/xmqq35v0z1uw.fsf%40gitster.g In-Reply-To: <20210506081936.29887-1-dyroneteng@gmail.com> ``` Teng Long writes: > Subject: Re: [PATCH] Fix a small flaw in the comment of strmap.h cf. Documentation/SubmittingPatches::summary-section > Signed-off-by: Teng Long > --- > strmap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/strmap.h b/strmap.h > index 1e152d832d..0d1d00d14e 100644 > --- a/strmap.h > +++ b/strmap.h > @@ -78,7 +78,7 @@ struct strmap_entry *strmap_get_entry(struct strmap *map, const char *str); > void *strmap_get(struct strmap *map, const char *str); > > /* > - * Return non-zero iff "str" is present in the map. This differs from > + * Return non-zero if "str" is present in the map. This differs from The original is correct; this function returns a non-zero value if and only if (iff is a common abbreviation for this expression) "str" is in the map, implying that when "str" is not in the map, the caller can rest assured that the function will not return a non-zero value (in other words, the caller is guaranteed to receive zero). If you change that to "if", the comment no longer says what happens when "str" is *not* present in the map, which is making it worse. ``` ## dyrone teng, 2021-05-06 08:49 Subject: Re: [PATCH] Fix a small flaw in the comment of strmap.h Message-ID: URL: https://gitlist.dev/e/CADMgQSRg559o_MLSsPvAU3c7_2uWWm0LuBkPZaQ-PD%3DoqqAEJQ%40mail.gmail.com In-Reply-To: ``` >The original is correct; this function returns a non-zero value if >and only if (iff is a common abbreviation for this expression) "str" >is in the map, implying that when "str" is not in the map, the >caller can rest assured that the function will not return a non-zero >value (in other words, the caller is guaranteed to receive zero). >If you change that to "if", the comment no longer says what happens >when "str" is *not* present in the map, which is making it worse. Thanks, got it. Junio C Hamano 于2021年5月6日周四 下午4:46写道： > > Teng Long writes: > > > Subject: Re: [PATCH] Fix a small flaw in the comment of strmap.h > > cf. Documentation/SubmittingPatches::summary-section > > > Signed-off-by: Teng Long > > --- > > strmap.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/strmap.h b/strmap.h > > index 1e152d832d..0d1d00d14e 100644 > > --- a/strmap.h > > +++ b/strmap.h > > @@ -78,7 +78,7 @@ struct strmap_entry *strmap_get_entry(struct strmap *map, const char *str); > > void *strmap_get(struct strmap *map, const char *str); > > > > /* > > - * Return non-zero iff "str" is present in the map. This differs from > > + * Return non-zero if "str" is present in the map. This differs from > > The original is correct; this function returns a non-zero value if > and only if (iff is a common abbreviation for this expression) "str" > is in the map, implying that when "str" is not in the map, the > caller can rest assured that the function will not return a non-zero > value (in other words, the caller is guaranteed to receive zero). > > If you change that to "if", the comment no longer says what happens > when "str" is *not* present in the map, which is making it worse. ```