threads / patch / 55510

patchlist-objects-filter-options.h: fix an 'hdr-check' warning

Subject: [PATCH] list-objects-filter-options.h: fix an 'hdr-check' warning

## tl;dr

2 messages between Apr 17, 2021 and Apr 19, 2021. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Apr 17, 2021, 21:37 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Patrick,

If you need to re-roll your 'ps/rev-list-object-type-filter' branch, could you please squash this into the relevant patch (commit 890c534cea ("list-objects: implement object type filter", 2021-04-12)).

Sorry for being a bit tardy with this email - normally I would have sent it soon after your branch hit 'seen', but I got distracted. ;-)

Thanks!

ATB, Ramsay Jones

 list-objects-filter-options.h | 1 +
 1 file changed, 1 insertion(+)

Show changes to list-objects-filter-options.h +1 −0

diff --git a/list-objects-filter-options.h b/list-objects-filter-options.h
index 4d0d0588cc..da5b6737e2 100644
--- a/list-objects-filter-options.h
+++ b/list-objects-filter-options.h
@@ -1,6 +1,7 @@
 #ifndef LIST_OBJECTS_FILTER_OPTIONS_H
 #define LIST_OBJECTS_FILTER_OPTIONS_H
 
+#include "cache.h"
 #include "parse-options.h"
 #include "string-list.h"

-- 
2.31.0

Patrick Steinhardt· Apr 19, 2021, 10:53 UTC · re: Ramsay Jones · lore

Re: [PATCH] list-objects-filter-options.h: fix an 'hdr-check' warning

On Sat, Apr 17, 2021 at 10:37:09PM +0100, Ramsay Jones wrote:

Show 17 quoted lines

> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Patrick,
> 
> If you need to re-roll your 'ps/rev-list-object-type-filter' branch,
> could you please squash this into the relevant patch (commit 890c534cea
> ("list-objects: implement object type filter", 2021-04-12)).
> 
> Sorry for being a bit tardy with this email - normally I would have sent
> it soon after your branch hit 'seen', but I got distracted. ;-)
> 
> Thanks!
> 
> ATB,
> Ramsay Jones

Thanks a lot for the fixup, will do!

Patrick

Show 18 quoted lines

> 
>  list-objects-filter-options.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/list-objects-filter-options.h b/list-objects-filter-options.h
> index 4d0d0588cc..da5b6737e2 100644
> --- a/list-objects-filter-options.h
> +++ b/list-objects-filter-options.h
> @@ -1,6 +1,7 @@
>  #ifndef LIST_OBJECTS_FILTER_OPTIONS_H
>  #define LIST_OBJECTS_FILTER_OPTIONS_H
>  
> +#include "cache.h"
>  #include "parse-options.h"
>  #include "string-list.h"
>  
> -- 
> 2.31.0