threads / discuss / 55383

not ok 47 - log.decorate configuration

Subject: not ok 47 - log.decorate configuration

## tl;dr

5 messages between Mar 25, 2021 and Mar 26, 2021.

replies: 4people: 3as markdown or json

Jeffrey Walton· Mar 25, 2021, 07:57 UTC · lore
Hi Everyone,
I'm testing 2.31.0 tarball on an Apple M1:

not ok 47 - log.decorate configuration # # git log --oneline --no-decorate >expect.none && # git log --oneline --decorate >expect.short && # git log --oneline --decorate=full >expect.full && # # echo "[log] decorate" >>.git/config && # git log --oneline >actual && # test_cmp expect.short actual && # # test_config log.decorate true && # git log --oneline >actual && # test_cmp expect.short actual && # git log --oneline --decorate=full >actual && # test_cmp expect.full actual && # git log --oneline --decorate=no >actual && # test_cmp expect.none actual && # # test_config log.decorate no && # git log --oneline >actual && # test_cmp expect.none actual && # git log --oneline --decorate >actual && # test_cmp expect.short actual && # git log --oneline --decorate=full >actual && # test_cmp expect.full actual && # # test_config log.decorate 1 && # git log --oneline >actual && # test_cmp expect.short actual && # git log --oneline --decorate=full >actual && # test_cmp expect.full actual && # git log --oneline --decorate=no >actual && # test_cmp expect.none actual && # # test_config log.decorate short && # git log --oneline >actual && # test_cmp expect.short actual && # git log --oneline --no-decorate >actual && # test_cmp expect.none actual && # git log --oneline --decorate=full >actual && # test_cmp expect.full actual && # # test_config log.decorate full && # git log --oneline >actual && # test_cmp expect.full actual && # git log --oneline --no-decorate >actual && # test_cmp expect.none actual && # git log --oneline --decorate >actual && # test_cmp expect.short actual && # # test_unconfig log.decorate && # git log --pretty=raw >expect.raw && # test_config log.decorate full && # git log --pretty=raw >actual && # test_cmp expect.raw actual

Jeff
Jeffrey Walton· Mar 25, 2021, 07:59 UTC · re: Jeffrey Walton · lore

Re: not ok 47 - log.decorate configuration

On Thu, Mar 25, 2021 at 3:57 AM Jeffrey Walton <noloader@gmail.com> wrote:
Show 60 quoted lines
>
> Hi Everyone,
>
> I'm testing 2.31.0 tarball on an Apple M1:
>
> not ok 47 - log.decorate configuration
> #
> #               git log --oneline --no-decorate >expect.none &&
> #               git log --oneline --decorate >expect.short &&
> #               git log --oneline --decorate=full >expect.full &&
> #
> #               echo "[log] decorate" >>.git/config &&
> #               git log --oneline >actual &&
> #               test_cmp expect.short actual &&
> #
> #               test_config log.decorate true &&
> #               git log --oneline >actual &&
> #               test_cmp expect.short actual &&
> #               git log --oneline --decorate=full >actual &&
> #               test_cmp expect.full actual &&
> #               git log --oneline --decorate=no >actual &&
> #               test_cmp expect.none actual &&
> #
> #               test_config log.decorate no &&
> #               git log --oneline >actual &&
> #               test_cmp expect.none actual &&
> #               git log --oneline --decorate >actual &&
> #               test_cmp expect.short actual &&
> #               git log --oneline --decorate=full >actual &&
> #               test_cmp expect.full actual &&
> #
> #               test_config log.decorate 1 &&
> #               git log --oneline >actual &&
> #               test_cmp expect.short actual &&
> #               git log --oneline --decorate=full >actual &&
> #               test_cmp expect.full actual &&
> #               git log --oneline --decorate=no >actual &&
> #               test_cmp expect.none actual &&
> #
> #               test_config log.decorate short &&
> #               git log --oneline >actual &&
> #               test_cmp expect.short actual &&
> #               git log --oneline --no-decorate >actual &&
> #               test_cmp expect.none actual &&
> #               git log --oneline --decorate=full >actual &&
> #               test_cmp expect.full actual &&
> #
> #               test_config log.decorate full &&
> #               git log --oneline >actual &&
> #               test_cmp expect.full actual &&
> #               git log --oneline --no-decorate >actual &&
> #               test_cmp expect.none actual &&
> #               git log --oneline --decorate >actual &&
> #               test_cmp expect.short actual &&
> #
> #               test_unconfig log.decorate &&
> #               git log --pretty=raw >expect.raw &&
> #               test_config log.decorate full &&
> #               git log --pretty=raw >actual &&
> #               test_cmp expect.raw actual
And here is config.log. Sorry about that...
Jeff
Jeffrey Walton· Mar 25, 2021, 23:09 UTC · re: Jeffrey Walton · lore

Re: not ok 47 - log.decorate configuration

On Thu, Mar 25, 2021 at 3:57 AM Jeffrey Walton <noloader@gmail.com> wrote:
Show 60 quoted lines
>
> Hi Everyone,
>
> I'm testing 2.31.0 tarball on an Apple M1:
>
> not ok 47 - log.decorate configuration
> #
> #               git log --oneline --no-decorate >expect.none &&
> #               git log --oneline --decorate >expect.short &&
> #               git log --oneline --decorate=full >expect.full &&
> #
> #               echo "[log] decorate" >>.git/config &&
> #               git log --oneline >actual &&
> #               test_cmp expect.short actual &&
> #
> #               test_config log.decorate true &&
> #               git log --oneline >actual &&
> #               test_cmp expect.short actual &&
> #               git log --oneline --decorate=full >actual &&
> #               test_cmp expect.full actual &&
> #               git log --oneline --decorate=no >actual &&
> #               test_cmp expect.none actual &&
> #
> #               test_config log.decorate no &&
> #               git log --oneline >actual &&
> #               test_cmp expect.none actual &&
> #               git log --oneline --decorate >actual &&
> #               test_cmp expect.short actual &&
> #               git log --oneline --decorate=full >actual &&
> #               test_cmp expect.full actual &&
> #
> #               test_config log.decorate 1 &&
> #               git log --oneline >actual &&
> #               test_cmp expect.short actual &&
> #               git log --oneline --decorate=full >actual &&
> #               test_cmp expect.full actual &&
> #               git log --oneline --decorate=no >actual &&
> #               test_cmp expect.none actual &&
> #
> #               test_config log.decorate short &&
> #               git log --oneline >actual &&
> #               test_cmp expect.short actual &&
> #               git log --oneline --no-decorate >actual &&
> #               test_cmp expect.none actual &&
> #               git log --oneline --decorate=full >actual &&
> #               test_cmp expect.full actual &&
> #
> #               test_config log.decorate full &&
> #               git log --oneline >actual &&
> #               test_cmp expect.full actual &&
> #               git log --oneline --no-decorate >actual &&
> #               test_cmp expect.none actual &&
> #               git log --oneline --decorate >actual &&
> #               test_cmp expect.short actual &&
> #
> #               test_unconfig log.decorate &&
> #               git log --pretty=raw >expect.raw &&
> #               test_config log.decorate full &&
> #               git log --pretty=raw >actual &&
> #               test_cmp expect.raw actual
Cancel this. It just tested OK a second time around.
Jeff
Junio C Hamano· Mar 26, 2021, 00:45 UTC · re: Jeffrey Walton · lore

Re: not ok 47 - log.decorate configuration

Jeffrey Walton <noloader@gmail.com> writes:
> On Thu, Mar 25, 2021 at 3:57 AM Jeffrey Walton <noloader@gmail.com> wrote:
>> ...
>
> Cancel this. It just tested OK a second time around.

Which may indicate that the test is flakey (e.g. timing dependent, only reproducing when two commands in the test sequence are executed across a second boundary, or something like that), which may be worth fixing.

Jeff King· Mar 26, 2021, 04:19 UTC · re: Junio C Hamano · lore

Re: not ok 47 - log.decorate configuration

On Thu, Mar 25, 2021 at 05:45:52PM -0700, Junio C Hamano wrote:
Show 11 quoted lines
> Jeffrey Walton <noloader@gmail.com> writes:
> 
> > On Thu, Mar 25, 2021 at 3:57 AM Jeffrey Walton <noloader@gmail.com> wrote:
> >> ...
> >
> > Cancel this. It just tested OK a second time around.
> 
> Which may indicate that the test is flakey (e.g. timing dependent,
> only reproducing when two commands in the test sequence are executed
> across a second boundary, or something like that), which may be
> worth fixing.

I can't get it to fail with "./t4202-log.sh --stress", which usually turns up races or other flakes. But perhaps there is something unique about your (Jeff) system that triggers it.

It's hard to tell more without any verbose output from the failing test. In general, failure reports accompanied by the output (or at least the end of the output) of "./t4202-log.sh -v -i -x" will be a lot more useful.

If you're seeing intermittent failures from a larger "make test", consider putting "--verbose-log -x" into GIT_TEST_OPTS (either on the make command-line, or in config.mak). The logs will be in t/test-results/t4202-log.out, etc.

-Peff

← back to recent threads