# [PATCH] SQUASH??? calloc(nmemb,size)

2 messages from 2021-03-11 to 2021-03-15. Participants: Junio C Hamano, Han-Wen Nienhuys.
Thread: https://gitlist.dev/t/55293

## Junio C Hamano, 2021-03-11 18:02

Subject: [PATCH] SQUASH??? calloc(nmemb,size)
Message-ID: <xmqqa6r9efgh.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqa6r9efgh.fsf%40gitster.g

```
Please squash this in to an appropriate step in your series;
otherwise it triggers a Coccinelle check when merged to 'seen'.

Thanks.

 refs/reftable-backend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c
index b7d12ca91d..6faad8ce50 100644
--- a/refs/reftable-backend.c
+++ b/refs/reftable-backend.c
@@ -996,7 +996,7 @@ static struct ref_iterator_vtable git_reftable_reflog_ref_iterator_vtable = {
 static struct ref_iterator *
 git_reftable_reflog_iterator_begin(struct ref_store *ref_store)
 {
-	struct git_reftable_reflog_ref_iterator *ri = xcalloc(sizeof(*ri), 1);
+	struct git_reftable_reflog_ref_iterator *ri = xcalloc(1, sizeof(*ri));
 	struct git_reftable_ref_store *refs =
 		(struct git_reftable_ref_store *)ref_store;
 
-- 
2.31.0-rc2-173-g36b77366ca


```

## Han-Wen Nienhuys, 2021-03-15 10:24

Subject: Re: [PATCH] SQUASH??? calloc(nmemb,size)
Message-ID: <CAFQ2z_OMLEWh_RBR3H_rV3VGmmdaqXFVUuBJnhayb3_=mj+e8w@mail.gmail.com>
URL: https://gitlist.dev/e/CAFQ2z_OMLEWh_RBR3H_rV3VGmmdaqXFVUuBJnhayb3_%3Dmj%2Be8w%40mail.gmail.com
In-Reply-To: <xmqqa6r9efgh.fsf@gitster.g>

```
On Thu, Mar 11, 2021 at 7:02 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Please squash this in to an appropriate step in your series;
> otherwise it triggers a Coccinelle check when merged to 'seen'.
>

folded in, thanks.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

```
