# [PATCH] docs: clarified that --lost-found implies --no-reflogs 2 messages from 2021-03-01 to 2021-03-01. Participants: Marco Luzzara via GitGitGadget, Junio C Hamano. Thread: https://gitlist.dev/t/55238 ## Marco Luzzara via GitGitGadget, 2021-03-01 15:02 Subject: [PATCH] docs: clarified that --lost-found implies --no-reflogs Message-ID: URL: https://gitlist.dev/e/pull.970.git.git.1614610921331.gitgitgadget%40gmail.com ``` From: Marco Luzzara git fsck --lost-found does not look for references in the reflog. If not specified, it could create misunderstandings like this one: https://stackoverflow.com/questions/66401232/git-fsck-combining-lost-found-and-unreachable Signed-off-by: Marco Luzzara --- docs: clarified that --lost-found implies --no-reflogs git fsck --lost-found does not look for references in the reflog. If not specified, it could create misunderstandings like this one: git fsck combining --lost-found and --unreachable [https://stackoverflow.com/questions/66401232/git-fsck-combining-lost-found-and-unreachable] Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-970%2Fmarco-luzzara%2Fmaster-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-970/marco-luzzara/master-v1 Pull-Request: https://github.com/git/git/pull/970 Documentation/git-fsck.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-fsck.txt b/Documentation/git-fsck.txt index bd596619c0d3..9f1db29042f0 100644 --- a/Documentation/git-fsck.txt +++ b/Documentation/git-fsck.txt @@ -89,7 +89,7 @@ care about this output and want to speed it up further. Write dangling objects into .git/lost-found/commit/ or .git/lost-found/other/, depending on type. If the object is a blob, the contents are written into the file, rather than - its object name. + its object name. This option implies `--no-reflogs`. --name-objects:: When displaying names of reachable objects, in addition to the base-commit: 225365fb5195e804274ab569ac3cc4919451dc7f -- gitgitgadget ``` ## Junio C Hamano, 2021-03-01 19:02 Subject: Re: [PATCH] docs: clarified that --lost-found implies --no-reflogs Message-ID: URL: https://gitlist.dev/e/xmqq4khur931.fsf%40gitster.c.googlers.com In-Reply-To: ``` "Marco Luzzara via GitGitGadget" writes: > From: Marco Luzzara > > git fsck --lost-found does not look for references in the reflog. If not specified, it could create misunderstandings like this one: https://stackoverflow.com/questions/66401232/git-fsck-combining-lost-found-and-unreachable Thanks for attempting to improve our documentation. - Please avoid an overly long line like the above. Wrap your line at around 60-70 columns. - Please do not force readers to visit external site to understand why your change is useful. You should be able to summarize the puzzlement described there in a few sentences, something like: The documentation does not say "git fsck --lost-found" uses "--no-reflogs" to make it easier to find objects that are not reachable from the tip of refs, which leads people to wonder why commits that are reachable only from reflogs are shown as dangling (see https://stackoverflow.com/questions/66401232 for an example). perhaps. > @@ -89,7 +89,7 @@ care about this output and want to speed it up further. > Write dangling objects into .git/lost-found/commit/ or > .git/lost-found/other/, depending on type. If the object is > a blob, the contents are written into the file, rather than > - its object name. > + its object name. This option implies `--no-reflogs`. It also would be a good idea to explain why it implies that. THanks. ```