threads / discuss / 55189

'git maintenance' won't work on bare repos

Subject: 'git maintenance' won't work on bare repos

## tl;dr

4 messages between Feb 23, 2021 and Feb 23, 2021.

replies: 3people: 2as markdown or json

Clement Moyroud· Feb 23, 2021, 02:01 UTC · lore
Hello,
Because we have a fairly large repository, our developers rely on
worktrees created off a bare mirror clone. I'd like to enable
maintenance, and since the worktrees are rather short-lived instances,
we cannot point 'git maintenance' to it.
So the proper solution is to do it from the bare clone itself.
However, 'git maintenance register' silently fails (with an 0 exit
code). There are two tell-tale signs:
1. 'git config --global --get maintenance.repo' returns '.'
2. There are no Crontab entries inserted.

Running 'git maintenance register' from a worktree created off the bare clone works as expected.

To reproduce: git init --bare test-me git -C test-me maintenance register git config --global --get maintenance.repo

The workaround, for now, is to run this from a worktree, then use 'git config' to reset to the corresponding bare clone location.

Thanks,
Clément
Eric Sunshine· Feb 23, 2021, 05:03 UTC · re: Clement Moyroud · lore

Re: 'git maintenance' won't work on bare repos

On Mon, Feb 22, 2021 at 9:02 PM Clement Moyroud <clement.moyroud@gmail.com> wrote:

Show 5 quoted lines
> So the proper solution is to do it from the bare clone itself.
> However, 'git maintenance register' silently fails (with an 0 exit
> code). There are two tell-tale signs:
> 1. 'git config --global --get maintenance.repo' returns '.'
> 2. There are no Crontab entries inserted.

I can confirm that problem 1 is a bug. However, I am unable to reproduce problem 2.

Note that the crontab entry won't be created until you run `git maintenance start`. Is it possible that you are forgetting that step? (Be aware that `git maintenance start` will show a misleading "no crontab for <user>" message if you don't already have a crontab file, but the crontab entry will be created nevertheless, as evidenced by `crontab -l`.)

> To reproduce:
> git init --bare test-me
> git -C test-me maintenance register
> git config --global --get maintenance.repo

I have a patch which fixes the problem with the bare repo path being incorrectly registered as ".", but I still need to create a regression test for it.

Eric Sunshine· Feb 23, 2021, 07:36 UTC · re: Eric Sunshine · lore

Re: 'git maintenance' won't work on bare repos

On Tue, Feb 23, 2021 at 12:03 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 10 quoted lines
> On Mon, Feb 22, 2021 at 9:02 PM Clement Moyroud
> <clement.moyroud@gmail.com> wrote:
> > So the proper solution is to do it from the bare clone itself.
> > However, 'git maintenance register' silently fails (with an 0 exit
> > code). There are two tell-tale signs:
> > 1. 'git config --global --get maintenance.repo' returns '.'
>
> I have a patch which fixes the problem with the bare repo path being
> incorrectly registered as ".", but I still need to create a regression
> test for it.

Patch posted here: https://lore.kernel.org/git/20210223073107.40675-1-sunshine@sunshineco.com/

Clement Moyroud· Feb 23, 2021, 15:31 UTC · re: Eric Sunshine · lore

Re: 'git maintenance' won't work on bare repos

On Mon, Feb 22, 2021 at 9:03 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 13 quoted lines
> > 1. 'git config --global --get maintenance.repo' returns '.'
> > 2. There are no Crontab entries inserted.
>
> I can confirm that problem 1 is a bug. However, I am unable to
> reproduce problem 2.
>
> Note that the crontab entry won't be created until you run `git
> maintenance start`. Is it possible that you are forgetting that step?
> (Be aware that `git maintenance start` will show a misleading "no
> crontab for <user>" message if you don't already have a crontab file,
> but the crontab entry will be created nevertheless, as evidenced by
> `crontab -l`.)
>

My bad. I misread the manpage, and didn't try to run 'git maintenance start' on the bare repo, since the first step did not look right.

> I have a patch which fixes the problem with the bare repo path being
> incorrectly registered as ".", but I still need to create a regression
> test for it.
I saw the patch, thanks for the quick fix!

← back to recent threads