threads / patch / 54736

patchcompletion: zsh: fix file completion regression

Subject: [PATCH try2] completion: zsh: fix file completion regression

## tl;dr

One message between Dec 1, 2020 and Dec 1, 2020. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Felipe Contreras· Dec 1, 2020, 00:54 UTC · lore

Turns out we always need to set the ignored prefix (compset) to have similar behavior as in default Bash.

The issue can be seen with:
  git show master:<tab>
Commit 94b2901cfe wrongly removed it.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
This is a regression since the last big chunk of changes.
 contrib/completion/git-completion.zsh | 1 +
 1 file changed, 1 insertion(+)
Show changes to contrib/completion/git-completion.zsh +1 −0
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
index e0fda27f4c..6c56296997 100644
--- a/contrib/completion/git-completion.zsh
+++ b/contrib/completion/git-completion.zsh
@@ -116,6 +116,7 @@ __gitcomp_file ()
 {
 	emulate -L zsh
 
+	compset -P '*[=:]'
 	compadd -f -p "${2-}" -- ${(f)1} && _ret=0
 }
 
-- 
2.29.2

← back to recent threads