# [PATCH 0/3] t2106 vs. the default branch name 9 messages from 2020-11-18 to 2020-11-18. Participants: Johannes Schindelin via GitGitGadget, Junio C Hamano, Johannes Schindelin. Thread: https://gitlist.dev/t/54664 ## Johannes Schindelin via GitGitGadget, 2020-11-18 14:49 Subject: [PATCH 0/3] t2106 vs. the default branch name Message-ID: URL: https://gitlist.dev/e/pull.792.git.1605710947.gitgitgadget%40gmail.com ``` Yet another thing I noticed while working on https://github.com/gitgitgadget/git/pull/762. Johannes Schindelin (3): t2106: adjust style to the current conventions t2106: make test independent of the current main branch name t2106: ensure that the checkout fails for the expected reason t/t2106-update-index-assume-unchanged.sh | 31 +++++++++++++----------- 1 file changed, 17 insertions(+), 14 deletions(-) base-commit: e31aba42fb12bdeb0f850829e008e1e3f43af500 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-792%2Fdscho%2Ft2106-and-default-branch-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-792/dscho/t2106-and-default-branch-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/792 -- gitgitgadget ``` ## Johannes Schindelin via GitGitGadget, 2020-11-18 14:49 Subject: [PATCH 2/3] t2106: make test independent of the current main branch name Message-ID: URL: https://gitlist.dev/e/d477b02b5a3ca6d2beef5bdea21407a3c555f83e.1605710947.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Johannes Schindelin We do have this wonderful shortcut `git checkout -` to go back to the previous branch, thanks to the reflog. Signed-off-by: Johannes Schindelin --- t/t2106-update-index-assume-unchanged.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t2106-update-index-assume-unchanged.sh b/t/t2106-update-index-assume-unchanged.sh index ff0947f388..3396f23363 100755 --- a/t/t2106-update-index-assume-unchanged.sh +++ b/t/t2106-update-index-assume-unchanged.sh @@ -20,7 +20,7 @@ test_expect_success 'do not switch branches with dirty file' ' git checkout other && echo dirt >file && git update-index --assume-unchanged file && - test_must_fail git checkout master + test_must_fail git checkout - ' test_done -- gitgitgadget ``` ## Johannes Schindelin via GitGitGadget, 2020-11-18 14:49 Subject: [PATCH 3/3] t2106: ensure that the checkout fails for the expected reason Message-ID: <7a750f1317143bf4488c21bd11c4e59558a3d7c6.1605710947.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/7a750f1317143bf4488c21bd11c4e59558a3d7c6.1605710947.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Johannes Schindelin During the transition of the test suite to a new default branch name, it was noticed that this test case succeeded for the wrong reason when the default branch name was overridden. While we fixed that in the previous commit, let's make sure that we look for a tell-tale in the error message that the `git checkout` failed for the reason we wanted it to fail. Signed-off-by: Johannes Schindelin --- t/t2106-update-index-assume-unchanged.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/t2106-update-index-assume-unchanged.sh b/t/t2106-update-index-assume-unchanged.sh index 3396f23363..2d450daf5c 100755 --- a/t/t2106-update-index-assume-unchanged.sh +++ b/t/t2106-update-index-assume-unchanged.sh @@ -20,7 +20,8 @@ test_expect_success 'do not switch branches with dirty file' ' git checkout other && echo dirt >file && git update-index --assume-unchanged file && - test_must_fail git checkout - + test_must_fail git checkout - 2>err && + test_i18ngrep overwritten err ' test_done -- gitgitgadget ``` ## Johannes Schindelin via GitGitGadget, 2020-11-18 14:49 Subject: [PATCH 1/3] t2106: adjust style to the current conventions Message-ID: <74828089e672024fd6e4aa23675939fe5b11eda2.1605710947.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/74828089e672024fd6e4aa23675939fe5b11eda2.1605710947.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Johannes Schindelin We settled on the style where the test cases' code starts by the opening single quote being on the `test_expect_*` line, and the closing quote being in its own line after the code. Signed-off-by: Johannes Schindelin --- t/t2106-update-index-assume-unchanged.sh | 30 +++++++++++++----------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/t/t2106-update-index-assume-unchanged.sh b/t/t2106-update-index-assume-unchanged.sh index 99d858c6b7..ff0947f388 100755 --- a/t/t2106-update-index-assume-unchanged.sh +++ b/t/t2106-update-index-assume-unchanged.sh @@ -5,20 +5,22 @@ test_description='git update-index --assume-unchanged test. . ./test-lib.sh -test_expect_success 'setup' \ - ': >file && - git add file && - git commit -m initial && - git branch other && - echo upstream >file && - git add file && - git commit -m upstream' +test_expect_success 'setup' ' + : >file && + git add file && + git commit -m initial && + git branch other && + echo upstream >file && + git add file && + git commit -m upstream +' -test_expect_success 'do not switch branches with dirty file' \ - 'git reset --hard && - git checkout other && - echo dirt >file && - git update-index --assume-unchanged file && - test_must_fail git checkout master' +test_expect_success 'do not switch branches with dirty file' ' + git reset --hard && + git checkout other && + echo dirt >file && + git update-index --assume-unchanged file && + test_must_fail git checkout master +' test_done -- gitgitgadget ``` ## Junio C Hamano, 2020-11-18 18:26 Subject: Re: [PATCH 2/3] t2106: make test independent of the current main branch name Message-ID: URL: https://gitlist.dev/e/xmqqsg961pyo.fsf%40gitster.c.googlers.com In-Reply-To: ``` "Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > We do have this wonderful shortcut `git checkout -` to go back to the > previous branch, thanks to the reflog. ;-) > > Signed-off-by: Johannes Schindelin > --- > t/t2106-update-index-assume-unchanged.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t2106-update-index-assume-unchanged.sh b/t/t2106-update-index-assume-unchanged.sh > index ff0947f388..3396f23363 100755 > --- a/t/t2106-update-index-assume-unchanged.sh > +++ b/t/t2106-update-index-assume-unchanged.sh > @@ -20,7 +20,7 @@ test_expect_success 'do not switch branches with dirty file' ' > git checkout other && > echo dirt >file && > git update-index --assume-unchanged file && > - test_must_fail git checkout master > + test_must_fail git checkout - > ' > > test_done ``` ## Junio C Hamano, 2020-11-18 20:46 Subject: Re: [PATCH 0/3] t2106 vs. the default branch name Message-ID: URL: https://gitlist.dev/e/xmqq1rgq1jgf.fsf%40gitster.c.googlers.com In-Reply-To: ``` "Johannes Schindelin via GitGitGadget" writes: > Yet another thing I noticed while working on > https://github.com/gitgitgadget/git/pull/762. > > Johannes Schindelin (3): > t2106: adjust style to the current conventions > t2106: make test independent of the current main branch name > t2106: ensure that the checkout fails for the expected reason > > t/t2106-update-index-assume-unchanged.sh | 31 +++++++++++++----------- > 1 file changed, 17 insertions(+), 14 deletions(-) This seems to partly replicate and partly deprecate what is in that final stretch 27-or-28 patch series does to the same test script. Are we taking this and then removing a patch or two from that larger series? ``` ## Johannes Schindelin, 2020-11-18 20:56 Subject: Re: [PATCH 0/3] t2106 vs. the default branch name Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.2011182152580.56%40tvgsbejvaqbjf.bet In-Reply-To: ``` Hi Junio, On Wed, 18 Nov 2020, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > Yet another thing I noticed while working on > > https://github.com/gitgitgadget/git/pull/762. > > > > Johannes Schindelin (3): > > t2106: adjust style to the current conventions > > t2106: make test independent of the current main branch name > > t2106: ensure that the checkout fails for the expected reason > > > > t/t2106-update-index-assume-unchanged.sh | 31 +++++++++++++----------- > > 1 file changed, 17 insertions(+), 14 deletions(-) > > This seems to partly replicate and partly deprecate what is in that > final stretch 27-or-28 patch series does to the same test script. > Are we taking this and then removing a patch or two from that larger > series? Sorry, I meant to explain my current thinking: for v3, I want to accommodate your wish (to mark every test script with the hard-coded default branch name individually, and only those test scripts that actually need to hard-code it). It is not only to fulfill your wish, I got genuinely curious what would actually be needed to make that happen. The four test scripts for which I sent patch series in the past hours to remove the use of the name `master` won't be touched by v3 of this here patch series at all (because it won't be necessary anymore). Ciao, Dscho ``` ## Junio C Hamano, 2020-11-18 21:53 Subject: Re: [PATCH 0/3] t2106 vs. the default branch name Message-ID: URL: https://gitlist.dev/e/xmqqsg96z602.fsf%40gitster.c.googlers.com In-Reply-To: ``` Johannes Schindelin writes: > The four test scripts for which I sent patch series in the past hours to > remove the use of the name `master` won't be touched by v3 of this here > patch series at all (because it won't be necessary anymore). Ah, OK. I somehow had an impression that the big series was more or less done but rethinking the structure and ejecting these changes to tests that do not care what name the "init" uses by default from the series makes a lot of sense. Thanks. ``` ## Johannes Schindelin, 2020-11-18 22:25 Subject: Re: [PATCH 0/3] t2106 vs. the default branch name Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.2011182324370.56%40tvgsbejvaqbjf.bet In-Reply-To: ``` Hi Junio, On Wed, 18 Nov 2020, Junio C Hamano wrote: > Johannes Schindelin writes: > > > > The four test scripts for which I sent patch series in the past hours to > > remove the use of the name `master` won't be touched by v3 of this here > > patch series at all (because it won't be necessary anymore). > > Ah, OK. I somehow had an impression that the big series was more or > less done Me, too. And if I had listened to certain people who claim that lazy programmers are the best programmers, I would have stopped there, too. > but rethinking the structure and ejecting these changes to tests that do > not care what name the "init" uses by default from the series makes a > lot of sense. Yep. Ciao, Dscho ```