# [PATCH] git-gui: ssh-askpass: add a checkbox to show the input text 2 messages from 2020-11-07 to 2020-12-01. Participants: David Aguilar, Pratyush Yadav. Thread: https://gitlist.dev/t/54596 ## David Aguilar, 2020-11-07 22:20 Subject: [PATCH] git-gui: ssh-askpass: add a checkbox to show the input text Message-ID: <20201107222039.13900-1-davvid@gmail.com> URL: https://gitlist.dev/e/20201107222039.13900-1-davvid%40gmail.com ``` Hide the input text by default since the field is commonly used for sensative informations such as passwords. Add a "Show input" checkbox to conditionally show the input. Helped-by: Miguel Boekhold Signed-off-by: Efimov Vasily Signed-off-by: David Aguilar --- git-gui--askpass | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) This patch gathers the submissions from the following sources: https://github.com/patthoyts/git-gui/issues/22 https://github.com/prati0100/git-gui/pull/38 https://github.com/git-cola/git-cola/issues/1004 https://github.com/git-cola/git-cola/pull/1069 diff --git a/git-gui--askpass b/git-gui--askpass index 1c99ee8..71a536d 100755 --- a/git-gui--askpass +++ b/git-gui--askpass @@ -26,8 +26,21 @@ pack .m -side top -fill x -padx 20 -pady 20 -expand 1 entry .e -textvariable answer -width 50 pack .e -side top -fill x -padx 10 -pady 10 +proc on_show_input_changed {args} { + global show_input + if {$show_input} { + .e configure -show "" + } else { + .e configure -show "*" + } +} +trace add variable show_input write "on_show_input_changed" + +set show_input 0 + if {!$yesno} { - .e configure -show "*" + checkbutton .cb_show -text "Show input" -variable show_input + pack .cb_show -side top -anchor nw } frame .b -- 2.29.2.154.g7f7ebe054a ``` ## Pratyush Yadav, 2020-12-01 19:41 Subject: Re: [PATCH] git-gui: ssh-askpass: add a checkbox to show the input text Message-ID: <20201201194116.mvm7svakxzyruybx@yadavpratyush.com> URL: https://gitlist.dev/e/20201201194116.mvm7svakxzyruybx%40yadavpratyush.com In-Reply-To: <20201107222039.13900-1-davvid@gmail.com> ``` On 07/11/20 02:20PM, David Aguilar wrote: > Hide the input text by default since the field is > commonly used for sensative informations such as passwords. > > Add a "Show input" checkbox to conditionally show the input. > > Helped-by: Miguel Boekhold > Signed-off-by: Efimov Vasily > Signed-off-by: David Aguilar Merged to git-gui/master. Thanks. -- Regards, Pratyush Yadav ```