threads / patch / 54561

patcht2402: fix typo

Subject: [PATCH] t2402: fix typo

## tl;dr

3 messages between Nov 3, 2020 and Nov 10, 2020. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Johannes Schindelin via GitGitGadget· Nov 3, 2020, 11:48 UTC · lore

From: Johannes Schindelin <johannes.schindelin@gmx.de>

In c57b3367bed (worktree: teach `list` to annotate locked worktree, 2020-10-11), we introduced a test case that wanted to talk about "worktrees" but talked about "worktress" instead. Let's fix that.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    t2402: fix typo
    
    Just a fix for a typo introduced in c57b3367bed (worktree: teach list to
    annotate locked worktree, 2020-10-11).

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-777%2Fdscho%2Ffix-worktress-typo-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-777/dscho/fix-worktress-typo-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/777

 t/t2402-worktree-list.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/t2402-worktree-list.sh +1 −1

diff --git a/t/t2402-worktree-list.sh b/t/t2402-worktree-list.sh
index b85bd2655d..795ddca2e4 100755
--- a/t/t2402-worktree-list.sh
+++ b/t/t2402-worktree-list.sh
@@ -61,7 +61,7 @@ test_expect_success '"list" all worktrees --porcelain' '
 	test_cmp expect actual
 '
 
-test_expect_success '"list" all worktress with locked annotation' '
+test_expect_success '"list" all worktrees with locked annotation' '
 	test_when_finished "rm -rf locked unlocked out && git worktree prune" &&
 	git worktree add --detach locked master &&
 	git worktree add --detach unlocked master &&

base-commit: c57b3367bed488469d24a21446731e9e71846ded

-- 
gitgitgadget

Rafael Silva· Nov 9, 2020, 21:52 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH] t2402: fix typo

On Tue, Nov 03, 2020 at 11:48:07AM +0000, Johannes Schindelin via GitGitGadget wrote:

Show 13 quoted lines

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> In c57b3367bed (worktree: teach `list` to annotate locked worktree,
> 2020-10-11), we introduced a test case that wanted to talk about
> "worktrees" but talked about "worktress" instead. Let's fix that.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>     t2402: fix typo
>     
>     Just a fix for a typo introduced in c57b3367bed (worktree: teach list to
>     annotate locked worktree, 2020-10-11).
>

Oops, how embarrassing.

Thank you Johannes Schindelin for catching this typo and sorry for the late reply.

Johannes Schindelin· Nov 10, 2020, 15:18 UTC · re: Rafael Silva · lore

Re: [PATCH] t2402: fix typo

Hi Rafael,

On Mon, 9 Nov 2020, Rafael Silva wrote:

Show 18 quoted lines

> On Tue, Nov 03, 2020 at 11:48:07AM +0000, Johannes Schindelin via GitGitGadget wrote:
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > In c57b3367bed (worktree: teach `list` to annotate locked worktree,
> > 2020-10-11), we introduced a test case that wanted to talk about
> > "worktrees" but talked about "worktress" instead. Let's fix that.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >     t2402: fix typo
> >
> >     Just a fix for a typo introduced in c57b3367bed (worktree: teach list to
> >     annotate locked worktree, 2020-10-11).
> >
>
> Oops, how embarrassing.
>
> Thank you Johannes Schindelin for catching this typo and sorry for the late reply.

FWIW I don't think that you need to be embarrassed. To me, this patch is a beautiful example that Open Source works, just like other patches that were sent to this list to fix bugs that _I_ introduced.

Thanks, Dscho