git-gui: Why are the main panels no longer white?

Hi!

I'm using git-gui compiled from git v2.29.0 under Kubuntu 10.04, and the git-gui's four main panels are now some odd grey colour instead of white.

If I revert git-gui commit c02efc13638447 (git-gui: improve dark mode support) I get my white panels back.

I'm hoping there's some magic setting I can tweak somewhere to make the panels white, instead of hacking git-gui's code. But for the life of me I can't figure out where this grey-ish colour is coming from, what "theme" I might be using (I don't bother with "dark mode" stuff), or how to specify the colours *I want* for things like Text.Background "from the option database" (whatever that is).

Can someone direct me onto the right path to fix these colours?

Thanks!

		M.

Hi Marc!

What tcl-tk theme are you using? Autodetection supposed to fetch color from TreeView background, and probably your theme using that odd gray for TreeViews.

To set your desired color for background, you can add 

*Text.Background: white

to ~/.Xresources; and `xrdb -merge ~/.Xresources` to apply it.

Or, try another theme. This one gives me white background.

*TkTheme: clam

To list available themes, run `wish`

::ttk::themes

-- Regards, Serg Tereshchenko

To get current theme, run `wish`

ttk::style theme use

-- Regards, Serg Tereshchenko

On 2020-10-29 7:44 a.m., Serg Tereshchenko wrote:

Thanks for your reply! It's been a long, long time since I've had to muck around with a .X* file...

Unfortunately none of those gives me white panels, although I do see other visual aspects change under different themes (also, `xrdb -query` shows that the *Text.Background setting has applied).

However, saying
	*background: white
does the trick!

To narrow the scope of that, I'm going with
	git-gui*Text.Background: white

I have:
	classic default clam alt
"ttk::style theme use" says I'm using the "default" theme.

Is there some way I can edit/view the theme definitions?

Thanks for the help!

		M.

-- Regards, Serg Tereshchenko

Oh, this git-send-email is terrible. Is there good email client supporting plaintext messages which i can use for replying here?

I tried to send message, but only footer is delivered. Second try:

Themes is inside /usr/lib/tk8.6/ttk/, *Theme.tcl

This is strange.

I just checked `default` theme, and in my case panels are white by default.

I will check it on kubuntu later.

Can you show your `xrdb -query`?

-- Regards, Serg Tereshchenko

On 2020-10-29 4:41 p.m., Serg Tereshchenko wrote:

I recommend Thunderbird, if you're a GUI type.

Thanks.  Seems to be /usr/share/tcltk/tk8.6/ttk on my box.

Nothing in that directory sets that greyish color (#d6d2d0).

Perhaps it's some kind of KDE-theming-GTK-apps thing.

*Box.background: #d6d2d0 *Box.foreground: #221f1e *Button.activeBackground: #d6d2d0 *Button.activeForeground: #221f1e *Button.background: #d6d2d0 *Button.foreground: #221f1e *Button.highlightBackground: #d6d2d0 *Button.highlightColor: #221f1e *Canvas.activeBackground: #ffffff *Canvas.activeForeground: #1f1c1b *Canvas.background: #ffffff *Canvas.foreground: #1f1c1b *Canvas.highlightBackground: #ffffff *Canvas.highlightColor: #1f1c1b *Canvas.selectbackground: #43ace8 *Canvas.selectforeground: #ffffff *Checkbutton.activeBackground: #d6d2d0 *Checkbutton.activeForeground: #221f1e *Checkbutton.background: #d6d2d0 *Checkbutton.foreground: #221f1e *Checkbutton.highlightBackground: #d6d2d0 *Checkbutton.highlightColor: #221f1e *Command.background: #d6d2d0 *Command.foreground: #221f1e *Dialog.background: #d6d2d0 *Dialog.foreground: #221f1e *Entry.activeBackground: #ffffff *Entry.activeForeground: #1f1c1b *Entry.background: #ffffff *Entry.foreground: #1f1c1b *Entry.highlightBackground: #ffffff *Entry.highlightColor: #1f1c1b *Entry.selectBackground: #43ace8 *Entry.selectForeground: #ffffff *Form.background: #d6d2d0 *Form.foreground: #221f1e *Frame.activeBackground: #d6d2d0 *Frame.activeForeground: #221f1e *Frame.background: #d6d2d0 *Frame.foreground: #221f1e *Frame.highlightBackground: #d6d2d0 *Frame.highlightColor: #221f1e *Label.activeBackground: #d6d2d0 *Label.activeForeground: #221f1e *Label.background: #d6d2d0 *Label.foreground: #221f1e *Label.highlightBackground: #d6d2d0 *Label.highlightColor: #221f1e *List.background: #ffffff *List.foreground: #1f1c1b *Listbox.activeBackground: #ffffff *Listbox.activeForeground: #1f1c1b *Listbox.background: #ffffff *Listbox.foreground: #1f1c1b *Listbox.highlightBackground: #ffffff *Listbox.highlightColor: #1f1c1b *Listbox.selectBackground: #43ace8 *Listbox.selectForeground: #ffffff *Menu.activeBackground: #d6d2d0 *Menu.activeForeground: #221f1e *Menu.background: #d6d2d0 *Menu.foreground: #221f1e *Menu.highlightBackground: #d6d2d0 *Menu.highlightColor: #221f1e *MenuButton.background: #d6d2d0 *MenuButton.foreground: #221f1e *Menubutton.activeBackground: #d6d2d0 *Menubutton.activeForeground: #221f1e *Menubutton.background: #d6d2d0 *Menubutton.foreground: #221f1e *Menubutton.highlightBackground: #d6d2d0 *Menubutton.highlightColor: #221f1e *Radiobutton.activeBackground: #d6d2d0 *Radiobutton.activeForeground: #221f1e *Radiobutton.background: #d6d2d0 *Radiobutton.foreground: #221f1e *Radiobutton.highlightBackground: #d6d2d0 *Radiobutton.highlightColor: #221f1e *Scale.activeBackground: #d6d2d0 *Scale.activeForeground: #221f1e *Scale.background: #d6d2d0 *Scale.foreground: #221f1e *Scale.highlightBackground: #d6d2d0 *Scale.highlightColor: #221f1e *Scale.troughColor: #d6d2d0 *Scrollbar*Cursor: left_ptr *Scrollbar*background: #d6d2d0 *Scrollbar*cursorName: left_ptr *Scrollbar*height: 15 *Scrollbar*pushThumb: false *Scrollbar*shadowWidth: 2 *Scrollbar*width: 15 *Scrollbar.activeBackground: #d6d2d0 *Scrollbar.activeForeground: #221f1e *Scrollbar.foreground: #221f1e *Scrollbar.highlightBackground: #d6d2d0 *Scrollbar.highlightColor: #221f1e *Scrollbar.troughColor: #d6d2d0 *ScrollbarBackground: #d6d2d0 *ShapeStyle: Rectangle *SimpleMenu*background: #d6d2d0 *SimpleMenu*foreground: #221f1e *SmeBSB*shadowWidth: 3 *Text.activeBackground: #ffffff *Text.activeForeground: #1f1c1b *Text.background: #ffffff *Text.foreground: #1f1c1b *Text.highlightBackground: #ffffff *Text.highlightColor: #1f1c1b *Text.selectBackground: #43ace8 *Text.selectForeground: #ffffff *Toggle.background: #d6d2d0 *Toggle.foreground: #221f1e *Toplevel.activeBackground: #d6d2d0 *Toplevel.activeForeground: #221f1e *Toplevel.background: #d6d2d0 *Toplevel.foreground: #221f1e *Toplevel.highlightBackground: #d6d2d0 *Toplevel.highlightColor: #221f1e *XmCascadeButton.background: #d6d2d0 *XmCascadeButton.foreground: #221f1e *XmCascadeButtonGadget.background: #d6d2d0 *XmCascadeButtonGadget.foreground: #221f1e *XmDialogShell.background: #d6d2d0 *XmDialogShell.foreground: #221f1e *XmFileSelectionBox.background: #d6d2d0 *XmFileSelectionBox.foreground: #221f1e *XmForm.background: #d6d2d0 *XmForm.foreground: #221f1e *XmFrame.background: #d6d2d0 *XmFrame.foreground: #221f1e *XmLabel.background: #d6d2d0 *XmLabel.foreground: #221f1e *XmLabelGadget.background: #d6d2d0 *XmLabelGadget.foreground: #221f1e *XmList.background: #ffffff *XmList.foreground: #1f1c1b *XmMenuShell.background: #d6d2d0 *XmMenuShell.foreground: #221f1e *XmMessageBox.background: #d6d2d0 *XmMessageBox.foreground: #221f1e *XmPanedWindow.background: #d6d2d0 *XmPanedWindow.foreground: #221f1e *XmPushButton.background: #d6d2d0 *XmPushButton.foreground: #221f1e *XmPushButtonGadget.background: #d6d2d0 *XmPushButtonGadget.foreground: #221f1e *XmRowColumn.background: #d6d2d0 *XmRowColumn.foreground: #221f1e *XmSash.background: #d6d2d0 *XmSash.foreground: #221f1e *XmScrollBar.background: #d6d2d0 *XmScrollBar.foreground: #221f1e *XmScrolledWindow.background: #d6d2d0 *XmScrolledWindow.foreground: #221f1e *XmSelectionBox.background: #d6d2d0 *XmSelectionBox.foreground: #221f1e *XmSeparator.background: #d6d2d0 *XmSeparator.foreground: #221f1e *XmSeparatorGadget.background: #d6d2d0 *XmSeparatorGadget.foreground: #221f1e *XmTearOffButton.background: #d6d2d0 *XmTearOffButton.foreground: #221f1e *XmTearOffButtonGadget.background: #d6d2d0 *XmTearOffButtonGadget.foreground: #221f1e *XmText.background: #ffffff *XmText.foreground: #1f1c1b *XmTextField.background: #ffffff *XmTextField.foreground: #1f1c1b *XmToggleButton.background: #d6d2d0 *XmToggleButton.foreground: #221f1e *XmToggleButtonGadget.background: #d6d2d0 *XmToggleButtonGadget.foreground: #221f1e *background: #d6d2d0 *beNiceToColormap: false *borderColor: black *foreground: #221f1e *rvplayer*Command.BorderColor: #1f1c1b *rvplayer*Command.background: #d6d2d0 *rvplayer*Command.foreground: #221f1e *rvplayer*Label.BorderColor: #1f1c1b *rvplayer*MenuButton.BorderColor: #1f1c1b *rvplayer*MenuButton.background: #d6d2d0 *rvplayer*SepLine.BorderColor: #d6d2d0 *rvplayer*SepLine.bottomShadowPixel: #ffffff *rvplayer*SepLine.topShadowPixel: #615f5e *rvplayer*SimpleMenu.BorderColor: #615f5e *rvplayer*SimpleMenu.background: #d6d2d0 *rvplayer*SimpleMenu.foreground: #221f1e *rvplayer*SmeBSB*fgInsensitive: #ffffff *rvplayer*Vslider.thumbPixel: #ffffff *rvplayer*authortext.background: #d6d2d0 *rvplayer*authortext.bottomShadowPixel: #ffffff *rvplayer*authortext.topShadowPixel: #615f5e *rvplayer*background: #d6d2d0 *rvplayer*copyrighttext.background: #d6d2d0 *rvplayer*copyrighttext.bottomShadowPixel: #ffffff *rvplayer*copyrighttext.topShadowPixel: #615f5e *rvplayer*proptext.background: #d6d2d0 *rvplayer*proptext.foreground: #221f1e *rvplayer*statusback.background: #d6d2d0 *rvplayer*statusback.foreground: #221f1e *rvplayer*statustext.background: #d6d2d0 *rvplayer*statustext.foreground: #221f1e *rvplayer*timeinfotext.background: #d6d2d0 *rvplayer*timeinfotext.bottomShadowPixel: #ffffff *rvplayer*timeinfotext.foreground: #221f1e *rvplayer*timeinfotext.topShadowPixel: #615f5e *rvplayer*timeslider.bottomShadowPixel: #ffffff *rvplayer*timeslider.foreground: #d6d2d0 *rvplayer*timeslider.thumbPixel: #ffffff *rvplayer*timeslider.topShadowPixel: #615f5e *rvplayer*titletext.background: #d6d2d0 *rvplayer*titletext.bottomShadowPixel: #ffffff *rvplayer*titletext.topShadowPixel: #615f5e *rvplayer*volumeslider.bottomShadowPixel: #ffffff *rvplayer*volumeslider.topShadowPixel: #615f5e AcroRead.XmScreen.background: #ffffff AcroRead.XmScreen.borderColor: #1f1c1b AcroRead.borderColor: #1f1c1b Acroread.background: #ffffff Acroread.foreground: #1f1c1b Config*Text*background: #d6d2d0 Config*channel.background: #d6d2d0 Config*key.background: #d6d2d0 Config*list.background: #d6d2d0 Emacs*Background: #ffffff Emacs*Dialog*background: #d6d2d0 Emacs*Dialog*foreground: #221f1e Emacs*Foreground: #1f1c1b Emacs*XlwScrollBar.Background: #d6d2d0 Emacs*XlwScrollBar.Foreground: #221f1e Emacs*backgroundToolBarColor: #d6d2d0 Emacs*bottomToolBarShadowColor: #d6d2d0 Emacs*menubar*background: #d6d2d0 Emacs*menubar*foreground: #221f1e Emacs*popup*Background: #d6d2d0 Emacs*popup*Foreground: #221f1e Emacs*toolBarShadowThickness: 0 Emacs*topToolBarShadowColor: #d6d2d0 Emacs.default.attributeBackground: #ffffff Emacs.default.attributeForeground: #1f1c1b Netscape*XmLGrid.background: #d6d2d0 Netscape*XmLGrid.foreground: #1f1c1b Netscape*XmList*background: #ffffff Netscape*XmList*foreground: #1f1c1b Netscape*XmText*background: #ffffff Netscape*XmText*foreground: #1f1c1b Netscape*XmTextField*background: #ffffff Netscape*XmTextField*foreground: #1f1c1b Netscape*background: #d6d2d0 Netscape*bottomShadowColor: #615f5e Netscape*defaultBackground: #ffffff Netscape*foreground: #221f1e Netscape*highlightColor: #d6d2d0 Netscape*power.LED.background: #d6d2d0 Netscape*power.LED.foreground: #43ace8 Netscape*selectBackground: #43ace8 Netscape*selectColor: #d6d2d0 Netscape*selectForeground: #ffffff Netscape*thermo.slider.background: #d6d2d0 Netscape*thermo.slider.foreground: #43ace8 Netscape*topShadowColor: #ffffff Netscape*urlLabel*background: #ffffff Netscape*urlLabel*foreground: #1f1c1b Netscape*urlText*background: #ffffff Netscape*urlText*foreground: #1f1c1b Streamer*Text*background: #d6d2d0 TopLevelShell*background: #d6d2d0 TopLevelShell*foreground: #221f1e UXterm*background: #ffffff UXterm*foreground: #1f1c1b UXterm.SimpleMenu*background: #d6d2d0 UXterm.SimpleMenu*foreground: #221f1e WPFMShell*MenuBar*background: #d6d2d0 WPFMShell*MenuBar*foreground: #221f1e WPFMShell*XmDialogShell*XmDrawingArea*background: #ffffff WPFMShell*XmDialogShell*XmDrawingArea*foreground: #1f1c1b WPFMShell*XmDialogShell*XmList*background: #ffffff WPFMShell*XmDialogShell*XmList*foreground: #1f1c1b WPFMShell*XmDialogShell*XmScrolledWindow*XmDrawingArea.background: #ffffff WPFMShell*XmDialogShell*XmScrolledWindow*XmDrawingArea.foreground: #221f1e WPFMShell*XmDialogShell*XmText*background: #ffffff WPFMShell*XmDialogShell*XmText*foreground: #1f1c1b WPFMShell*XmDialogShell*XmTextField*background: #ffffff WPFMShell*XmDialogShell*XmTextField*foreground: #1f1c1b WPFMShell*XmDialogShell*background: #ffffff WPFMShell*XmDialogShell*foreground: #221f1e WPFMShell*XmDrawingArea*background: #ffffff WPFMShell*XmDrawingArea*foreground: #1f1c1b WPFMShell*XmList*background: #ffffff WPFMShell*XmList*foreground: #1f1c1b WPFMShell*XmScrolledWindow*XmDrawingArea.background: #d6d2d0 WPFMShell*XmScrolledWindow*XmDrawingArea.foreground: #221f1e WPFMShell*XmText*background: #ffffff WPFMShell*XmText*foreground: #1f1c1b WPFMShell*XmTextField*background: #ffffff WPFMShell*XmTextField*foreground: #1f1c1b WPFMShell*background: #d6d2d0 WPFMShell*foreground: #221f1e WPFMShell*menubar*background: #d6d2d0 WPFMShell*menubar*foreground: #221f1e XWp*MenuBar*background: #d6d2d0 XWp*MenuBar*foreground: #221f1e XWp*XmDialogShell*XmDrawingArea.background: #ffffff XWp*XmDialogShell*XmDrawingArea.foreground: #1f1c1b XWp*XmDialogShell*XmList*background: #ffffff XWp*XmDialogShell*XmList*foreground: #1f1c1b XWp*XmDialogShell*XmScrolledWindow*XmDrawingArea.background: #ffffff XWp*XmDialogShell*XmScrolledWindow*XmDrawingArea.foreground: #221f1e XWp*XmDialogShell*XmText*background: #ffffff XWp*XmDialogShell*XmText*foreground: #1f1c1b XWp*XmDialogShell*XmTextField*background: #ffffff XWp*XmDialogShell*XmTextField*foreground: #1f1c1b XWp*XmDialogShell*background: #d6d2d0 XWp*XmDialogShell*foreground: #221f1e XWp*XmDrawingArea.background: #ffffff XWp*XmDrawingArea.foreground: #1f1c1b XWp*XmList*background: #ffffff XWp*XmList*foreground: #1f1c1b XWp*XmScrolledWindow*XmDrawingArea.background: #d6d2d0 XWp*XmScrolledWindow*XmDrawingArea.foreground: #221f1e XWp*XmText*background: #ffffff XWp*XmText*foreground: #1f1c1b XWp*XmTextField*background: #FFFFFFFFFFFF XWp*XmTextField*foreground: #1f1c1b XWp*background: #d6d2d0 XWp*foreground: #221f1e XWp*menubar*background: #d6d2d0 XWp*menubar*foreground: #221f1e XWp*popmenu*background: #d6d2d0 XWp*popmenu*foreground: #221f1e XWp.form.controlbar.menubar.CBHlpButton*background: #d6d2d0 XWp.form.hscrollbar.background: #d6d2d0 XWp.form.rulerframe.ruler*background: #d6d2d0 XWp.form.scrollbar0.background: #d6d2d0 XWp.mainWindowForm.mainWindowMenubar*background: #d6d2d0 XWp.mainWindowForm.mainWindowMenubar*foreground: #221f1e Xawtv*Dialog.value.background: #d6d2d0 Xawtv*background: #d6d2d0 Xawtv*foreground: #221f1e Xcursor.size: 0 Xcursor.theme: Breeze_Snow Xft.antialias: 1 Xft.hinting: 0 Xft.hintstyle: hintnone Xterm*background: #ffffff Xterm*foreground: #1f1c1b Xterm.SimpleMenu*background: #d6d2d0 Xterm.SimpleMenu*foreground: #221f1e editres*Panner.Background: #d6d2d0 editres*Tree.Background: #ffffff editres*Tree.Foreground: #1f1c1b editres*Tree.Toggle.Background: #d6d2d0 editres*Tree.Toggle.Foreground: #221f1e git-gui*Text.Background: white ml*XmCascadeButton.marginHeight: 2 ml*XmCascadeButton.marginWidth: 8 ml*XmForm*bottomOffset: 0 ml*XmForm*topOffset: 0 ml*XmForm*verticalSpacing: 0 ml*XmList*background: #ffffff ml*XmList*foreground: #1f1c1b ml*XmList*highlightThickness: 0 ml*XmPushButton.marginHeight: 1 ml*XmRowColumn*marginHeight: 1 ml*XmRowColumn*spacing: 0 ml*XmRowColumn.entryBorder: 0 ml*XmText*background: #ffffff ml*XmText*foreground: #1f1c1b ml*XmTextField*background: #ffffff ml*XmTextField*foreground: #1f1c1b ml*XmToggleButton.marginHeight: 1 ml*background: #d6d2d0 ml*borderWidth: 0 ml*focusPolicy: pointer ml*foreground: #221f1e ml*helpwin*textSW.text.background: #ffffff ml*helpwin*textSW.text.foreground: #1f1c1b ml*highlightColor: #d6d2d0 ml*log*textSW.text.background: #ffffff ml*log*textSW.text.foreground: #1f1c1b ml*marginHeight: 2 ml*marginWidth: 3 ml*selectColor: #d6d2d0 ml*textSW.text.background: #ffffff ml*textSW.text.foreground: #1f1c1b ml.form.height: 550 ml.form.width: 650 nedit*background: #d6d2d0 nedit*foreground: #221f1e xcalc*background: #d6d2d0 xcalc*bevel.screen.LCD.background: #ffffff xcalc*bevel.screen.LCD.foreground: #1f1c1b xcalc*foreground: #221f1e xdvi.background: white xosview*background: #d6d2d0 xosview*foreground: #221f1e xosview*meterLabelColor: #221f1e xosview*usedLabelColor: #221f1e xpdf.background: #d6d2d0 xpdf.foreground: #221f1e xpdf.urlCommand: kfmclient exec %s

		M.

On Thu, Oct 29, 2020 at 11:58 PM Marc Branchaud <marcnarc@xiplink.com> wrote:

This massive list of options could be the problem.

But many options in `xrdb -query` is setting that color, and this is the reason. And that's exactly some KDE-theming-TK-apps thing.

I tried to install Kubuntu 10.04, and in gnome-boxes it could not configure the network. Luckily 18.04 has the same big list of options in `xrdb -query` and I was able to reproduce the issue.

I traced source of the problem:

But if you change this, many backgrounds change color.

Now we need to find right *something*background to set that panel colors. I'll continue search tomorrow.

-- Regards, Serg Tereshchenko

On 2020-10-29 7:28 p.m., Serg Tereshchenko wrote:

I think our emails crossed in the night somewhere...

I've found that
	git-gui*Text.Background
in ~/.Xresources does the right thing.

		M.

On Fri, Oct 30, 2020 at 09:58, Marc Branchaud <marcnarc@xiplink.com> wrote:

Hmmm, for me this doesn't work.

But, if I define it like this:

 *vpane*Text.Background: ...

It works. Probably becouse root window name differs in my case, but I have no idea why.

Considering issue solved.

Probably, this can happen to anyone on Kubuntu (or maybe KDE), but don't see a way fix this on git-gui side. If something is changing theme colors using `*.background: ...`, this "something" must also set color for git-gui.

On Thu, Oct 29, 2020 at 11:58 PM Marc Branchaud <marcnarc@xiplink.com> wrote:

This massive list of options could be the problem.

But many options in `xrdb -query` is setting that color, and this is the reason. And that's exactly some KDE-theming-TK-apps thing.

I tried to install Kubuntu 10.04, and in gnome-boxes it could not configure the network. Luckily 18.04 has the same big list of options in `xrdb -query` and I was able to reproduce the issue.

I traced source of the problem:

But if you change this, many backgrounds change color.

Now we need to find right *something*background to set that panel colors. I'll continue search tomorrow.

[Using Gmail because my stupid email provider thinks this is spam.]

On 29/10/20 09:47AM, Marc Branchaud wrote:

Your other option would be to disable theming completely by setting the config `gui.usettk` to 0 (via git config). If you still see gray panels with this option set to 0 I would consider that a bug.

On my system the themes are located in /usr/lib/tk8.6/ttk/. So for example, the theme clam can be found at /usr/lib/tk8.6/ttk/clamTheme.tcl.