# [PATCH] fmt-merge-msg: fix off-by-one bug

1 messages from 2006-09-01 to 2006-09-01. Participants: Johannes Schindelin.
Thread: https://gitlist.dev/t/5449

## Johannes Schindelin, 2006-09-01 08:49

Subject: [PATCH] fmt-merge-msg: fix off-by-one bug
Message-ID: <Pine.LNX.4.63.0609011048590.28360@wbgn013.biozentrum.uni-wuerzburg.de>
URL: https://gitlist.dev/e/Pine.LNX.4.63.0609011048590.28360%40wbgn013.biozentrum.uni-wuerzburg.de

```

Thanks to the recent malloc()->xmalloc() change, and XMALLOC_POISON, this bug
was found.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
 builtin-fmt-merge-msg.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/builtin-fmt-merge-msg.c b/builtin-fmt-merge-msg.c
index ed59e77..432963d 100644
--- a/builtin-fmt-merge-msg.c
+++ b/builtin-fmt-merge-msg.c
@@ -142,7 +142,7 @@ static int handle_line(char *line)
 		if (origin[0] == '\'' && origin[len - 1] == '\'') {
 			char *new_origin = xmalloc(len - 1);
 			memcpy(new_origin, origin + 1, len - 2);
-			new_origin[len - 1] = 0;
+			new_origin[len - 2] = 0;
 			origin = new_origin;
 		} else
 			origin = strdup(origin);
-- 
1.4.2.gc2fc-dirty

```