# [GIT PULL] gitk update

4 messages from 2020-10-03 to 2020-11-10. Participants: Paul Mackerras, Junio C Hamano, Anders Kaseorg.
Thread: https://gitlist.dev/t/54337

## Paul Mackerras, 2020-10-03 09:20

Subject: [GIT PULL] gitk update
Message-ID: <20201003092010.GC3089868@thinks.paulus.ozlabs.org>
URL: https://gitlist.dev/e/20201003092010.GC3089868%40thinks.paulus.ozlabs.org

```
Hi Junio,

Whenever it's convenient for you, please do a pull from my gitk
repository at git://ozlabs.org/~paulus/gitk.git to get 6 commits
updating gitk.

Thanks,
Paul.

```

## Junio C Hamano, 2020-10-03 17:04

Subject: Re: [GIT PULL] gitk update
Message-ID: <xmqqy2kn8cmb.fsf@gitster.c.googlers.com>
URL: https://gitlist.dev/e/xmqqy2kn8cmb.fsf%40gitster.c.googlers.com
In-Reply-To: <20201003092010.GC3089868@thinks.paulus.ozlabs.org>

```
Paul Mackerras <paulus@ozlabs.org> writes:

> Hi Junio,
>
> Whenever it's convenient for you, please do a pull from my gitk
> repository at git://ozlabs.org/~paulus/gitk.git to get 6 commits
> updating gitk.
>
> Thanks,
> Paul.

Will do.  Are these the six you mentioned, or am I missing some
other commits?

    $ git log --first-parent --oneline ..paulus/master
    6cd80496e9 gitk: Resize panes correctly when reducing window size
    e244588eb6 gitk: replace tabs with spaces
    a99bc27aec gitk: fix the context menu not appearing in the presence of submodule diffs
    2faa6cdc5e gitk: Un-hide selection in areas with non-default background color
    113ce1243f gitk: add diff lines background colors
    e272a77964 gitk: be prepared to be run in a bare repository
    c1a63459ed gitk: Preserve window dimensions on exit when not using ttk themes
    f177c49a97 gitk: don't highlight files after submodules as submodules
    d4247e0602 gitk: fix branch name encoding error
    b8b60957ce gitk: rename "commit summary" to "commit reference"

Thanks.

```

## Paul Mackerras, 2020-10-06 11:13

Subject: Re: [GIT PULL] gitk update
Message-ID: <20201006111335.GA3364508@thinks.paulus.ozlabs.org>
URL: https://gitlist.dev/e/20201006111335.GA3364508%40thinks.paulus.ozlabs.org
In-Reply-To: <xmqqy2kn8cmb.fsf@gitster.c.googlers.com>

```
On Sat, Oct 03, 2020 at 10:04:28AM -0700, Junio C Hamano wrote:
> Paul Mackerras <paulus@ozlabs.org> writes:
> 
> > Hi Junio,
> >
> > Whenever it's convenient for you, please do a pull from my gitk
> > repository at git://ozlabs.org/~paulus/gitk.git to get 6 commits
> > updating gitk.
> >
> > Thanks,
> > Paul.
> 
> Will do.  Are these the six you mentioned, or am I missing some
> other commits?
> 
>     $ git log --first-parent --oneline ..paulus/master
>     6cd80496e9 gitk: Resize panes correctly when reducing window size
>     e244588eb6 gitk: replace tabs with spaces
>     a99bc27aec gitk: fix the context menu not appearing in the presence of submodule diffs
>     2faa6cdc5e gitk: Un-hide selection in areas with non-default background color
>     113ce1243f gitk: add diff lines background colors
>     e272a77964 gitk: be prepared to be run in a bare repository
>     c1a63459ed gitk: Preserve window dimensions on exit when not using ttk themes
>     f177c49a97 gitk: don't highlight files after submodules as submodules
>     d4247e0602 gitk: fix branch name encoding error
>     b8b60957ce gitk: rename "commit summary" to "commit reference"

Yes, that's right.  Obviously it's longer since I sent you a pull
request than I had thought.

Thanks,
Paul.

```

## Anders Kaseorg, 2020-11-10 00:16

Subject: Re: [GIT PULL] gitk update
Message-ID: <1f6e179c-d9c3-e503-3218-0acf4ff27cca@mit.edu>
URL: https://gitlist.dev/e/1f6e179c-d9c3-e503-3218-0acf4ff27cca%40mit.edu
In-Reply-To: <20201006111335.GA3364508@thinks.paulus.ozlabs.org>

```
On 10/6/20 4:13 AM, Paul Mackerras wrote:
> On Sat, Oct 03, 2020 at 10:04:28AM -0700, Junio C Hamano wrote:
>>      6cd80496e9 gitk: Resize panes correctly when reducing window size

This commit has broken horizontal window resizing completely for a 
configuration with ‘set want_ttk 0’.  Resizing now results in this 
Application Error popup:

Error: expected integer but got ""

expected integer but got ""

expected integer but got ""

     while executing

"$win sash place 0 $sash0 [lindex $s0 1]"

     (procedure "resizeclistpanes" line 38)

     invoked from within

"resizeclistpanes .tf.histframe.pwclist 2818"

     (command bound to event)

Anders

```