# [PATCH] commit-graph-format.txt: fix no-parent value 4 messages from 2020-09-15 to 2020-09-15. Participants: Conor Davis via GitGitGadget, Taylor Blau, Derrick Stolee, Conor Davis. Thread: https://gitlist.dev/t/54241 ## Conor Davis via GitGitGadget, 2020-09-15 04:03 Subject: [PATCH] commit-graph-format.txt: fix no-parent value Message-ID: URL: https://gitlist.dev/e/pull.733.git.1600142634326.gitgitgadget%40gmail.com ``` From: Conor Davis The correct value from commit-graph.c: #define GRAPH_PARENT_NONE 0x70000000 Signed-off-by: Conor Davis --- commit-graph-format.txt: fix no-parent value The correct value from commit-graph.c: #define GRAPH_PARENT_NONE 0x70000000 Signed-off-by: Conor Davis git@conor.fastmail.fm [git@conor.fastmail.fm] Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-733%2Favoidscorn%2Fgraph-parent-none-doc-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-733/avoidscorn/graph-parent-none-doc-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/733 Documentation/technical/commit-graph-format.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/technical/commit-graph-format.txt b/Documentation/technical/commit-graph-format.txt index 1beef17182..002a480c9c 100644 --- a/Documentation/technical/commit-graph-format.txt +++ b/Documentation/technical/commit-graph-format.txt @@ -77,7 +77,7 @@ CHUNK DATA: Commit Data (ID: {'C', 'D', 'A', 'T' }) (N * (H + 16) bytes) * The first H bytes are for the OID of the root tree. * The next 8 bytes are for the positions of the first two parents - of the ith commit. Stores value 0x7000000 if no parent in that + of the ith commit. Stores value 0x70000000 if no parent in that position. If there are more than two parents, the second value has its most-significant bit on and the other bits store an array position into the Extra Edge List chunk. base-commit: 47ae905ffb98cc4d4fd90083da6bc8dab55d9ecc -- gitgitgadget ``` ## Taylor Blau, 2020-09-15 04:26 Subject: Re: [PATCH] commit-graph-format.txt: fix no-parent value Message-ID: <20200915042607.GA19144@nand.local> URL: https://gitlist.dev/e/20200915042607.GA19144%40nand.local In-Reply-To: ``` Hi Conor, On Tue, Sep 15, 2020 at 04:03:53AM +0000, Conor Davis via GitGitGadget wrote: > - of the ith commit. Stores value 0x7000000 if no parent in that > + of the ith commit. Stores value 0x70000000 if no parent in that Thnaks for fixing this up. This dates back to a9aa3c0927 (commit-graph: fix documentation inconsistencies, 2018-06-28) which mentions the correct value in the commit message, but uses the incorrect value in the patch itself. For what it's worth, I can hardly blame the author of a9aa3c0927, since I had to flip back and forth between the two a couple of times to convince myself which one was which. Anyway, this is obviously correct. Thank you for your contribution! Reviewed-by: Taylor Blau Thanks, Taylor ``` ## Derrick Stolee, 2020-09-15 12:16 Subject: Re: [PATCH] commit-graph-format.txt: fix no-parent value Message-ID: <8ff4e93a-7291-3093-2f79-9e98236c11f7@gmail.com> URL: https://gitlist.dev/e/8ff4e93a-7291-3093-2f79-9e98236c11f7%40gmail.com In-Reply-To: <20200915042607.GA19144@nand.local> ``` On 9/15/2020 12:26 AM, Taylor Blau wrote: > For what it's worth, I can hardly blame the author of a9aa3c0927, I can! Thanks for noticing the doc bug. May I ask why you were looking at the format document so closely? Are you working on a new implementation? Thanks, -Stolee ``` ## Conor Davis, 2020-09-15 23:12 Subject: Re: [PATCH] commit-graph-format.txt: fix no-parent value Message-ID: <7107abb6-e957-da69-5f64-ed6eeb16f14f@fastmail.fm> URL: https://gitlist.dev/e/7107abb6-e957-da69-5f64-ed6eeb16f14f%40fastmail.fm In-Reply-To: <8ff4e93a-7291-3093-2f79-9e98236c11f7@gmail.com> ``` On 9/15/20 7:16 AM, Derrick Stolee wrote: > On 9/15/2020 12:26 AM, Taylor Blau wrote: >> For what it's worth, I can hardly blame the author of a9aa3c0927, > I can! > > Thanks for noticing the doc bug. May I ask why you were looking > at the format document so closely? Are you working on a new > implementation? Yes, I'm adding commit-graph support to gitoxide: https://github.com/Byron/gitoxide/pull/21 -Conor ```