# [PATCH v3] blame.c: replace instance of !oidcmp for oideq

2 messages from 2020-09-09 to 2020-09-09. Participants: Edmundo Carmona Antoranz, Derrick Stolee.
Thread: https://gitlist.dev/t/54214

## Edmundo Carmona Antoranz, 2020-09-09 13:15

Subject: [PATCH v3] blame.c: replace instance of !oidcmp for oideq
Message-ID: <20200909131550.826462-1-eantoranz@gmail.com>
URL: https://gitlist.dev/e/20200909131550.826462-1-eantoranz%40gmail.com

```
0906ac2b (blame: use changed-path Bloom filters, 2020-04-16)
introduced a call to oidcmp() that should be replaced with oideq()
defined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
---
 blame.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/blame.c b/blame.c
index da7e28800e..a8abe86ae4 100644
--- a/blame.c
+++ b/blame.c
@@ -1352,8 +1352,8 @@ static struct blame_origin *find_origin(struct repository *r,
 	else {
 		int compute_diff = 1;
 		if (origin->commit->parents &&
-		    !oidcmp(&parent->object.oid,
-			    &origin->commit->parents->item->object.oid))
+		    oideq(&parent->object.oid,
+			  &origin->commit->parents->item->object.oid))
 			compute_diff = maybe_changed_path(r, origin, bd);
 
 		if (compute_diff)
-- 
2.28.0


```

## Derrick Stolee, 2020-09-09 18:33

Subject: Re: [PATCH v3] blame.c: replace instance of !oidcmp for oideq
Message-ID: <1c9dd960-b15e-b942-fc35-c1ae82b7549f@gmail.com>
URL: https://gitlist.dev/e/1c9dd960-b15e-b942-fc35-c1ae82b7549f%40gmail.com
In-Reply-To: <20200909131550.826462-1-eantoranz@gmail.com>

```
On 9/9/2020 9:15 AM, Edmundo Carmona Antoranz wrote:
> 0906ac2b (blame: use changed-path Bloom filters, 2020-04-16)
> introduced a call to oidcmp() that should be replaced with oideq()
> defined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)

LGTM. Thanks.

-Stolee

```