threads / discuss / 54208

No edit option when "git add --patch" a new file

Subject: No edit option when "git add --patch" a new file

## tl;dr

2 messages between Sep 8, 2020 and Sep 9, 2020.

replies: 1people: 2as markdown or json

Yuchen Ying· Sep 8, 2020, 16:16 UTC · lore
Hi list,

I was attempting to "add --patch" a newly created file but the "edit" option is not provided.

Steps to reproduce this problem:

$ echo "test\ntest" > test $ git add -N test $ git add -p test

Expected: e is an option
Got:
$ git add -p
diff --git a/terraform/test b/terraform/test
index 0000000..992533b
--- /dev/null
+++ b/terraform/test
new file mode 100644
@@ -0,0 +1,2 @@
+asdf
+asdf
(1/1) Stage addition [y,n,q,a,d,?]? e
Sorry, cannot edit this hunk
Phillip Wood· Sep 9, 2020, 09:33 UTC · re: Yuchen Ying · lore

Re: No edit option when "git add --patch" a new file

On 08/09/2020 17:16, Yuchen Ying wrote:
Show 25 quoted lines
> Hi list,
> 
> I was attempting to "add --patch" a newly created file but the "edit"
> option is not provided.
> 
> Steps to reproduce this problem:
> 
> $ echo "test\ntest" > test
> $ git add -N test
> $ git add -p test
> 
> Expected: e is an option
> Got:
> 
> $ git add -p
> diff --git a/terraform/test b/terraform/test
> index 0000000..992533b
> --- /dev/null
> +++ b/terraform/test
> new file mode 100644
> @@ -0,0 +1,2 @@
> +asdf
> +asdf
> (1/1) Stage addition [y,n,q,a,d,?]? e
> Sorry, cannot edit this hunk

Thanks for taking the time to report this issue. I'm currently working on a fix which I hope to post later today as the issue was previously reported at https://public-inbox.org/git/CAB+jsAW_+NTJjDLG9uMrf4cc5rcwHLD5kTLk7QgvFCgryb22Gw@mail.gmail.com/ I'll Cc you on the patch

Best Wishes
Phillip

← back to recent threads