# [PATCH] Remove "unsure" for --message in subtree doc.

6 messages from 2020-08-14 to 2020-08-18. Participants: Danny Lin, Junio C Hamano.
Thread: https://gitlist.dev/t/54043

## Danny Lin, 2020-08-14 14:53

Subject: [PATCH] Remove "unsure" for --message in subtree doc.
Message-ID: <20200814145344.2413-1-danny0838@gmail.com>
URL: https://gitlist.dev/e/20200814145344.2413-1-danny0838%40gmail.com

```
It is definitely clear that --message is valid for add, merge and pull.

Signed-off-by: Danny Lin <danny0838@gmail.com>
---
 contrib/subtree/git-subtree.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt
index 352deda69d..47e2c611fe 100644
--- a/contrib/subtree/git-subtree.txt
+++ b/contrib/subtree/git-subtree.txt
@@ -139,7 +139,7 @@ OPTIONS
 
 -m <message>::
 --message=<message>::
-	This option is only valid for add, merge and pull (unsure).
+	This option is only valid for add, merge and pull.
 	Specify <message> as the commit message for the merge commit.
 
 
-- 
2.28.0.windows.1


```

## Junio C Hamano, 2020-08-14 17:50

Subject: Re: [PATCH] Remove "unsure" for --message in subtree doc.
Message-ID: <xmqqbljdxgkh.fsf@gitster.c.googlers.com>
URL: https://gitlist.dev/e/xmqqbljdxgkh.fsf%40gitster.c.googlers.com
In-Reply-To: <20200814145344.2413-1-danny0838@gmail.com>

```
Danny Lin <danny0838@gmail.com> writes:

> It is definitely clear that --message is valid for add, merge and pull.

If it is also definitely clear that it is _only_ valid for those
three, then the change is good.  I do not know if that is true
offhand, though.

>
> Signed-off-by: Danny Lin <danny0838@gmail.com>
> ---
>  contrib/subtree/git-subtree.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt
> index 352deda69d..47e2c611fe 100644
> --- a/contrib/subtree/git-subtree.txt
> +++ b/contrib/subtree/git-subtree.txt
> @@ -139,7 +139,7 @@ OPTIONS
>  
>  -m <message>::
>  --message=<message>::
> -	This option is only valid for add, merge and pull (unsure).
> +	This option is only valid for add, merge and pull.
>  	Specify <message> as the commit message for the merge commit.

```

## Danny Lin, 2020-08-15 02:31

Subject: Re: [PATCH] Remove "unsure" for --message in subtree doc.
Message-ID: <CAMbsUu6WnHori2t1qG=6UVLWDNEw5FSXeTd-K6WKnpZi5h6q+w@mail.gmail.com>
URL: https://gitlist.dev/e/CAMbsUu6WnHori2t1qG%3D6UVLWDNEw5FSXeTd-K6WKnpZi5h6q%2Bw%40mail.gmail.com
In-Reply-To: <xmqqbljdxgkh.fsf@gitster.c.googlers.com>

```
Sorry, I missed that.

Further investigation suggests that it works with 'split --rejoin' and
has nothing to do with 'push' (actually, push never generates a merged
commit at all).  We can rephrase for that.

Junio C Hamano <gitster@pobox.com> writes:
>
> Danny Lin <danny0838@gmail.com> writes:
>
> > It is definitely clear that --message is valid for add, merge and pull.
>
> If it is also definitely clear that it is _only_ valid for those
> three, then the change is good.  I do not know if that is true
> offhand, though.
>

```

## Danny Lin, 2020-08-15 02:32

Subject: [PATCH] Revise supported options for --message in subtree doc.
Message-ID: <20200815023247.788-1-danny0838@gmail.com>
URL: https://gitlist.dev/e/20200815023247.788-1-danny0838%40gmail.com
In-Reply-To: <CAMbsUu6WnHori2t1qG=6UVLWDNEw5FSXeTd-K6WKnpZi5h6q+w@mail.gmail.com>

```
Revise the documentation and remove previous "unsure" after making sure
that --message supports only 'add', 'merge', 'pull', and 'split --rejoin'.

Signed-off-by: Danny Lin <danny0838@gmail.com>
---
 contrib/subtree/git-subtree.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt
index 352deda69d..9ccd431c7f 100644
--- a/contrib/subtree/git-subtree.txt
+++ b/contrib/subtree/git-subtree.txt
@@ -139,7 +139,7 @@ OPTIONS
 
 -m <message>::
 --message=<message>::
-	This option is only valid for add, merge and pull (unsure).
+	This option is only valid for add, merge, pull, and split --rejoin.
 	Specify <message> as the commit message for the merge commit.
 
 
-- 
2.28.0.windows.1


```

## Junio C Hamano, 2020-08-17 16:47

Subject: Re: [PATCH] Revise supported options for --message in subtree doc.
Message-ID: <xmqq4kp143u0.fsf@gitster.c.googlers.com>
URL: https://gitlist.dev/e/xmqq4kp143u0.fsf%40gitster.c.googlers.com
In-Reply-To: <20200815023247.788-1-danny0838@gmail.com>

```
Danny Lin <danny0838@gmail.com> writes:

> Subject: Re: [PATCH] Revise supported options for --message in subtree doc.

Documentation/SubmittingPatches:[[summary-section]]

> Revise the documentation and remove previous "unsure" after making sure
> that --message supports only 'add', 'merge', 'pull', and 'split --rejoin'.
>
> Signed-off-by: Danny Lin <danny0838@gmail.com>
> ---
>  contrib/subtree/git-subtree.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt
> index 352deda69d..9ccd431c7f 100644
> --- a/contrib/subtree/git-subtree.txt
> +++ b/contrib/subtree/git-subtree.txt
> @@ -139,7 +139,7 @@ OPTIONS
>  
>  -m <message>::
>  --message=<message>::
> -	This option is only valid for add, merge and pull (unsure).
> +	This option is only valid for add, merge, pull, and split --rejoin.
>  	Specify <message> as the commit message for the merge commit.


```

## Danny Lin, 2020-08-18 05:21

Subject: [PATCH] contrib/subtree: fix "unsure" for --message in the document
Message-ID: <20200818052109.1817-1-danny0838@gmail.com>
URL: https://gitlist.dev/e/20200818052109.1817-1-danny0838%40gmail.com
In-Reply-To: <xmqq4kp143u0.fsf@gitster.c.googlers.com>

```
Revise the documentation and remove previous "unsure" after making sure
that --message supports only 'add', 'merge', 'pull', and 'split --rejoin'.

Signed-off-by: Danny Lin <danny0838@gmail.com>
---
 contrib/subtree/git-subtree.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt
index 352deda69d..9ccd431c7f 100644
--- a/contrib/subtree/git-subtree.txt
+++ b/contrib/subtree/git-subtree.txt
@@ -139,7 +139,7 @@ OPTIONS
 
 -m <message>::
 --message=<message>::
-	This option is only valid for add, merge and pull (unsure).
+	This option is only valid for add, merge, pull, and split --rejoin.
 	Specify <message> as the commit message for the merge commit.
 
 
-- 
2.28.0.windows.1


```