# [PATCH] rebase: remove unused function reschedule_last_action 3 messages from 2020-08-12 to 2020-08-12. Participants: René Scharfe, Taylor Blau, Junio C Hamano. Thread: https://gitlist.dev/t/54026 ## René Scharfe, 2020-08-12 13:45 Subject: [PATCH] rebase: remove unused function reschedule_last_action Message-ID: <80744078-c0a9-5b55-0578-d6b62af6673b@web.de> URL: https://gitlist.dev/e/80744078-c0a9-5b55-0578-d6b62af6673b%40web.de ``` The only caller of reschedule_last_action was removed by ef64bb328df (rebase: strip unused code in git-rebase--preserve-merges.sh, 2018-05-28); remove this unused shell function as well. Signed-off-by: René Scharfe --- git-rebase--preserve-merges.sh | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/git-rebase--preserve-merges.sh b/git-rebase--preserve-merges.sh index dec90e9af67..b9c71d2a71b 100644 --- a/git-rebase--preserve-merges.sh +++ b/git-rebase--preserve-merges.sh @@ -193,16 +193,6 @@ mark_action_done () { fi } -# Put the last action marked done at the beginning of the todo list -# again. If there has not been an action marked done yet, leave the list of -# items on the todo list unchanged. -reschedule_last_action () { - tail -n 1 "$done" | cat - "$todo" >"$todo".new - sed -e \$d <"$done" >"$done".new - mv -f "$todo".new "$todo" - mv -f "$done".new "$done" -} - append_todo_help () { gettext " Commands: -- 2.28.0 ``` ## Taylor Blau, 2020-08-12 13:48 Subject: Re: [PATCH] rebase: remove unused function reschedule_last_action Message-ID: <20200812134827.GB74542@syl.lan> URL: https://gitlist.dev/e/20200812134827.GB74542%40syl.lan In-Reply-To: <80744078-c0a9-5b55-0578-d6b62af6673b@web.de> ``` On Wed, Aug 12, 2020 at 03:45:47PM +0200, René Scharfe wrote: > The only caller of reschedule_last_action was removed by ef64bb328df > (rebase: strip unused code in git-rebase--preserve-merges.sh, > 2018-05-28); remove this unused shell function as well. Easy peasy ;-). Obviously correct, and thanks for cleaning this up. Reviewed-by: Taylor Blau > Signed-off-by: René Scharfe > --- > git-rebase--preserve-merges.sh | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/git-rebase--preserve-merges.sh b/git-rebase--preserve-merges.sh > index dec90e9af67..b9c71d2a71b 100644 > --- a/git-rebase--preserve-merges.sh > +++ b/git-rebase--preserve-merges.sh > @@ -193,16 +193,6 @@ mark_action_done () { > fi > } > > -# Put the last action marked done at the beginning of the todo list > -# again. If there has not been an action marked done yet, leave the list of > -# items on the todo list unchanged. > -reschedule_last_action () { > - tail -n 1 "$done" | cat - "$todo" >"$todo".new > - sed -e \$d <"$done" >"$done".new > - mv -f "$todo".new "$todo" > - mv -f "$done".new "$done" > -} > - > append_todo_help () { > gettext " > Commands: > -- > 2.28.0 Thanks, Taylor ``` ## Junio C Hamano, 2020-08-12 19:25 Subject: Re: [PATCH] rebase: remove unused function reschedule_last_action Message-ID: URL: https://gitlist.dev/e/xmqqv9hn650k.fsf%40gitster.c.googlers.com In-Reply-To: <20200812134827.GB74542@syl.lan> ``` Taylor Blau writes: > On Wed, Aug 12, 2020 at 03:45:47PM +0200, René Scharfe wrote: >> The only caller of reschedule_last_action was removed by ef64bb328df >> (rebase: strip unused code in git-rebase--preserve-merges.sh, >> 2018-05-28); remove this unused shell function as well. > > Easy peasy ;-). Obviously correct, and thanks for cleaning this up. > > Reviewed-by: Taylor Blau > >> Signed-off-by: René Scharfe I thought preserve-merges backend is on its way out, but I do not have objection to have some part of it retire earlier than the remainder of it ;-) Will queue. Thanks. >> --- >> git-rebase--preserve-merges.sh | 10 ---------- >> 1 file changed, 10 deletions(-) >> >> diff --git a/git-rebase--preserve-merges.sh b/git-rebase--preserve-merges.sh >> index dec90e9af67..b9c71d2a71b 100644 >> --- a/git-rebase--preserve-merges.sh >> +++ b/git-rebase--preserve-merges.sh >> @@ -193,16 +193,6 @@ mark_action_done () { >> fi >> } >> >> -# Put the last action marked done at the beginning of the todo list >> -# again. If there has not been an action marked done yet, leave the list of >> -# items on the todo list unchanged. >> -reschedule_last_action () { >> - tail -n 1 "$done" | cat - "$todo" >"$todo".new >> - sed -e \$d <"$done" >"$done".new >> - mv -f "$todo".new "$todo" >> - mv -f "$done".new "$done" >> -} >> - >> append_todo_help () { >> gettext " >> Commands: >> -- >> 2.28.0 > > Thanks, > Taylor ```