# [PATCH] upload-pack: remove superfluous sigchain_pop() call 3 messages from 2020-08-11 to 2020-08-11. Participants: René Scharfe, Taylor Blau, Junio C Hamano. Thread: https://gitlist.dev/t/54021 ## René Scharfe, 2020-08-11 17:15 Subject: [PATCH] upload-pack: remove superfluous sigchain_pop() call Message-ID: <29ac165c-8458-9bb1-7e59-e7c2c68a9f2a@web.de> URL: https://gitlist.dev/e/29ac165c-8458-9bb1-7e59-e7c2c68a9f2a%40web.de ``` 2997178ee6 (upload-pack: split check_unreachable() in two, prep for get_reachable_list(), 2016-06-12) moved most code of has_unreachable() into the new function do_reachable_revlist(). The latter takes care to ignore SIGPIPE during its operations, and restores the original signal handler before returning. However, a sigchain_pop(SIGPIPE) call remained in the error handling code of has_unreachable(), which does nothing because the stack is empty after do_reachable_revlist() cleaned up after itself. Remove it. Signed-off-by: René Scharfe --- upload-pack.c | 1 - 1 file changed, 1 deletion(-) diff --git a/upload-pack.c b/upload-pack.c index d087113d23e..1b068da0d26 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -731,7 +731,6 @@ static int has_unreachable(struct object_array *src, enum allow_uor allow_uor) return 0; error: - sigchain_pop(SIGPIPE); if (cmd.out >= 0) close(cmd.out); return 1; -- 2.28.0 ``` ## Taylor Blau, 2020-08-11 18:26 Subject: Re: [PATCH] upload-pack: remove superfluous sigchain_pop() call Message-ID: <20200811182603.GB33504@syl.lan> URL: https://gitlist.dev/e/20200811182603.GB33504%40syl.lan In-Reply-To: <29ac165c-8458-9bb1-7e59-e7c2c68a9f2a@web.de> ``` On Tue, Aug 11, 2020 at 07:15:03PM +0200, René Scharfe wrote: > 2997178ee6 (upload-pack: split check_unreachable() in two, prep for > get_reachable_list(), 2016-06-12) moved most code of has_unreachable() > into the new function do_reachable_revlist(). The latter takes care to > ignore SIGPIPE during its operations, and restores the original signal > handler before returning. > > However, a sigchain_pop(SIGPIPE) call remained in the error handling > code of has_unreachable(), which does nothing because the stack is > empty after do_reachable_revlist() cleaned up after itself. Remove it. Thanks for noticing. Your analysis seems correct to me after a quick inspection of the code, so this has my: Reviewed-by: Taylor Blau > Signed-off-by: René Scharfe > --- > upload-pack.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/upload-pack.c b/upload-pack.c > index d087113d23e..1b068da0d26 100644 > --- a/upload-pack.c > +++ b/upload-pack.c > @@ -731,7 +731,6 @@ static int has_unreachable(struct object_array *src, enum allow_uor allow_uor) > return 0; > > error: > - sigchain_pop(SIGPIPE); > if (cmd.out >= 0) > close(cmd.out); > return 1; > -- > 2.28.0 Thanks, Taylor ``` ## Junio C Hamano, 2020-08-11 21:01 Subject: Re: [PATCH] upload-pack: remove superfluous sigchain_pop() call Message-ID: URL: https://gitlist.dev/e/xmqqtux899sc.fsf%40gitster.c.googlers.com In-Reply-To: <20200811182603.GB33504@syl.lan> ``` Taylor Blau writes: > On Tue, Aug 11, 2020 at 07:15:03PM +0200, René Scharfe wrote: >> 2997178ee6 (upload-pack: split check_unreachable() in two, prep for >> get_reachable_list(), 2016-06-12) moved most code of has_unreachable() >> into the new function do_reachable_revlist(). The latter takes care to >> ignore SIGPIPE during its operations, and restores the original signal >> handler before returning. >> >> However, a sigchain_pop(SIGPIPE) call remained in the error handling >> code of has_unreachable(), which does nothing because the stack is >> empty after do_reachable_revlist() cleaned up after itself. Remove it. > > Thanks for noticing. Your analysis seems correct to me after a quick > inspection of the code, so this has my: > > Reviewed-by: Taylor Blau > >> Signed-off-by: René Scharfe >> --- >> upload-pack.c | 1 - >> 1 file changed, 1 deletion(-) Yeah, looks good to me, too. Thanks, both. >> diff --git a/upload-pack.c b/upload-pack.c >> index d087113d23e..1b068da0d26 100644 >> --- a/upload-pack.c >> +++ b/upload-pack.c >> @@ -731,7 +731,6 @@ static int has_unreachable(struct object_array *src, enum allow_uor allow_uor) >> return 0; >> >> error: >> - sigchain_pop(SIGPIPE); >> if (cmd.out >= 0) >> close(cmd.out); >> return 1; >> -- >> 2.28.0 > > Thanks, > Taylor ```