# [PATCH] githooks.txt: use correct "reference-transaction" hook name 3 messages from 2020-07-24 to 2020-07-24. Participants: starlord via GitGitGadget, Patrick Steinhardt, Junio C Hamano. Thread: https://gitlist.dev/t/53919 ## starlord via GitGitGadget, 2020-07-24 13:57 Subject: [PATCH] githooks.txt: use correct "reference-transaction" hook name Message-ID: URL: https://gitlist.dev/e/pull.681.git.1595599077623.gitgitgadget%40gmail.com ``` From: Bojun Chen The "reference transaction" hook was introduced in commit 6754159767 (refs: implement reference transaction hook, 2020-06-19). The name of the hook is declared as "reference-transaction" in "refs.c" and testcases, but the name declared in "githooks.txt" is different. Signed-off-by: Bojun Chen --- githooks.txt: use correct "reference-transaction" hook name Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FBerger7%2Fmaster-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger7/master-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/681 Documentation/githooks.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt index 642471109f..31b601e4bc 100644 --- a/Documentation/githooks.txt +++ b/Documentation/githooks.txt @@ -404,8 +404,8 @@ Both standard output and standard error output are forwarded to `git send-pack` on the other end, so you can simply `echo` messages for the user. -ref-transaction -~~~~~~~~~~~~~~~ +reference-transaction +~~~~~~~~~~~~~~~~~~~~~ This hook is invoked by any Git command that performs reference updates. It executes whenever a reference transaction is prepared, base-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda -- gitgitgadget ``` ## Patrick Steinhardt, 2020-07-24 14:21 Subject: Re: [PATCH] githooks.txt: use correct "reference-transaction" hook name Message-ID: <20200724142156.GB1032@xps.pks.im> URL: https://gitlist.dev/e/20200724142156.GB1032%40xps.pks.im In-Reply-To: ``` Hi Bojun, On Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote: > From: Bojun Chen > > The "reference transaction" hook was introduced in commit 6754159767 > (refs: implement reference transaction hook, 2020-06-19). The name of > the hook is declared as "reference-transaction" in "refs.c" and > testcases, but the name declared in "githooks.txt" is different. > > Signed-off-by: Bojun Chen Indeed, thanks for catching this! Reviewed-by: Patrick Steinhardt Patrick > --- > githooks.txt: use correct "reference-transaction" hook name > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FBerger7%2Fmaster-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger7/master-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/681 > > Documentation/githooks.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt > index 642471109f..31b601e4bc 100644 > --- a/Documentation/githooks.txt > +++ b/Documentation/githooks.txt > @@ -404,8 +404,8 @@ Both standard output and standard error output are forwarded to > `git send-pack` on the other end, so you can simply `echo` messages > for the user. > > -ref-transaction > -~~~~~~~~~~~~~~~ > +reference-transaction > +~~~~~~~~~~~~~~~~~~~~~ > > This hook is invoked by any Git command that performs reference > updates. It executes whenever a reference transaction is prepared, > > base-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda > -- > gitgitgadget ``` ## Junio C Hamano, 2020-07-24 20:54 Subject: Re: [PATCH] githooks.txt: use correct "reference-transaction" hook name Message-ID: URL: https://gitlist.dev/e/xmqqmu3ok516.fsf%40gitster.c.googlers.com In-Reply-To: <20200724142156.GB1032@xps.pks.im> ``` Patrick Steinhardt writes: > Hi Bojun, > > On Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote: >> From: Bojun Chen >> >> The "reference transaction" hook was introduced in commit 6754159767 >> (refs: implement reference transaction hook, 2020-06-19). The name of >> the hook is declared as "reference-transaction" in "refs.c" and >> testcases, but the name declared in "githooks.txt" is different. >> >> Signed-off-by: Bojun Chen > > Indeed, thanks for catching this! > > Reviewed-by: Patrick Steinhardt Thanks. ```