[RFC] subtree: use say and exit 0 rather than die in case of no new revision found scenario

Claus Schneider· May 6, 2020, 13:11 UTC · lore

Hi..

Currently subtree dies if "No new revisions found" which is hard as it is a non-operation.

I suggest using the "say" command rather than "die".

It will then become easier just to call "git subtree split" and you do not need to handle this special case.

Patches can be found here: https://github.com/git/git/commit/fe435a1ba128698f6acb69ee1891c45be32610fa

Best regards Claus Schneider

Taylor Blau· May 6, 2020, 17:37 UTC · re: Claus Schneider · lore

Re: [RFC] subtree: use say and exit 0 rather than die in case of no new revision found scenario

Hi Claus,

On Wed, May 06, 2020 at 03:11:49PM +0200, Claus Schneider wrote:

Show 12 quoted lines

> Hi..
>
> Currently subtree dies if "No new revisions found" which is hard as it
> is a non-operation.
>
> I suggest using the "say" command rather than "die".
>
> It will then become easier just to call "git subtree split" and you do
> not need to handle this special case.
>
> Patches can be found here:
> https://github.com/git/git/commit/fe435a1ba128698f6acb69ee1891c45be32610fa

Thanks for your patch. The Git mailing list reviews patches over email, so please re-submit this (and the other two patches) you sent to the list here.

Detailed guidelines on how to do that are here:

  https://github.com/git/git/blob/master/Documentation/SubmittingPatches

and

  https://github.com/git/git/blob/master/Documentation/MyFirstContribution.txt

Alternatively, you may use GitGitGadget, which makes it convenient to send patches to the mailing list from GitHub's UI. More information about that may be found here: https://gitgitgadget.github.io/.

> Best regards
> Claus Schneider

Thanks, Taylor