# The closing bracket is missing.

3 messages from 2020-04-03 to 2020-04-03. Participants: number201724, brian m. carlson, Junio C Hamano.
Thread: https://gitlist.dev/t/53161

## number201724, 2020-04-03 02:39

Subject: The closing bracket is missing.
Message-ID: <8d439c14-6b39-bbb7-a558-61c1e79ff1f3@me.com>
URL: https://gitlist.dev/e/8d439c14-6b39-bbb7-a558-61c1e79ff1f3%40me.com

```
command-list.h:53:69: error: expected ‘}’ before ‘;’ token
    53 |  { "git-apply", N_("Apply a patch to files and/or to the 
index"), 0};

command-list.h  The closing bracket is missing. In the master branch.


```

## brian m. carlson, 2020-04-03 20:27

Subject: Re: The closing bracket is missing.
Message-ID: <20200403202709.GC6369@camp.crustytoothpaste.net>
URL: https://gitlist.dev/e/20200403202709.GC6369%40camp.crustytoothpaste.net
In-Reply-To: <8d439c14-6b39-bbb7-a558-61c1e79ff1f3@me.com>

```
On 2020-04-03 at 02:39:10, number201724 wrote:
> command-list.h:53:69: error: expected ‘}’ before ‘;’ token
>    53 |  { "git-apply", N_("Apply a patch to files and/or to the index"),
> 0};
> 
> command-list.h  The closing bracket is missing. In the master branch.

I don't see this behavior when compiling on my system, which is a Debian
sid/amd64 system.  Can you tell us a little more about your system and
its version, including what shell is being used for /bin/sh, how you're
building (with make or with configure), and anything else that might be
relevant?
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

```

## Junio C Hamano, 2020-04-03 21:25

Subject: Re: The closing bracket is missing.
Message-ID: <xmqqzhbsxnvm.fsf@gitster.c.googlers.com>
URL: https://gitlist.dev/e/xmqqzhbsxnvm.fsf%40gitster.c.googlers.com
In-Reply-To: <20200403202709.GC6369@camp.crustytoothpaste.net>

```
"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> On 2020-04-03 at 02:39:10, number201724 wrote:
>> command-list.h:53:69: error: expected ‘}’ before ‘;’ token
>>    53 |  { "git-apply", N_("Apply a patch to files and/or to the index"),
>> 0};
>> 
>> command-list.h  The closing bracket is missing. In the master branch.
>
> I don't see this behavior when compiling on my system, which is a Debian
> sid/amd64 system.  Can you tell us a little more about your system and
> its version, including what shell is being used for /bin/sh, how you're
> building (with make or with configure), and anything else that might be
> relevant?

Good suggestion.  As this is a generated file, we can have issues
with the different behaviour in the commands used in the toolchain
to create it.

```