# [PATCH] prepare_shell_cmd: add code comment 2 messages from 2020-03-06 to 2020-03-26. Participants: Alexandr Miloslavskiy via GitGitGadget, Alexandr Miloslavskiy. Thread: https://gitlist.dev/t/52946 ## Alexandr Miloslavskiy via GitGitGadget, 2020-03-06 12:41 Subject: [PATCH] prepare_shell_cmd: add code comment Message-ID: URL: https://gitlist.dev/e/pull.574.git.1583498508362.gitgitgadget%40gmail.com ``` From: Alexandr Miloslavskiy While debugging something else, I was quite puzzled to see that `prepare_shell_cmd()` duplicates the command before sending to sh, like: sh -c "git-upload-pack '../testrepo/.git'" "git-upload-pack '../testrepo/.git'" A Windows programmer myself, initially I thought that it's a bug. Add a clarifying comment. Signed-off-by: Alexandr Miloslavskiy --- prepare_shell_cmd: add code comment While debugging something else, I was quite puzzled to see that prepare_shell_cmd() duplicates the command before sending to sh, like: sh -c "git-upload-pack '../testrepo/.git'" "git-upload-pack '../testrepo/.git'" A Windows programmer myself, initially I thought that it's a bug. Add a clarifying comment. Signed-off-by: Alexandr Miloslavskiy alexandr.miloslavskiy@syntevo.com [alexandr.miloslavskiy@syntevo.com] Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-574%2FSyntevoAlex%2F%230259(git)_doubled_prepare_shell_cmd-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-574/SyntevoAlex/#0259(git)_doubled_prepare_shell_cmd-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/574 run-command.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/run-command.c b/run-command.c index f5e1149f9b3..95ab3c168bc 100644 --- a/run-command.c +++ b/run-command.c @@ -284,6 +284,12 @@ static const char **prepare_shell_cmd(struct argv_array *out, const char **argv) argv_array_push(out, argv[0]); else argv_array_pushf(out, "%s \"$@\"", argv[0]); + + /* + * -c expects shell_name after command_string. + * Pushing entire original argv below will pass argv[0] + * as shell name. + */ } argv_array_pushv(out, argv); base-commit: 076cbdcd739aeb33c1be87b73aebae5e43d7bcc5 -- gitgitgadget ``` ## Alexandr Miloslavskiy, 2020-03-26 14:38 Subject: Re: [PATCH] prepare_shell_cmd: add code comment Message-ID: <909e1c13-1c9c-7a15-5095-76846865e388@syntevo.com> URL: https://gitlist.dev/e/909e1c13-1c9c-7a15-5095-76846865e388%40syntevo.com In-Reply-To: ``` Reminder: the patch is still there :( ```