threads / bug / 52744

[bug] git-rev-parse sometimes appends subdirectories to result

Subject: [bug] git-rev-parse sometimes appends subdirectories to result

## tl;dr

2 messages between Feb 3, 2020 and Feb 3, 2020.

replies: 1people: 1as markdown or json

masukomi· Feb 3, 2020, 20:14 UTC · lore
Expected behavior

No matter what subdirectory of my repo I am in git rev-parse --show-toplevel will always return the same result

Actual behavior

Depending on what subdirectories you are in it will sometimes (not always) start appending those subdirectories to the path.

Reproduction
My git repo root is at
/Users/masukomi/workspace/private_comments

If i run git rev-parse --show-toplevel within that directory it returns the correct (identical) path. If i run it within /Users/masukomi/workspace/private_comments/src it returns the correct path (without the /src) If I run it within /Users/masukomi/workspace/private_comments/src/tests it suddenly starts returning

/Users/masukomi/workspace/private_comments/src/tests
Notes

Git 2.25.0 macOS 10.15.3 installed via homebrew. no submodules present.

- Kay Rhodes
https://masukomi.org
masukomi· Feb 3, 2020, 20:45 UTC · re: masukomi · lore

Re: [bug] git-rev-parse sometimes appends subdirectories to result

Nevermind. False alarm.
There's a .git directory in the subdirectory src/tests

I _thought_ i had checked for that, but I dunno... apparently i didn't check well.

It is working as expected.
- Kay Rhodes
https://masukomi.org
On Mon, Feb 3, 2020 at 3:14 PM masukomi <masukomi@masukomi.org> wrote:
Show 38 quoted lines
>
> Expected behavior
>
> No matter what subdirectory of my repo I am in git rev-parse
> --show-toplevel will always return the same result
>
> Actual behavior
>
> Depending on what subdirectories you are in it will sometimes (not
> always) start appending those subdirectories to the path.
>
> Reproduction
>
> My git repo root is at
>
> /Users/masukomi/workspace/private_comments
>
> If i run git rev-parse --show-toplevel within that directory it
> returns the correct (identical) path.
> If i run it within /Users/masukomi/workspace/private_comments/src it
> returns the correct path (without the /src)
> If I run it within
> /Users/masukomi/workspace/private_comments/src/tests it suddenly
> starts returning
>
> /Users/masukomi/workspace/private_comments/src/tests
>
> Notes
>
> Git 2.25.0
> macOS 10.15.3
> installed via homebrew.
> no submodules present.
>
>
>
> - Kay Rhodes
> https://masukomi.org

← back to recent threads