# Git 2.25 and failed self tests on OS X 5 messages from 2020-02-03 to 2020-02-03. Participants: Jeffrey Walton, Jeff King, Torsten Bögershausen. Thread: https://gitlist.dev/t/52741 ## Jeffrey Walton, 2020-02-03 04:08 Subject: Git 2.25 and failed self tests on OS X Message-ID: URL: https://gitlist.dev/e/CAH8yC8kXPi0teqdZ8NRJ677Z6btbmdafR%3Dy4MFFaKZgZrB%3Dd4A%40mail.gmail.com ``` Hi Everyone, I'm seeing some self-tests failures building the 2.25 release tarball on OS X. I'm seeing it on the old PowerMac with OS X 10.5, and a modern Intel Mac with OS X 10.9. PowerMac failures are not too surprising, but the modern Mac should probably pass its self tests. *** t3902-quoted.sh *** not ok 1 - setup # # # mkdir "$FN" && # for_each_name "echo initial >\"\$name\"" && # git add . && # git commit -q -m Initial && # # for_each_name "echo second >\"\$name\"" && # git commit -a -m Second && # # for_each_name "echo modified >\"\$name\"" # # ok 2 - setup expected files not ok 3 - check fully quoted output from ls-files # # # git ls-files >current && test_cmp expect.quoted current # # not ok 4 - check fully quoted output from diff-files # # # git diff --name-only >current && # test_cmp expect.quoted current # # not ok 5 - check fully quoted output from diff-index # # # git diff --name-only HEAD >current && # test_cmp expect.quoted current # # not ok 6 - check fully quoted output from diff-tree # # # git diff --name-only HEAD^ HEAD >current && # test_cmp expect.quoted current # # not ok 7 - check fully quoted output from ls-tree # # # git ls-tree --name-only -r HEAD >current && # test_cmp expect.quoted current # # ok 8 - setting core.quotepath not ok 9 - check fully quoted output from ls-files # # # git ls-files >current && test_cmp expect.raw current # # not ok 10 - check fully quoted output from diff-files # # # git diff --name-only >current && # test_cmp expect.raw current # # not ok 11 - check fully quoted output from diff-index # # # git diff --name-only HEAD >current && # test_cmp expect.raw current # # not ok 12 - check fully quoted output from diff-tree # # # git diff --name-only HEAD^ HEAD >current && # test_cmp expect.raw current # # not ok 13 - check fully quoted output from ls-tree # # # git ls-tree --name-only -r HEAD >current && # test_cmp expect.raw current # # # failed 11 among 13 test(s) 1..13 Setting LC_ALL=en_US.UTF-8 and LANG=en_US.UTF-8 did not help. (I've seen sed and awk produce unusual results when they are not set). Jeff ``` ## Jeff King, 2020-02-03 08:43 Subject: Re: Git 2.25 and failed self tests on OS X Message-ID: <20200203084356.GB2164@coredump.intra.peff.net> URL: https://gitlist.dev/e/20200203084356.GB2164%40coredump.intra.peff.net In-Reply-To: ``` On Sun, Feb 02, 2020 at 11:08:17PM -0500, Jeffrey Walton wrote: > I'm seeing some self-tests failures building the 2.25 release tarball > on OS X. I'm seeing it on the old PowerMac with OS X 10.5, and a > modern Intel Mac with OS X 10.9. PowerMac failures are not too > surprising, but the modern Mac should probably pass its self tests. > > *** t3902-quoted.sh *** > not ok 1 - setup > # > # > # mkdir "$FN" && > # for_each_name "echo initial >\"\$name\"" && > # git add . && > # git commit -q -m Initial && > # > # for_each_name "echo second >\"\$name\"" && > # git commit -a -m Second && > # > # for_each_name "echo modified >\"\$name\"" It's hard to see what's going on with this output. Try running: ./t3902-quoted.sh -v -x -i to get more verbose output. Looking at this test, it tries to create files with funny characters in the names. Presumably your filesystem isn't happy with one or more of them. The verbose output will probably make it clear which. Version 10.9 isn't incredibly new, but these tests have been around a long time. If OS X has a problem with these filenames, it seems odd for it to be surfacing now. Do you know what filesystem you're using? You aren't running the tests by any chance on a network mount from a Windows machine? -Peff ``` ## Jeffrey Walton, 2020-02-03 11:00 Subject: Re: Git 2.25 and failed self tests on OS X Message-ID: URL: https://gitlist.dev/e/CAH8yC8%3D-ht7D3CyM-YoJSfW3hueaWVp5WQz2%2BBJOFMjmt8aDsg%40mail.gmail.com In-Reply-To: <20200203084356.GB2164@coredump.intra.peff.net> ``` On Mon, Feb 3, 2020 at 3:43 AM Jeff King wrote: > > On Sun, Feb 02, 2020 at 11:08:17PM -0500, Jeffrey Walton wrote: > > > I'm seeing some self-tests failures building the 2.25 release tarball > > on OS X. I'm seeing it on the old PowerMac with OS X 10.5, and a > > modern Intel Mac with OS X 10.9. PowerMac failures are not too > > surprising, but the modern Mac should probably pass its self tests. > > > > *** t3902-quoted.sh *** > > not ok 1 - setup > > # > > # > > # mkdir "$FN" && > > # for_each_name "echo initial >\"\$name\"" && > > # git add . && > > # git commit -q -m Initial && > > # > > # for_each_name "echo second >\"\$name\"" && > > # git commit -a -m Second && > > # > > # for_each_name "echo modified >\"\$name\"" > > It's hard to see what's going on with this output. Try running: > > ./t3902-quoted.sh -v -x -i > > to get more verbose output. > > Looking at this test, it tries to create files with funny characters in > the names. Presumably your filesystem isn't happy with one or more of > them. The verbose output will probably make it clear which. > > Version 10.9 isn't incredibly new, but these tests have been around a > long time. If OS X has a problem with these filenames, it seems odd for > it to be surfacing now. > > Do you know what filesystem you're using? You aren't running the tests > by any chance on a network mount from a Windows machine? According to `diskutil info /`, the filesystem is Journaled HFS+. The tests are running locally on the Mac after logging in over SSH. I'm wondering if Perl is the problem. I had to cut-over to OpenSSL 1.1 due to deprecation of 1.0.2. OpenSSL 1.1 increased Perl requirements, so now I have to build Perl, too. Previously I was not building Perl. I'm installing Perl 5.30.1, but it is a minimal install. I only install Text::Template Test::More (plus whatever else Perl installs on its own from cspan). However I could not install HTTP::Daemon HTTP::Request. There's some bug in the cspan installer. It gets stuck on one package and tries to download/install it over and over again. Do you know if Git is using one of Perl's Text:: packages for the test? Jeff ``` ## Jeff King, 2020-02-03 11:06 Subject: Re: Git 2.25 and failed self tests on OS X Message-ID: <20200203110616.GB4153124@coredump.intra.peff.net> URL: https://gitlist.dev/e/20200203110616.GB4153124%40coredump.intra.peff.net In-Reply-To: ``` On Mon, Feb 03, 2020 at 06:00:18AM -0500, Jeffrey Walton wrote: > I'm wondering if Perl is the problem. I had to cut-over to OpenSSL 1.1 > due to deprecation of 1.0.2. OpenSSL 1.1 increased Perl requirements, > so now I have to build Perl, too. Previously I was not building Perl. > > I'm installing Perl 5.30.1, but it is a minimal install. I only > install Text::Template Test::More (plus whatever else Perl installs on > its own from cspan). However I could not install HTTP::Daemon > HTTP::Request. There's some bug in the cspan installer. It gets stuck > on one package and tries to download/install it over and over again. > > Do you know if Git is using one of Perl's Text:: packages for the test? I don't see any perl at all in t3902. The failing "setup" test is all shell, and is literally just doing "echo stuff >$file_with_funny_chars" in a loop. -Peff ``` ## Torsten Bögershausen, 2020-02-03 16:53 Subject: Re: Git 2.25 and failed self tests on OS X Message-ID: <20200203165318.eq3tjo5ja4pdjf7d@tb-raspi4> URL: https://gitlist.dev/e/20200203165318.eq3tjo5ja4pdjf7d%40tb-raspi4 In-Reply-To: ``` On Mon, Feb 03, 2020 at 06:00:18AM -0500, Jeffrey Walton wrote: > On Mon, Feb 3, 2020 at 3:43 AM Jeff King wrote: > > > > On Sun, Feb 02, 2020 at 11:08:17PM -0500, Jeffrey Walton wrote: > > > > > I'm seeing some self-tests failures building the 2.25 release tarball > > > on OS X. I'm seeing it on the old PowerMac with OS X 10.5, and a > > > modern Intel Mac with OS X 10.9. PowerMac failures are not too > > > surprising, but the modern Mac should probably pass its self tests. > > > > > > *** t3902-quoted.sh *** > > > not ok 1 - setup > > > # > > > # > > > # mkdir "$FN" && > > > # for_each_name "echo initial >\"\$name\"" && > > > # git add . && > > > # git commit -q -m Initial && > > > # > > > # for_each_name "echo second >\"\$name\"" && > > > # git commit -a -m Second && > > > # > > > # for_each_name "echo modified >\"\$name\"" > > > > It's hard to see what's going on with this output. Try running: > > > > ./t3902-quoted.sh -v -x -i > > > > to get more verbose output. > > > > Looking at this test, it tries to create files with funny characters in > > the names. Presumably your filesystem isn't happy with one or more of > > them. The verbose output will probably make it clear which. > > > > Version 10.9 isn't incredibly new, but these tests have been around a > > long time. If OS X has a problem with these filenames, it seems odd for > > it to be surfacing now. > > > > Do you know what filesystem you're using? You aren't running the tests > > by any chance on a network mount from a Windows machine? > > According to `diskutil info /`, the filesystem is Journaled HFS+. The > tests are running locally on the Mac after logging in over SSH. > > I'm wondering if Perl is the problem. I had to cut-over to OpenSSL 1.1 > due to deprecation of 1.0.2. OpenSSL 1.1 increased Perl requirements, > so now I have to build Perl, too. Previously I was not building Perl. > > I'm installing Perl 5.30.1, but it is a minimal install. I only > install Text::Template Test::More (plus whatever else Perl installs on > its own from cspan). However I could not install HTTP::Daemon > HTTP::Request. There's some bug in the cspan installer. It gets stuck > on one package and tries to download/install it over and over again. > > Do you know if Git is using one of Perl's Text:: packages for the test? > > Jeff Shooting out into the blue: Which shell are you using when logging in via ssh ? ```