# [PATCHv1 0/1] git-p4: fix file descriptor leak 3 messages from 2020-01-30 to 2020-01-30. Participants: Luke Diamand, Junio C Hamano. Thread: https://gitlist.dev/t/52717 ## Luke Diamand, 2020-01-30 11:50 Subject: [PATCHv1 0/1] git-p4: fix file descriptor leak Message-ID: <20200130115034.6191-1-luke@diamand.org> URL: https://gitlist.dev/e/20200130115034.6191-1-luke%40diamand.org ``` Spotted by Eric Sunshine here: https://public-inbox.org/git/CAPig+cRx3hG64nuDie69o_gdX39F=sR6D8LyA7J1rCErgu0aMA@mail.gmail.com/ There are at least two more of these, but I would prefer to leave them alone until the python3 changes have been merged. Luke Diamand (1): git-p4: avoid leak of file handle when cloning git-p4.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.20.1.390.gb5101f9297 ``` ## Luke Diamand, 2020-01-30 11:50 Subject: [PATCHv1 1/1] git-p4: avoid leak of file handle when cloning Message-ID: <20200130115034.6191-2-luke@diamand.org> URL: https://gitlist.dev/e/20200130115034.6191-2-luke%40diamand.org In-Reply-To: <20200130115034.6191-1-luke@diamand.org> ``` Spotted by Eric Sunshine: https://public-inbox.org/git/CAPig+cRx3hG64nuDie69o_gdX39F=sR6D8LyA7J1rCErgu0aMA@mail.gmail.com/ Signed-off-by: Luke Diamand --- git-p4.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/git-p4.py b/git-p4.py index eb5bc28cf9..9a71a6690d 100755 --- a/git-p4.py +++ b/git-p4.py @@ -3563,7 +3563,8 @@ def importRevisions(self, args, branch_arg_given): changes = [] if len(self.changesFile) > 0: - output = open(self.changesFile).readlines() + with open(self.changesFile) as f: + output = f.readlines() changeSet = set() for line in output: changeSet.add(int(line)) -- 2.20.1.390.gb5101f9297 ``` ## Junio C Hamano, 2020-01-30 20:22 Subject: Re: [PATCHv1 1/1] git-p4: avoid leak of file handle when cloning Message-ID: URL: https://gitlist.dev/e/xmqqv9osbsov.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20200130115034.6191-2-luke@diamand.org> ``` Luke Diamand writes: > Spotted by Eric Sunshine: > > https://public-inbox.org/git/CAPig+cRx3hG64nuDie69o_gdX39F=sR6D8LyA7J1rCErgu0aMA@mail.gmail.com/ > > Signed-off-by: Luke Diamand > --- > git-p4.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/git-p4.py b/git-p4.py > index eb5bc28cf9..9a71a6690d 100755 > --- a/git-p4.py > +++ b/git-p4.py > @@ -3563,7 +3563,8 @@ def importRevisions(self, args, branch_arg_given): > changes = [] > > if len(self.changesFile) > 0: > - output = open(self.changesFile).readlines() > + with open(self.changesFile) as f: > + output = f.readlines() > changeSet = set() > for line in output: > changeSet.add(int(line)) I was scratching my head until I realized that this is PATCH 7/6 of the other 6-patch series. Will queue together with the other ones. Thanks. ```