# [PATCH] config/advice.txt: fix description list separator 2 messages from 2020-01-08 to 2020-01-08. Participants: Martin Ågren, Junio C Hamano. Thread: https://gitlist.dev/t/52595 ## Martin Ågren, 2020-01-08 20:08 Subject: [PATCH] config/advice.txt: fix description list separator Message-ID: <20200108200844.30803-1-martin.agren@gmail.com> URL: https://gitlist.dev/e/20200108200844.30803-1-martin.agren%40gmail.com ``` The whole submoduleAlternateErrorStrategyDie item is interpreted as being part of the supporting content of the preceding item. This is because we don't give a double-colon "::" for the separator, but just a single colon, ":". Let's fix that. There are a few other matches for [^:]:\s*$ in Documentation/config, but I didn't spot any similar bugs among them. Signed-off-by: Martin Ågren --- This was the only thing that stood out at me while going through `./doc-diff v2.24.0 origin/master`. This is obviously a non-critical, purely cosmetic issue. Documentation/config/advice.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config/advice.txt b/Documentation/config/advice.txt index d4e698cd3f..4be93f8ad9 100644 --- a/Documentation/config/advice.txt +++ b/Documentation/config/advice.txt @@ -107,7 +107,7 @@ advice.*:: editor input from the user. nestedTag:: Advice shown if a user attempts to recursively tag a tag object. - submoduleAlternateErrorStrategyDie: + submoduleAlternateErrorStrategyDie:: Advice shown when a submodule.alternateErrorStrategy option configured to "die" causes a fatal error. -- -- 2.25.0.rc1.19.g042ed3e048 ``` ## Junio C Hamano, 2020-01-08 21:16 Subject: Re: [PATCH] config/advice.txt: fix description list separator Message-ID: URL: https://gitlist.dev/e/xmqqftgp1we0.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20200108200844.30803-1-martin.agren@gmail.com> ``` Martin Ågren writes: > The whole submoduleAlternateErrorStrategyDie item is interpreted as > being part of the supporting content of the preceding item. This is > because we don't give a double-colon "::" for the separator, but just a > single colon, ":". Let's fix that. > > There are a few other matches for [^:]:\s*$ in Documentation/config, but > I didn't spot any similar bugs among them. > > Signed-off-by: Martin Ågren > --- > This was the only thing that stood out at me while going through > `./doc-diff v2.24.0 origin/master`. This is obviously a non-critical, > purely cosmetic issue. Thanks. It still is a new bug introduced by a recent change, so I am tempted to include it in the final but it is a bit too late for the -rc2 I planned to tag today. > > Documentation/config/advice.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/config/advice.txt b/Documentation/config/advice.txt > index d4e698cd3f..4be93f8ad9 100644 > --- a/Documentation/config/advice.txt > +++ b/Documentation/config/advice.txt > @@ -107,7 +107,7 @@ advice.*:: > editor input from the user. > nestedTag:: > Advice shown if a user attempts to recursively tag a tag object. > - submoduleAlternateErrorStrategyDie: > + submoduleAlternateErrorStrategyDie:: > Advice shown when a submodule.alternateErrorStrategy option > configured to "die" causes a fatal error. > -- ```