# [PATCH v2] git-gui: allow closing console window with Escape

2 messages from 2019-12-18 to 2019-12-22. Participants: Pratyush Yadav.
Thread: https://gitlist.dev/t/52486

## Pratyush Yadav, 2019-12-18 19:58

Subject: [PATCH v2] git-gui: allow closing console window with Escape
Message-ID: <20191218195809.7658-1-me@yadavpratyush.com>
URL: https://gitlist.dev/e/20191218195809.7658-1-me%40yadavpratyush.com

```
This gives users a quick shortcut to close the window. But since the
window can also show commands in progress, closing the window on Escape
can give the perception that the command has been cancelled even though
it hasn't been. So, only enable this binding when the command is done.

Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
---
Changes in v2:
- Only allow closing the window on Escape when the command is done.

 lib/console.tcl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/console.tcl b/lib/console.tcl
index 1f3248f..bb6b9c8 100644
--- a/lib/console.tcl
+++ b/lib/console.tcl
@@ -203,6 +203,8 @@ method done {ok} {
 			focus $w.ok
 		}
 	}
+
+	bind $w <Key-Escape> "destroy $w;break"
 }

 method _sb_set {sb orient first last} {
--
2.24.1


```

## Pratyush Yadav, 2019-12-22 09:59

Subject: Re: [PATCH v2] git-gui: allow closing console window with Escape
Message-ID: <20191222095921.drny6mg3h6y4l3zw@yadavpratyush.com>
URL: https://gitlist.dev/e/20191222095921.drny6mg3h6y4l3zw%40yadavpratyush.com
In-Reply-To: <20191218195809.7658-1-me@yadavpratyush.com>

```
On 19/12/19 01:28AM, Pratyush Yadav wrote:
> This gives users a quick shortcut to close the window. But since the
> window can also show commands in progress, closing the window on Escape
> can give the perception that the command has been cancelled even though
> it hasn't been. So, only enable this binding when the command is done.
> 
> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>

Merged to 'master'.

-- 
Regards,
Pratyush Yadav

```