threads / discuss / 52449

Regression in 2.24.1 wrt progress indication

Subject: Regression in 2.24.1 wrt progress indication

## tl;dr

5 messages between Dec 13, 2019 and Dec 13, 2019.

replies: 4people: 3as markdown or json

Charles Diza· Dec 13, 2019, 17:28 UTC · lore
I reported a bug in progress display in git 2.23.0 earlier this year in August.  This bug got fixed: https://public-inbox.org/git/20191002154734.GC6116@sigill.intra.peff.net/
(See the earlier parts of that thread for the bug report.)
I am sorry to report that this bug has returned in 2.24.1.
Charles
Jeff King· Dec 13, 2019, 17:38 UTC · re: Charles Diza · lore

Re: Regression in 2.24.1 wrt progress indication

On Fri, Dec 13, 2019 at 12:28:35PM -0500, Charles Diza wrote:
Show 7 quoted lines
> I reported a bug in progress display in git 2.23.0 earlier this year
> in August.  This bug got fixed:
> https://public-inbox.org/git/20191002154734.GC6116@sigill.intra.peff.net/
> 
> (See the earlier parts of that thread for the bug report.)
> 
> I am sorry to report that this bug has returned in 2.24.1.

The bug in question typically showed due to the server side of the connection. Do you see it during a fetch (or pull) or push? If so, what server are you using? Is it possible that that server upgraded recently, and it has nothing to do with what version you're running on the client?

-Peff
Charles Diza· Dec 13, 2019, 22:21 UTC · re: Jeff King · lore

Re: Regression in 2.24.1 wrt progress indication

On Fri, Dec 13, 2019 at 12:38:58PM -0500, Jeff King wrote:
Show 14 quoted lines
> On Fri, Dec 13, 2019 at 12:28:35PM -0500, Charles Diza wrote:
>
> > I reported a bug in progress display in git 2.23.0 earlier this year
> > in August.  This bug got fixed:
> > https://public-inbox.org/git/20191002154734.GC6116@sigill.intra.peff.net/
> >
> > (See the earlier parts of that thread for the bug report.)
> >
> > I am sorry to report that this bug has returned in 2.24.1.
>
> The bug in question typically showed due to the server side of the
> connection. Do you see it during a fetch (or pull) or push? If so, what
> server are you using? Is it possible that that server upgraded recently,
> and it has nothing to do with what version you're running on the client?

It happens during pull. I've seen this when pulling from gitlab. Reverting to 2.24.0 fixes the problem.

-Charles
>
> -Peff
Jeff King· Dec 13, 2019, 22:35 UTC · re: Charles Diza · lore

Re: Regression in 2.24.1 wrt progress indication

On Fri, Dec 13, 2019 at 05:21:56PM -0500, Charles Diza wrote:
Show 7 quoted lines
> > The bug in question typically showed due to the server side of the
> > connection. Do you see it during a fetch (or pull) or push? If so, what
> > server are you using? Is it possible that that server upgraded recently,
> > and it has nothing to do with what version you're running on the client?
> 
> It happens during pull.  I've seen this when pulling from gitlab.
> Reverting to 2.24.0 fixes the problem.

gitlab.com is running v2.22.2, which has the bug. And I see it whether my client is v2.24.0 or v2.24.1. Are you sure it comes and goes between client versions?

Note that it is impacted by your terminal width, as well (it only shows up if your terminal is lower than some width; 80 chars, I think).

-Peff
SZEDER Gábor· Dec 13, 2019, 22:41 UTC · re: Jeff King · lore

Re: Regression in 2.24.1 wrt progress indication

On Fri, Dec 13, 2019 at 05:35:54PM -0500, Jeff King wrote:
Show 12 quoted lines
> On Fri, Dec 13, 2019 at 05:21:56PM -0500, Charles Diza wrote:
> 
> > > The bug in question typically showed due to the server side of the
> > > connection. Do you see it during a fetch (or pull) or push? If so, what
> > > server are you using? Is it possible that that server upgraded recently,
> > > and it has nothing to do with what version you're running on the client?
> > 
> > It happens during pull.  I've seen this when pulling from gitlab.
> > Reverting to 2.24.0 fixes the problem.
> 
> gitlab.com is running v2.22.2, which has the bug. And I see it whether
> my client is v2.24.0 or v2.24.1. 
Me too.
Show 5 quoted lines
> Are you sure it comes and goes between
> client versions?
> 
> Note that it is impacted by your terminal width, as well (it only shows
> up if your terminal is lower than some width; 80 chars, I think).
88 chars.  8 chars of "remote: " prefix + 80 spaces.

← back to recent threads