threads / patch / 52431

patcht7004: don't create unused file

Subject: [PATCH] t7004: don't create unused file

## tl;dr

2 messages between Dec 11, 2019 and Dec 11, 2019. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

René Scharfe· Dec 11, 2019, 18:46 UTC · lore

msgfile2 became unused with 3968658599 (Make builtin-tag.c use parse_options., 2007-11-09), get rid of it.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 t/t7004-tag.sh | 1 -
 1 file changed, 1 deletion(-)

Show changes to t/t7004-tag.sh +0 −2

diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index 4a09bea1d6..6db92bd3ba 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -517,7 +517,6 @@ test_expect_success \
 test_expect_success \
 	'trying to create tags giving both -m or -F options should fail' '
 	echo "message file 1" >msgfile1 &&
-	echo "message file 2" >msgfile2 &&
 	! tag_exists msgtag &&
 	test_must_fail git tag -m "message 1" -F msgfile1 msgtag &&
 	! tag_exists msgtag &&
--
2.24.1

Derrick Stolee· Dec 11, 2019, 18:59 UTC · re: René Scharfe · lore

Re: [PATCH] t7004: don't create unused file

On 12/11/2019 1:46 PM, René Scharfe wrote:

Show 9 quoted lines

> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> index 4a09bea1d6..6db92bd3ba 100755
> --- a/t/t7004-tag.sh
> +++ b/t/t7004-tag.sh
> @@ -517,7 +517,6 @@ test_expect_success \
>  test_expect_success \
>  	'trying to create tags giving both -m or -F options should fail' '
>  	echo "message file 1" >msgfile1 &&
> -	echo "message file 2" >msgfile2 &&

Obviously correct.

-Stolee