threads / patch / 52378

patchpkt-line: fix a typo

Subject: [PATCH 0/1] pkt-line: fix a typo

## tl;dr

4 messages between Dec 2, 2019 and Dec 2, 2019. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Johannes Schindelin via GitGitGadget· Dec 2, 2019, 08:43 UTC · lore

I stumbled over this during some investigation recently, together with the "initilize" and the "occured" typos. Fixes for the latter have been contributed, so I won't do that again, but this one was still unaddressed.

Johannes Schindelin (1):
  pkt-line: fix a typo
 pkt-line.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: d9f6f3b6195a0ca35642561e530798ad1469bd41
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-481%2Fdscho%2Fassigined-tyop-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-481/dscho/assigined-tyop-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/481
-- 
gitgitgadget
Johannes Schindelin via GitGitGadget· Dec 2, 2019, 08:43 UTC · re: Johannes Schindelin via GitGitGadget · lore

[PATCH 1/1] pkt-line: fix a typo

From: Johannes Schindelin <johannes.schindelin@gmx.de>

This typo was introduced in 2153d478b74 (pkt-line: introduce packet_read_with_status, 2018-03-14).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 pkt-line.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to pkt-line.h +1 −1
diff --git a/pkt-line.h b/pkt-line.h
index 5c62015db4..fef3a0d792 100644
--- a/pkt-line.h
+++ b/pkt-line.h
@@ -77,7 +77,7 @@ int packet_read(int fd, char **src_buffer, size_t *src_len, char
 /*
  * Read a packetized line into a buffer like the 'packet_read()' function but
  * returns an 'enum packet_read_status' which indicates the status of the read.
- * The number of bytes read will be assigined to *pktlen if the status of the
+ * The number of bytes read will be assigned to *pktlen if the status of the
  * read was 'PACKET_READ_NORMAL'.
  */
 enum packet_read_status {

-- 
gitgitgadget
Junio C Hamano· Dec 2, 2019, 14:16 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH 1/1] pkt-line: fix a typo

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> This typo was introduced in 2153d478b74 (pkt-line: introduce
> packet_read_with_status, 2018-03-14).
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
Good eyes.  Will queue.  Thanks.
Show 16 quoted lines
>  pkt-line.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pkt-line.h b/pkt-line.h
> index 5c62015db4..fef3a0d792 100644
> --- a/pkt-line.h
> +++ b/pkt-line.h
> @@ -77,7 +77,7 @@ int packet_read(int fd, char **src_buffer, size_t *src_len, char
>  /*
>   * Read a packetized line into a buffer like the 'packet_read()' function but
>   * returns an 'enum packet_read_status' which indicates the status of the read.
> - * The number of bytes read will be assigined to *pktlen if the status of the
> + * The number of bytes read will be assigned to *pktlen if the status of the
>   * read was 'PACKET_READ_NORMAL'.
>   */
>  enum packet_read_status {
Johannes Schindelin· Dec 2, 2019, 17:02 UTC · re: Junio C Hamano · lore

Re: [PATCH 1/1] pkt-line: fix a typo

Hi Junio,
On Mon, 2 Dec 2019, Junio C Hamano wrote:
Show 12 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > This typo was introduced in 2153d478b74 (pkt-line: introduce
> > packet_read_with_status, 2018-03-14).
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
>
> Good eyes.  Will queue.  Thanks.

Heh, as much as I would love to take credit for spotting it, it was actually cSpell in Visual Studio Code that spotted it ;-)

Ciao, Dscho

Show 18 quoted lines
>
> >  pkt-line.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/pkt-line.h b/pkt-line.h
> > index 5c62015db4..fef3a0d792 100644
> > --- a/pkt-line.h
> > +++ b/pkt-line.h
> > @@ -77,7 +77,7 @@ int packet_read(int fd, char **src_buffer, size_t *src_len, char
> >  /*
> >   * Read a packetized line into a buffer like the 'packet_read()' function but
> >   * returns an 'enum packet_read_status' which indicates the status of the read.
> > - * The number of bytes read will be assigined to *pktlen if the status of the
> > + * The number of bytes read will be assigned to *pktlen if the status of the
> >   * read was 'PACKET_READ_NORMAL'.
> >   */
> >  enum packet_read_status {
>

← back to recent threads