Git CLI

Craig H Maynard· Nov 22, 2019, 13:12 UTC · lore

Just noticed this:

$ git pull Already up to date. $ git push Everything up-to-date

The two messages covey the same information but use different punctuation and hyphenation. While not terribly important, this quirky inconsistency doesn't inspire confidence.

My environment:

git version 2.24.0 hub version 2.13.0

-- Craig H Maynard Rhode Island, USA

Denton Liu· Nov 22, 2019, 18:04 UTC · re: Craig H Maynard · lore

Re: Git CLI

Hi Craig,

Thanks for the report.

On Fri, Nov 22, 2019 at 08:12:48AM -0500, Craig H Maynard wrote:

Show 8 quoted lines

> Just noticed this:
> 
> $ git pull
> Already up to date.
> $ git push
> Everything up-to-date
> 
> The two messages covey the same information but use different punctuation and hyphenation. While not terribly important, this quirky inconsistency doesn't inspire confidence.

Unfortunately, this has been caught before but remains for legacy reasons.

According to 7560f547e6 (treewide: correct several "up-to-date" to "up to date", 2017-08-23), it explicitly mentions in the commit message, "Don't change plumbing (specifically send-pack.c, but transport.c (git push) also has the same string)."

So as a result, we can't change the `git push` string to match. I don't think it would make too much sense to change the `git pull` string to match either since that would intentionally introduce the "up-to-date" error that the above commit fixed.

Thanks,

Denton

Show 10 quoted lines

> 
> My environment:
> 
> git version 2.24.0
> hub version 2.13.0
> 
> --
> Craig H Maynard
> Rhode Island, USA
>