threads / patch / 52248

patchcoccinelle: merge three rules from qsort.cocci

Subject: [PATCH] coccinelle: merge three rules from qsort.cocci

## tl;dr

One message between Nov 12, 2019 and Nov 12, 2019. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Markus Elfring· Nov 12, 2019, 18:36 UTC · lore
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 12 Nov 2019 19:30:28 +0100

This script contained three transformation rules for the semantic patch language where a condition check should be removed before QSORT() calls. Combine these rules by using a SmPL disjunction.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 contrib/coccinelle/qsort.cocci | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
Show changes to contrib/coccinelle/qsort.cocci +1 −14
diff --git a/contrib/coccinelle/qsort.cocci b/contrib/coccinelle/qsort.cocci
index 22b93a9966..b2130a5e51 100644
--- a/contrib/coccinelle/qsort.cocci
+++ b/contrib/coccinelle/qsort.cocci
@@ -21,17 +21,5 @@ expression nmemb, compar;
 @@
 expression base, nmemb, compar;
 @@
-- if (nmemb)
-    QSORT(base, nmemb, compar);
-
-@@
-expression base, nmemb, compar;
-@@
-- if (nmemb > 0)
-    QSORT(base, nmemb, compar);
-
-@@
-expression base, nmemb, compar;
-@@
-- if (nmemb > 1)
+- if ( \( nmemb \| nmemb > \( 0 \| 1 \) \) )
     QSORT(base, nmemb, compar);
--
2.24.0

← back to recent threads