threads / patch / 52239

patchcoccinelle: merge two rules from free.cocci

Subject: [PATCH] coccinelle: merge two rules from free.cocci

## tl;dr

One message between Nov 12, 2019 and Nov 12, 2019. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Markus Elfring· Nov 12, 2019, 14:15 UTC · lore
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 12 Nov 2019 15:00:29 +0100

This script contained two transformation rules for the semantic patch language where a condition check should be removed before free() calls. It should not matter if a corresponding expression begins with a not operator (or not). Thus combine these rules by using a SmPL disjunction.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 contrib/coccinelle/free.cocci | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
Show changes to contrib/coccinelle/free.cocci +1 −8
diff --git a/contrib/coccinelle/free.cocci b/contrib/coccinelle/free.cocci
index 4490069df9..63e442d3ef 100644
--- a/contrib/coccinelle/free.cocci
+++ b/contrib/coccinelle/free.cocci
@@ -1,13 +1,7 @@
 @@
 expression E;
 @@
-- if (E)
-  free(E);
-
-@@
-expression E;
-@@
-- if (!E)
+- if ( \( E \| !E \) )
   free(E);

 @@
--
2.24.0

← back to recent threads