# [PATCH 0/3] Other doc fixes 6 messages from 2019-11-05 to 2019-11-07. Participants: Elijah Newren via GitGitGadget, Jeff King, Junio C Hamano. Thread: https://gitlist.dev/t/52197 ## Elijah Newren via GitGitGadget, 2019-11-05 23:31 Subject: [PATCH 0/3] Other doc fixes Message-ID: URL: https://gitlist.dev/e/pull.454.git.1572996692.gitgitgadget%40gmail.com ``` In addition to the pile of spelling fixes in my other pull request, here are some simple documentation fixes other than spelling errors (remove repeated word, '.' vs '->', missing hyphen). Elijah Newren (3): git-filter-branch.txt: correct argument name typo hashmap: fix documentation misuses of -> versus . name-hash.c: remove duplicate word in comment Documentation/git-filter-branch.txt | 2 +- hashmap.h | 6 +++--- name-hash.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) base-commit: da72936f544fec5a335e66432610e4cef4430991 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-454%2Fnewren%2Fother-doc-fixes-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-454/newren/other-doc-fixes-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/454 -- gitgitgadget ``` ## Elijah Newren via GitGitGadget, 2019-11-05 23:31 Subject: [PATCH 3/3] name-hash.c: remove duplicate word in comment Message-ID: URL: https://gitlist.dev/e/f7503d644c2baa9f5b8a71c998741f8232385508.1572996692.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Elijah Newren Signed-off-by: Elijah Newren --- name-hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/name-hash.c b/name-hash.c index ceb1d7bd6f..4885bae5da 100644 --- a/name-hash.c +++ b/name-hash.c @@ -218,7 +218,7 @@ static int lookup_lazy_params(struct index_state *istate) * However, the hashmap is going to put items into bucket * chains based on their hash values. Use that to create n * mutexes and lock on mutex[bucket(hash) % n]. This will - * decrease the collision rate by (hopefully) by a factor of n. + * decrease the collision rate by (hopefully) a factor of n. */ static void init_dir_mutex(void) { -- gitgitgadget ``` ## Elijah Newren via GitGitGadget, 2019-11-05 23:31 Subject: [PATCH 1/3] git-filter-branch.txt: correct argument name typo Message-ID: <5bf1b5710f7f9bc6d217e5f7c1ee0d37a6f1617f.1572996692.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/5bf1b5710f7f9bc6d217e5f7c1ee0d37a6f1617f.1572996692.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Elijah Newren Signed-off-by: Elijah Newren --- Documentation/git-filter-branch.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt index 5876598852..1ba4667b12 100644 --- a/Documentation/git-filter-branch.txt +++ b/Documentation/git-filter-branch.txt @@ -649,7 +649,7 @@ create hoards of confusing empty commits commits from before the filtering operation are also pruned instead of just pruning commits that became empty due to filtering rules. -* If --prune empty is specified, sometimes empty commits are missed +* If --prune-empty is specified, sometimes empty commits are missed and left around anyway (a somewhat rare bug, but it happens...) * A minor issue, but users who have a goal to update all names and -- gitgitgadget ``` ## Elijah Newren via GitGitGadget, 2019-11-05 23:31 Subject: [PATCH 2/3] hashmap: fix documentation misuses of -> versus . Message-ID: URL: https://gitlist.dev/e/ebf6c7a8120438466e0a679d3066ac1d1525bf76.1572996692.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Elijah Newren Signed-off-by: Elijah Newren --- hashmap.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hashmap.h b/hashmap.h index bd2701549f..6036069c23 100644 --- a/hashmap.h +++ b/hashmap.h @@ -59,7 +59,7 @@ * * if (!strcmp("print_all_by_key", action)) { * struct long2string k, *e; - * hashmap_entry_init(&k->ent, memhash(&key, sizeof(long))); + * hashmap_entry_init(&k.ent, memhash(&key, sizeof(long))); * k.key = key; * * flags &= ~COMPARE_VALUE; @@ -87,12 +87,12 @@ * * if (!strcmp("has_exact_match_no_heap_alloc", action)) { * struct long2string k; - * hashmap_entry_init(&k->ent, memhash(&key, sizeof(long))); + * hashmap_entry_init(&k.ent, memhash(&key, sizeof(long))); * k.key = key; * * flags |= COMPARE_VALUE; * printf("%sfound\n", - * hashmap_get(&map, &k->ent, value) ? "" : "not "); + * hashmap_get(&map, &k.ent, value) ? "" : "not "); * } * * if (!strcmp("end", action)) { -- gitgitgadget ``` ## Jeff King, 2019-11-06 04:06 Subject: Re: [PATCH 0/3] Other doc fixes Message-ID: <20191106040648.GC4307@sigill.intra.peff.net> URL: https://gitlist.dev/e/20191106040648.GC4307%40sigill.intra.peff.net In-Reply-To: ``` On Tue, Nov 05, 2019 at 11:31:29PM +0000, Elijah Newren via GitGitGadget wrote: > In addition to the pile of spelling fixes in my other pull request, here are > some simple documentation fixes other than spelling errors (remove repeated > word, '.' vs '->', missing hyphen). Thanks, these all look trivially correct to me. -Peff ``` ## Junio C Hamano, 2019-11-07 05:41 Subject: Re: [PATCH 3/3] name-hash.c: remove duplicate word in comment Message-ID: URL: https://gitlist.dev/e/xmqqwoccqm3l.fsf%40gitster-ct.c.googlers.com In-Reply-To: ``` "Elijah Newren via GitGitGadget" writes: > From: Elijah Newren > > Signed-off-by: Elijah Newren > --- > name-hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/name-hash.c b/name-hash.c > index ceb1d7bd6f..4885bae5da 100644 > --- a/name-hash.c > +++ b/name-hash.c > @@ -218,7 +218,7 @@ static int lookup_lazy_params(struct index_state *istate) > * However, the hashmap is going to put items into bucket > * chains based on their hash values. Use that to create n > * mutexes and lock on mutex[bucket(hash) % n]. This will > - * decrease the collision rate by (hopefully) by a factor of n. > + * decrease the collision rate by (hopefully) a factor of n. > */ > static void init_dir_mutex(void) > { Thanks. Will queue all 3. ```