# [PATCH 0/1] t1308-config-set: fix a test that has a typo 4 messages from 2019-10-10 to 2019-10-11. Participants: Johannes Schindelin via GitGitGadget, Tanay Abhra via GitGitGadget, Johannes Schindelin, Junio C Hamano. Thread: https://gitlist.dev/t/52009 ## Johannes Schindelin via GitGitGadget, 2019-10-10 12:35 Subject: [PATCH 0/1] t1308-config-set: fix a test that has a typo Message-ID: URL: https://gitlist.dev/e/pull.387.git.gitgitgadget%40gmail.com ``` I am currently trying to whittle down the number of open PRs at https://github.com/git/git, and this is one of the patches I deem valuable enough (and complete enough) to put through to the Git mailing list even when the original contributor has gone silent. Tanay Abhra (1): t1308-config-set: fix a test that has a typo t/t1308-config-set.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) base-commit: 70bf0b755af4d1e66da25b7805cac0e481a082e4 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-387%2Fdscho%2Fconfig-set-test-fix-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-387/dscho/config-set-test-fix-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/387 -- gitgitgadget ``` ## Tanay Abhra via GitGitGadget, 2019-10-10 12:35 Subject: [PATCH 1/1] t1308-config-set: fix a test that has a typo Message-ID: <7b88e36723e3e6d51118d62211f487b497c532cc.1570710932.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/7b88e36723e3e6d51118d62211f487b497c532cc.1570710932.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Tanay Abhra Change test 'find value_list for a key from a configset' to redirect the result to 'expect' instead of 'except' which was a typo. With this change, the test case actually fails because it uses `configset_get_value`. Clearly, this was intended to be `configset_get_value_multi` since the test expects a list of values instead of a single value, so let's fix that, too. Originally contributed as https://github.com/git/git/pull/451. Signed-off-by: Tanay Abhra Signed-off-by: Johannes Schindelin --- t/t1308-config-set.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh index d0a2727b85..7b4e1a63eb 100755 --- a/t/t1308-config-set.sh +++ b/t/t1308-config-set.sh @@ -166,14 +166,14 @@ test_expect_success 'find value with highest priority from a configset' ' ' test_expect_success 'find value_list for a key from a configset' ' - cat >except <<-\EOF && + cat >expect <<-\EOF && + lama + ball sam bat hask - lama - ball EOF - test-tool config configset_get_value case.baz config2 .git/config >actual && + test-tool config configset_get_value_multi case.baz config2 .git/config >actual && test_cmp expect actual ' -- gitgitgadget ``` ## Johannes Schindelin, 2019-10-10 20:48 Subject: Re: [PATCH 1/1] t1308-config-set: fix a test that has a typo Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.1910102247570.46%40tvgsbejvaqbjf.bet In-Reply-To: <7b88e36723e3e6d51118d62211f487b497c532cc.1570710932.git.gitgitgadget@gmail.com> ``` Team, On Thu, 10 Oct 2019, Tanay Abhra via GitGitGadget wrote: > diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh > index d0a2727b85..7b4e1a63eb 100755 > --- a/t/t1308-config-set.sh > +++ b/t/t1308-config-set.sh > @@ -166,14 +166,14 @@ test_expect_success 'find value with highest priority from a configset' ' > ' > > test_expect_success 'find value_list for a key from a configset' ' > - cat >except <<-\EOF && > + cat >expect <<-\EOF && I should note that I looked through all of the hits of `git grep -w except -- t/` and did not find any other typo. Thanks, Johannes > + lama > + ball > sam > bat > hask > - lama > - ball > EOF > - test-tool config configset_get_value case.baz config2 .git/config >actual && > + test-tool config configset_get_value_multi case.baz config2 .git/config >actual && > test_cmp expect actual > ' > > -- > gitgitgadget > ``` ## Junio C Hamano, 2019-10-11 05:35 Subject: Re: [PATCH 1/1] t1308-config-set: fix a test that has a typo Message-ID: URL: https://gitlist.dev/e/xmqqv9svhmix.fsf%40gitster-ct.c.googlers.com In-Reply-To: ``` Johannes Schindelin writes: > I should note that I looked through all of the hits of `git grep -w > except -- t/` and did not find any other typo. Thanks. ```