# [PATCH 0/1] Make the description of git stash save clearer 4 messages from 2019-10-10 to 2019-10-11. Participants: Johannes Schindelin via GitGitGadget, Thomas Gummerer, Junio C Hamano. Thread: https://gitlist.dev/t/52004 ## Johannes Schindelin via GitGitGadget, 2019-10-10 10:06 Subject: [PATCH 0/1] Make the description of git stash save clearer Message-ID: URL: https://gitlist.dev/e/pull.384.git.gitgitgadget%40gmail.com ``` This is an attempt to revive the discussion started in https://public-inbox.org/git/0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com/#t Johannes Schindelin (1): doc(stash): clarify the description of `save` Documentation/git-stash.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) base-commit: 70bf0b755af4d1e66da25b7805cac0e481a082e4 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-384%2Fdscho%2Fclarify-stash-doc-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-384/dscho/clarify-stash-doc-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/384 -- gitgitgadget ``` ## Johannes Schindelin via GitGitGadget, 2019-10-10 10:06 Subject: [PATCH 1/1] doc(stash): clarify the description of `save` Message-ID: <572c7d0c51ffc68dc4603752d05fa7a418dbdd71.1570702000.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/572c7d0c51ffc68dc4603752d05fa7a418dbdd71.1570702000.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Johannes Schindelin The original phrasing of this paragraph made at least one person stumble over the word "from" (thinking that it was a typo and "from" was intended), and other readers chimed in, agreeing that it was confusing: https://public-inbox.org/git/0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com/#t Let's rewrite that paragraph for clarity. Inspired-by-a-patch-by: Catalin Criste Signed-off-by: Johannes Schindelin --- Documentation/git-stash.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt index 8fbe12c66c..53e1a1205d 100644 --- a/Documentation/git-stash.txt +++ b/Documentation/git-stash.txt @@ -87,8 +87,9 @@ The `--patch` option implies `--keep-index`. You can use save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q|--quiet] []:: This option is deprecated in favour of 'git stash push'. It - differs from "stash push" in that it cannot take pathspecs, - and any non-option arguments form the message. + differs from "stash push" in that it cannot take pathspecs. + Instead, all non-option arguments are concatenated to form the stash + message. list []:: -- gitgitgadget ``` ## Thomas Gummerer, 2019-10-10 10:28 Subject: Re: [PATCH 1/1] doc(stash): clarify the description of `save` Message-ID: <20191010102828.GA12497@cat> URL: https://gitlist.dev/e/20191010102828.GA12497%40cat In-Reply-To: <572c7d0c51ffc68dc4603752d05fa7a418dbdd71.1570702000.git.gitgitgadget@gmail.com> ``` On 10/10, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > The original phrasing of this paragraph made at least one person stumble > over the word "from" (thinking that it was a typo and "from" was > intended), and other readers chimed in, agreeing that it was confusing: > https://public-inbox.org/git/0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com/#t > > Let's rewrite that paragraph for clarity. > > Inspired-by-a-patch-by: Catalin Criste > Signed-off-by: Johannes Schindelin Thanks for picking this thread up again, I had already forgotten about it. The updated wording sounds like an improvement to me. > --- > Documentation/git-stash.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt > index 8fbe12c66c..53e1a1205d 100644 > --- a/Documentation/git-stash.txt > +++ b/Documentation/git-stash.txt > @@ -87,8 +87,9 @@ The `--patch` option implies `--keep-index`. You can use > save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q|--quiet] []:: > > This option is deprecated in favour of 'git stash push'. It > - differs from "stash push" in that it cannot take pathspecs, > - and any non-option arguments form the message. > + differs from "stash push" in that it cannot take pathspecs. > + Instead, all non-option arguments are concatenated to form the stash > + message. > > list []:: > > -- > gitgitgadget ``` ## Junio C Hamano, 2019-10-11 05:29 Subject: Re: [PATCH 1/1] doc(stash): clarify the description of `save` Message-ID: URL: https://gitlist.dev/e/xmqq36fzj1d4.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20191010102828.GA12497@cat> ``` Thomas Gummerer writes: > On 10/10, Johannes Schindelin via GitGitGadget wrote: >> From: Johannes Schindelin >> >> The original phrasing of this paragraph made at least one person stumble >> over the word "from" (thinking that it was a typo and "from" was >> intended), and other readers chimed in, agreeing that it was confusing: >> https://public-inbox.org/git/0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com/#t >> >> Let's rewrite that paragraph for clarity. >> >> Inspired-by-a-patch-by: Catalin Criste >> Signed-off-by: Johannes Schindelin > > Thanks for picking this thread up again, I had already forgotten about > it. The updated wording sounds like an improvement to me. To me too. I would have just done s/form/become/ out of laziness and aiming for conciseness, but the new and separate sentence is good, too. Thanks, both. > >> --- >> Documentation/git-stash.txt | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt >> index 8fbe12c66c..53e1a1205d 100644 >> --- a/Documentation/git-stash.txt >> +++ b/Documentation/git-stash.txt >> @@ -87,8 +87,9 @@ The `--patch` option implies `--keep-index`. You can use >> save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q|--quiet] []:: >> >> This option is deprecated in favour of 'git stash push'. It >> - differs from "stash push" in that it cannot take pathspecs, >> - and any non-option arguments form the message. >> + differs from "stash push" in that it cannot take pathspecs. >> + Instead, all non-option arguments are concatenated to form the stash >> + message. >> >> list []:: >> >> -- >> gitgitgadget ```