# [PATCH] gitk: rename zh_CN.po to zh_cn.po 3 messages from 2019-09-17 to 2019-09-17. Participants: Denton Liu, Junio C Hamano. Thread: https://gitlist.dev/t/51863 ## Denton Liu, 2019-09-17 08:52 Subject: [PATCH] gitk: rename zh_CN.po to zh_cn.po Message-ID: <6feff2e73e1c4ca838efcabe90e0978a4d88cb7d.1568710294.git.liu.denton@gmail.com> URL: https://gitlist.dev/e/6feff2e73e1c4ca838efcabe90e0978a4d88cb7d.1568710294.git.liu.denton%40gmail.com ``` When running make from a clean environment, all of the *.po files should be converted into *.msg files. After that, when make is run without any changes, make should not do anything. After beffae768a (gitk: Add Chinese (zh_CN) translation, 2017-03-11), zh_CN.po was introduced. When make was run, a zh_cn.msg file was generated (notice the lowercase). However, since make is case-sensitive, it expects zh_CN.po to generate a zh_CN.msg file so make will keep reattempting to generate a zh_CN.msg so successive make invocations result in Generating catalog po/zh_cn.msg msgfmt --statistics --tcl po/zh_cn.po -l zh_cn -d po/ 317 translated messages. happening continuously. Rename zh_CN.po to zh_cn.po so that when make generates the zh_cn.msg file, it will realize that it was successfully generated and only run once. Signed-off-by: Denton Liu --- po/{zh_CN.po => zh_cn.po} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename po/{zh_CN.po => zh_cn.po} (100%) diff --git a/po/zh_CN.po b/po/zh_cn.po similarity index 100% rename from po/zh_CN.po rename to po/zh_cn.po -- 2.23.0.248.g3a9dd8fb08 ``` ## Junio C Hamano, 2019-09-17 16:48 Subject: Re: [PATCH] gitk: rename zh_CN.po to zh_cn.po Message-ID: URL: https://gitlist.dev/e/xmqq36guamym.fsf%40gitster-ct.c.googlers.com In-Reply-To: <6feff2e73e1c4ca838efcabe90e0978a4d88cb7d.1568710294.git.liu.denton@gmail.com> ``` Denton Liu writes: > When running make from a clean environment, all of the *.po files should > be converted into *.msg files. After that, when make is run without any > changes, make should not do anything. > > After beffae768a (gitk: Add Chinese (zh_CN) translation, 2017-03-11), > zh_CN.po was introduced. When make was run, a zh_cn.msg file was > generated (notice the lowercase). However, since make is case-sensitive, > it expects zh_CN.po to generate a zh_CN.msg file so make will keep > reattempting to generate a zh_CN.msg so successive make invocations > result in > > Generating catalog po/zh_cn.msg > msgfmt --statistics --tcl po/zh_cn.po -l zh_cn -d po/ > 317 translated messages. > > happening continuously. > > Rename zh_CN.po to zh_cn.po so that when make generates the zh_cn.msg > file, it will realize that it was successfully generated and only run > once. True, and it is not just that. The install target would fail because it cannot find zh_CN.msg, I think. > Signed-off-by: Denton Liu > --- > po/{zh_CN.po => zh_cn.po} | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename po/{zh_CN.po => zh_cn.po} (100%) > > diff --git a/po/zh_CN.po b/po/zh_cn.po > similarity index 100% > rename from po/zh_CN.po > rename to po/zh_cn.po This would make this in line with pt_{pt,br}.po, existing locales with country code in them. Reviewed-by: Junio C Hamano ``` ## Junio C Hamano, 2019-09-17 22:14 Subject: Re: [PATCH] gitk: rename zh_CN.po to zh_cn.po Message-ID: URL: https://gitlist.dev/e/xmqqlfum7epn.fsf%40gitster-ct.c.googlers.com In-Reply-To: ``` Junio C Hamano writes: > This would make this in line with pt_{pt,br}.po, existing locales > with country code in them. > > Reviewed-by: Junio C Hamano Paul, I've applied this to a clone of gitk locally and merged it (resutling in 2a4ac71ffb that should be reachable from 'master'), as it was breaking my "install" tests. Thanks. ```