threads / patch / 5185

patchmerge-recur: if there is no common ancestor, fake empty one

Subject: [PATCH] merge-recur: if there is no common ancestor, fake empty one

## tl;dr

3 messages between Aug 9, 2006 and Aug 9, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Johannes Schindelin· Aug 9, 2006, 16:43 UTC · lore
This fixes the coolest merge ever.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	This was a forgotten part from the python version.
 merge-recursive.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
Show changes to merge-recursive.c +12 −0
diff --git a/merge-recursive.c b/merge-recursive.c
index 7a93dd9..f5b547b 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -1223,6 +1223,18 @@ int merge(struct commit *h1,
 		output_commit_title(iter->item);
 
 	merged_common_ancestors = pop_commit(&ca);
+	if (merged_common_ancestors == NULL) {
+		/* if there is no common ancestor, make an empty tree */
+		struct tree *tree = xcalloc(1, sizeof(struct tree));
+		char buffer[40];
+		int hdrlen;
+
+		tree->object.parsed = 1;
+		tree->object.type = OBJ_TREE;
+		*write_sha1_file_prepare(NULL, 0, tree_type, &tree->object.sha1,
+				buffer, &hdrlen);
+		merged_common_ancestors = make_virtual_commit(tree, "ancestor");
+	}
 
 	for (iter = ca; iter; iter = iter->next) {
 		output_indent = call_depth + 1;
-- 
1.4.2.rc3.g29d0-dirty
Johannes Schindelin· Aug 9, 2006, 17:44 UTC · re: Johannes Schindelin · lore

Re: [PATCH] merge-recur: if there is no common ancestor, fake empty one

Hi,
On Wed, 9 Aug 2006, Johannes Schindelin wrote:
> +		*write_sha1_file_prepare(NULL, 0, tree_type, &tree->object.sha1,
... make this "tree->object.sha1" _without_ a "&", of course.

Ciao, Dscho

Alex Riesen· Aug 9, 2006, 19:55 UTC · re: Johannes Schindelin · lore

Re: [PATCH] merge-recur: if there is no common ancestor, fake empty one

Johannes Schindelin, Wed, Aug 09, 2006 19:44:38 +0200:
Show 5 quoted lines
> 
> > +		*write_sha1_file_prepare(NULL, 0, tree_type, &tree->object.sha1,
> 
> ... make this "tree->object.sha1" _without_ a "&", of course.
> 
And without the asterisk before write_sha1_file_prepare

← back to recent threads