# [PATCH 0/1] Fix perl error "unescaped left brace in regex" for paranoid update hook 6 messages from 2019-09-10 to 2019-09-12. Participants: Dominic Winkler via GitGitGadget, Johannes Schindelin. Thread: https://gitlist.dev/t/51822 ## Dominic Winkler via GitGitGadget, 2019-09-10 06:39 Subject: [PATCH 0/1] Fix perl error "unescaped left brace in regex" for paranoid update hook Message-ID: URL: https://gitlist.dev/e/pull.335.git.gitgitgadget%40gmail.com ``` A literal "{" should now be escaped in a pattern starting from perl versions >= v5.26. In perl v5.22, using a literal { in a regular expression was deprecated, and will emit a warning if it isn't escaped: {. In v5.26, this won't just warn, it'll cause a syntax error. (see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod) Signed-off-by: Dominic Winkler d.winkler@flexarts.at [d.winkler@flexarts.at] Dominic Winkler (1): Fix perl error "unescaped left brace in regex" for paranoid update hook contrib/hooks/update-paranoid | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-335%2Fflexarts%2Fmaint-update-paranoid-perlv5.26-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-335/flexarts/maint-update-paranoid-perlv5.26-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/335 -- gitgitgadget ``` ## Dominic Winkler via GitGitGadget, 2019-09-10 06:39 Subject: [PATCH 1/1] Fix perl error "unescaped left brace in regex" for paranoid update hook Message-ID: <2743caa22e60c5ddc04d388f21a04500d7bcac1f.1568097573.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/2743caa22e60c5ddc04d388f21a04500d7bcac1f.1568097573.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Dominic Winkler A literal "{" should now be escaped in a pattern starting from perl versions >= v5.26. In perl v5.22, using a literal { in a regular expression was deprecated, and will emit a warning if it isn't escaped: \{. In v5.26, this won't just warn, it'll cause a syntax error. (see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod) Signed-off-by: Dominic Winkler --- contrib/hooks/update-paranoid | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/hooks/update-paranoid b/contrib/hooks/update-paranoid index d18b317b2f..fc0a242a4e 100755 --- a/contrib/hooks/update-paranoid +++ b/contrib/hooks/update-paranoid @@ -302,13 +302,13 @@ $op = 'U' if ($op eq 'R' RULE: foreach (@$rules) { - while (/\${user\.([a-z][a-zA-Z0-9]+)}/) { + while (/\$\{user\.([a-z][a-zA-Z0-9]+)}/) { my $k = lc $1; my $v = $data{"user.$k"}; next RULE unless defined $v; next RULE if @$v != 1; next RULE unless defined $v->[0]; - s/\${user\.$k}/$v->[0]/g; + s/\$\{user\.$k}/$v->[0]/g; } if (/^([AMD ]+)\s+of\s+([^\s]+)\s+for\s+([^\s]+)\s+diff\s+([^\s]+)$/) { -- gitgitgadget ``` ## Johannes Schindelin, 2019-09-11 21:28 Subject: Re: [PATCH 1/1] Fix perl error "unescaped left brace in regex" for paranoid update hook Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.1909112326490.5377%40tvgsbejvaqbjf.bet In-Reply-To: <2743caa22e60c5ddc04d388f21a04500d7bcac1f.1568097573.git.gitgitgadget@gmail.com> ``` Hi Dominic, all looks good, with one exception: the Subject should start with `:`, i.e. in this instance something like this would be better: contrib/hooks: escape left brace in regex in the paranoid update hook Ciao, Johannes On Mon, 9 Sep 2019, Dominic Winkler via GitGitGadget wrote: > From: Dominic Winkler > > A literal "{" should now be escaped in a pattern starting from perl > versions >= v5.26. In perl v5.22, using a literal { in a regular > expression was deprecated, and will emit a warning if it isn't escaped: \{. > In v5.26, this won't just warn, it'll cause a syntax error. > > (see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod) > > Signed-off-by: Dominic Winkler > --- > contrib/hooks/update-paranoid | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/contrib/hooks/update-paranoid b/contrib/hooks/update-paranoid > index d18b317b2f..fc0a242a4e 100755 > --- a/contrib/hooks/update-paranoid > +++ b/contrib/hooks/update-paranoid > @@ -302,13 +302,13 @@ $op = 'U' if ($op eq 'R' > > RULE: > foreach (@$rules) { > - while (/\${user\.([a-z][a-zA-Z0-9]+)}/) { > + while (/\$\{user\.([a-z][a-zA-Z0-9]+)}/) { > my $k = lc $1; > my $v = $data{"user.$k"}; > next RULE unless defined $v; > next RULE if @$v != 1; > next RULE unless defined $v->[0]; > - s/\${user\.$k}/$v->[0]/g; > + s/\$\{user\.$k}/$v->[0]/g; > } > > if (/^([AMD ]+)\s+of\s+([^\s]+)\s+for\s+([^\s]+)\s+diff\s+([^\s]+)$/) { > -- > gitgitgadget > ``` ## Dominic Winkler via GitGitGadget, 2019-09-11 21:47 Subject: [PATCH v2 0/1] Fix perl error "unescaped left brace in regex" for paranoid update hook Message-ID: URL: https://gitlist.dev/e/pull.335.v2.git.gitgitgadget%40gmail.com In-Reply-To: ``` A literal "{" should now be escaped in a pattern starting from perl versions >= v5.26. In perl v5.22, using a literal { in a regular expression was deprecated, and will emit a warning if it isn't escaped: {. In v5.26, this won't just warn, it'll cause a syntax error. (see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod) Signed-off-by: Dominic Winkler d.winkler@flexarts.at [d.winkler@flexarts.at] Dominic Winkler (1): contrib/hooks: escape left brace in regex in the paranoid update hook contrib/hooks/update-paranoid | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-335%2Fflexarts%2Fmaint-update-paranoid-perlv5.26-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-335/flexarts/maint-update-paranoid-perlv5.26-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/335 Range-diff vs v1: 1: 2743caa22e ! 1: 0d762cfb50 Fix perl error "unescaped left brace in regex" for paranoid update hook @@ -1,6 +1,6 @@ Author: Dominic Winkler - Fix perl error "unescaped left brace in regex" for paranoid update hook + contrib/hooks: escape left brace in regex in the paranoid update hook A literal "{" should now be escaped in a pattern starting from perl versions >= v5.26. In perl v5.22, using a literal { in a regular -- gitgitgadget ``` ## Dominic Winkler via GitGitGadget, 2019-09-11 21:47 Subject: [PATCH v2 1/1] contrib/hooks: escape left brace in regex in the paranoid update hook Message-ID: <0d762cfb503fef081af9aa3cb0fe373863237745.1568238440.git.gitgitgadget@gmail.com> URL: https://gitlist.dev/e/0d762cfb503fef081af9aa3cb0fe373863237745.1568238440.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Dominic Winkler A literal "{" should now be escaped in a pattern starting from perl versions >= v5.26. In perl v5.22, using a literal { in a regular expression was deprecated, and will emit a warning if it isn't escaped: \{. In v5.26, this won't just warn, it'll cause a syntax error. (see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod) Signed-off-by: Dominic Winkler --- contrib/hooks/update-paranoid | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/hooks/update-paranoid b/contrib/hooks/update-paranoid index d18b317b2f..fc0a242a4e 100755 --- a/contrib/hooks/update-paranoid +++ b/contrib/hooks/update-paranoid @@ -302,13 +302,13 @@ $op = 'U' if ($op eq 'R' RULE: foreach (@$rules) { - while (/\${user\.([a-z][a-zA-Z0-9]+)}/) { + while (/\$\{user\.([a-z][a-zA-Z0-9]+)}/) { my $k = lc $1; my $v = $data{"user.$k"}; next RULE unless defined $v; next RULE if @$v != 1; next RULE unless defined $v->[0]; - s/\${user\.$k}/$v->[0]/g; + s/\$\{user\.$k}/$v->[0]/g; } if (/^([AMD ]+)\s+of\s+([^\s]+)\s+for\s+([^\s]+)\s+diff\s+([^\s]+)$/) { -- gitgitgadget ``` ## Johannes Schindelin, 2019-09-12 08:56 Subject: Re: [PATCH v2 1/1] contrib/hooks: escape left brace in regex in the paranoid update hook Message-ID: URL: https://gitlist.dev/e/nycvar.QRO.7.76.6.1909121055580.47%40tvgsbejvaqbjf.bet In-Reply-To: <0d762cfb503fef081af9aa3cb0fe373863237745.1568238440.git.gitgitgadget@gmail.com> ``` Hi Dominic, On Wed, 11 Sep 2019, Dominic Winkler via GitGitGadget wrote: > From: Dominic Winkler > > A literal "{" should now be escaped in a pattern starting from perl > versions >= v5.26. In perl v5.22, using a literal { in a regular > expression was deprecated, and will emit a warning if it isn't escaped: \{. > In v5.26, this won't just warn, it'll cause a syntax error. > > (see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod) > > Signed-off-by: Dominic Winkler Thank you for addressing my concern so promptly. I am far from a Perl expert, so take this with a train of salt: the patch now looks good to me! Ciao, Johannes > --- > contrib/hooks/update-paranoid | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/contrib/hooks/update-paranoid b/contrib/hooks/update-paranoid > index d18b317b2f..fc0a242a4e 100755 > --- a/contrib/hooks/update-paranoid > +++ b/contrib/hooks/update-paranoid > @@ -302,13 +302,13 @@ $op = 'U' if ($op eq 'R' > > RULE: > foreach (@$rules) { > - while (/\${user\.([a-z][a-zA-Z0-9]+)}/) { > + while (/\$\{user\.([a-z][a-zA-Z0-9]+)}/) { > my $k = lc $1; > my $v = $data{"user.$k"}; > next RULE unless defined $v; > next RULE if @$v != 1; > next RULE unless defined $v->[0]; > - s/\${user\.$k}/$v->[0]/g; > + s/\$\{user\.$k}/$v->[0]/g; > } > > if (/^([AMD ]+)\s+of\s+([^\s]+)\s+for\s+([^\s]+)\s+diff\s+([^\s]+)$/) { > -- > gitgitgadget > ```