# [PATCH 1/1] hdr-check: make it work on Windows 3 messages from 2019-08-24 to 2019-08-26. Participants: Johannes Schindelin via GitGitGadget, Junio C Hamano. Thread: https://gitlist.dev/t/51723 ## Johannes Schindelin via GitGitGadget, 2019-08-24 22:36 Subject: [PATCH 1/1] hdr-check: make it work on Windows Message-ID: URL: https://gitlist.dev/e/c13d9985284d4b452db0d95b6949e02c533db634.1566686214.git.gitgitgadget%40gmail.com In-Reply-To: ``` From: Johannes Schindelin On Windows, we define a specific set of pre-processor macros, among other reasons: to avoid including syslog.h (which is not available on Windows). The hdr-check target did not use those definitions, resulting in a failure to include said syslog.h. To fix that, let's let the hdr-check target make use of ALL_CFLAGS, which does include the pre-processor macros that would e.g. skip the conditional block including syslog.h. Signed-off-by: Johannes Schindelin --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c5240942f2..b9f00f0ea0 100644 --- a/Makefile +++ b/Makefile @@ -2741,7 +2741,7 @@ CHK_HDRS = $(filter-out $(EXCEPT_HDRS),$(patsubst ./%,%,$(LIB_H))) HCO = $(patsubst %.h,%.hco,$(CHK_HDRS)) $(HCO): %.hco: %.h FORCE - $(QUIET_HDR)$(CC) -include git-compat-util.h -I. -o /dev/null -c -xc $< + $(QUIET_HDR)$(CC) $(ALL_CFLAGS) -include git-compat-util.h -I. -o /dev/null -c -xc $< .PHONY: hdr-check $(HCO) hdr-check: $(HCO) -- gitgitgadget ``` ## Johannes Schindelin via GitGitGadget, 2019-08-24 22:36 Subject: [PATCH 0/1] Do use ALL_CFLAGS in hdr-check Message-ID: URL: https://gitlist.dev/e/pull.129.git.gitgitgadget%40gmail.com ``` When I was playing with the Makefile target hdr-check, it looked as if it missed the correct CFLAGS. Without them, on Windows an attempt is made to include syslog.h, which does not make sense at all. This patch addresses that. Johannes Schindelin (1): hdr-check: make it work on Windows Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: c65a2884eae159bad540135479bc8afe20ff62d1 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-129%2Fdscho%2Ffix-hdr-check-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-129/dscho/fix-hdr-check-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/129 -- gitgitgadget ``` ## Junio C Hamano, 2019-08-26 17:04 Subject: Re: [PATCH 0/1] Do use ALL_CFLAGS in hdr-check Message-ID: URL: https://gitlist.dev/e/xmqqblwbj1sa.fsf%40gitster-ct.c.googlers.com In-Reply-To: ``` "Johannes Schindelin via GitGitGadget" writes: > When I was playing with the Makefile target hdr-check, it looked as if it > missed the correct CFLAGS. Without them, on Windows an attempt is made to > include syslog.h, which does not make sense at all. Makes sense. Thanks. ```