# [PATCH 1/1] commit: add signoff config variable 3 messages from 2019-08-03 to 2019-08-03. Participants: Liam Beguin, brian m. carlson. Thread: https://gitlist.dev/t/51582 ## Liam Beguin, 2019-08-03 19:34 Subject: [PATCH 1/1] commit: add signoff config variable Message-ID: <20190803193436.13158-1-liambeguin@gmail.com> URL: https://gitlist.dev/e/20190803193436.13158-1-liambeguin%40gmail.com ``` Add a configuration variable, based on format.signoff, to automatically signoff commit messages. Signed-off-by: Liam Beguin --- Documentation/config/commit.txt | 7 +++++++ builtin/commit.c | 4 ++++ 2 files changed, 11 insertions(+) diff --git a/Documentation/config/commit.txt b/Documentation/config/commit.txt index 2c95573930be..62aaacb0dc74 100644 --- a/Documentation/config/commit.txt +++ b/Documentation/config/commit.txt @@ -27,3 +27,10 @@ commit.template:: commit.verbose:: A boolean or int to specify the level of verbose with `git commit`. See linkgit:git-commit[1]. + +commit.signOff:: + A boolean value which lets you enable the `-s/--signoff` option of + `git commit` by default. *Note:* Adding the Signed-off-by: line to a + patch should be a conscious act and means that you certify you have + the rights to submit this work under the same open source license. + Please see the 'SubmittingPatches' document for further discussion. diff --git a/builtin/commit.c b/builtin/commit.c index ae7aaf6dc683..36d70396ace7 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -1456,6 +1456,10 @@ static int git_commit_config(const char *k, const char *v, void *cb) config_commit_verbose = git_config_bool_or_int(k, v, &is_bool); return 0; } + if (!strcmp(k, "commit.signoff")) { + signoff = git_config_bool(k, v); + return 0; + } status = git_gpg_config(k, v, NULL); if (status) -- 2.21.0.777.g83232e38648b ``` ## brian m. carlson, 2019-08-03 21:11 Subject: Re: [PATCH 1/1] commit: add signoff config variable Message-ID: <20190803211152.GA118825@genre.crustytoothpaste.net> URL: https://gitlist.dev/e/20190803211152.GA118825%40genre.crustytoothpaste.net In-Reply-To: <20190803193436.13158-1-liambeguin@gmail.com> ``` On 2019-08-03 at 19:34:36, Liam Beguin wrote: > Add a configuration variable, based on format.signoff, to automatically > signoff commit messages. > > Signed-off-by: Liam Beguin This has been proposed several times. It may be interesting to look through the history of the list and examine why it hasn't been accepted as a feature. A few attempts are chronicled here: https://public-inbox.org/git/?q=commit.signoff This is, however, achievable with a commit-msg hook or using "git interpret-trailers" if you are certain this is what you want to do. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204 ``` ## Liam Beguin, 2019-08-03 21:23 Subject: Re: [PATCH 1/1] commit: add signoff config variable Message-ID: URL: https://gitlist.dev/e/CAKm4OoWj6_D_aaq4mrAKHP3mieARjAAVmg2ea9axU2DE7My5VQ%40mail.gmail.com In-Reply-To: <20190803211152.GA118825@genre.crustytoothpaste.net> ``` Hi, Sorry for sending this without checking the archives before... I understand why this would not be such a good idea given the legal meaning attached to it. Thanks, Liam On Sat, Aug 3, 2019 at 5:12 PM brian m. carlson wrote: > > On 2019-08-03 at 19:34:36, Liam Beguin wrote: > > Add a configuration variable, based on format.signoff, to automatically > > signoff commit messages. > > > > Signed-off-by: Liam Beguin > > This has been proposed several times. It may be interesting to look > through the history of the list and examine why it hasn't been accepted > as a feature. A few attempts are chronicled here: > https://public-inbox.org/git/?q=commit.signoff > > This is, however, achievable with a commit-msg hook or using "git > interpret-trailers" if you are certain this is what you want to do. > -- > brian m. carlson: Houston, Texas, US > OpenPGP: https://keybase.io/bk2204 ```