threads / patch / 5154

patchgitweb: check if HTTP_ACCEPT is really set

Subject: [PATCH] gitweb: check if HTTP_ACCEPT is really set

## tl;dr

One message between Aug 6, 2006 and Aug 6, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Matthias Lederhofer· Aug 6, 2006, 13:55 UTC · lore
Signed-off-by: Matthias Lederhofer <matled@gmx.net>
---
If the client does not send Accept: HTTP_ACCEPT is undefined and there
is a warning:
Use of uninitialized value in pattern match (m//) at line 862.
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to gitweb/gitweb.perl +1 −1
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index f85dc7d..1f4b0f5 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -859,7 +859,7 @@ sub git_header_html {
 	# 'application/xhtml+xml', otherwise send it as plain old 'text/html'.
 	# we have to do this because MSIE sometimes globs '*/*', pretending to
 	# support xhtml+xml but choking when it gets what it asked for.
-	if ($cgi->http('HTTP_ACCEPT') =~ m/(,|;|\s|^)application\/xhtml\+xml(,|;|\s|$)/ && $cgi->Accept('application/xhtml+xml') != 0) {
+	if (defined $cgi->http('HTTP_ACCEPT') && $cgi->http('HTTP_ACCEPT') =~ m/(,|;|\s|^)application\/xhtml\+xml(,|;|\s|$)/ && $cgi->Accept('application/xhtml+xml') != 0) {
 		$content_type = 'application/xhtml+xml';
 	} else {
 		$content_type = 'text/html';
-- 
1.4.2.rc3.g2f52

← back to recent threads