threads / patch / 51232

patchclang-format: use git grep to generate the ForEachMacros list

Subject: [PATCH] clang-format: use git grep to generate the ForEachMacros list

## tl;dr

4 messages between Jun 3, 2019 and Jun 6, 2019. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Miguel Ojeda· Jun 3, 2019, 22:48 UTC · lore

The ForEachMacros list can reasonably be generated grepping the C source code for macros with 'for_each' in their name.

Taken almost verbatim from the .clang-format file in the Linux kernel.
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
---
We wrote this for the Linux kernel a while ago, and it has been working
fine there, so I thought it would be nice to use the same approach here.
There are fancier ways of approaching this, of course.
 .clang-format | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)
Show changes to .clang-format +15 −2
diff --git a/.clang-format b/.clang-format
index 41d4cd23fd..c592dda681 100644
--- a/.clang-format
+++ b/.clang-format
@@ -148,8 +148,21 @@ SpacesInSquareBrackets: false
 Cpp11BracedListStyle: false
 
 # A list of macros that should be interpreted as foreach loops instead of as
-# function calls.
-ForEachMacros: ['for_each_string_list_item', 'for_each_wanted_builtin', 'for_each_builtin', 'for_each_ut']
+# function calls. Taken from:
+#   git grep -h '^#define [^[:space:]]*for_each[^[:space:]]*(' \
+#   | sed "s,^#define \([^[:space:]]*for_each[^[:space:]]*\)(.*$,  - '\1'," \
+#   | sort | uniq
+ForEachMacros:
+  - 'for_each_abbrev'
+  - 'for_each_builtin'
+  - 'for_each_string_list_item'
+  - 'for_each_ut'
+  - 'for_each_wanted_builtin'
+  - 'list_for_each'
+  - 'list_for_each_dir'
+  - 'list_for_each_prev'
+  - 'list_for_each_prev_safe'
+  - 'list_for_each_safe'
 
 # The maximum number of consecutive empty lines to keep.
 MaxEmptyLinesToKeep: 1

-- 
2.17.1
Johannes Schindelin· Jun 4, 2019, 16:07 UTC · re: Miguel Ojeda · lore

Re: [PATCH] clang-format: use git grep to generate the ForEachMacros list

Hi Miguel,
On Tue, 4 Jun 2019, Miguel Ojeda wrote:
Show 9 quoted lines
> The ForEachMacros list can reasonably be generated grepping
> the C source code for macros with 'for_each' in their name.
>
> Taken almost verbatim from the .clang-format file in the Linux kernel.
>
> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> ---
> We wrote this for the Linux kernel a while ago, and it has been working
> fine there, so I thought it would be nice to use the same approach here.
Makes sense to me!

Thanks, Johannes

Show 35 quoted lines
>  .clang-format | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/.clang-format b/.clang-format
> index 41d4cd23fd..c592dda681 100644
> --- a/.clang-format
> +++ b/.clang-format
> @@ -148,8 +148,21 @@ SpacesInSquareBrackets: false
>  Cpp11BracedListStyle: false
>
>  # A list of macros that should be interpreted as foreach loops instead of as
> -# function calls.
> -ForEachMacros: ['for_each_string_list_item', 'for_each_wanted_builtin', 'for_each_builtin', 'for_each_ut']
> +# function calls. Taken from:
> +#   git grep -h '^#define [^[:space:]]*for_each[^[:space:]]*(' \
> +#   | sed "s,^#define \([^[:space:]]*for_each[^[:space:]]*\)(.*$,  - '\1'," \
> +#   | sort | uniq
> +ForEachMacros:
> +  - 'for_each_abbrev'
> +  - 'for_each_builtin'
> +  - 'for_each_string_list_item'
> +  - 'for_each_ut'
> +  - 'for_each_wanted_builtin'
> +  - 'list_for_each'
> +  - 'list_for_each_dir'
> +  - 'list_for_each_prev'
> +  - 'list_for_each_prev_safe'
> +  - 'list_for_each_safe'
>
>  # The maximum number of consecutive empty lines to keep.
>  MaxEmptyLinesToKeep: 1
> --
> 2.17.1
>
>
Taylor Blau· Jun 5, 2019, 20:20 UTC · re: Miguel Ojeda · lore

Re: [PATCH] clang-format: use git grep to generate the ForEachMacros list

Hi Miguel,
On Tue, Jun 04, 2019 at 12:48:14AM +0200, Miguel Ojeda wrote:
Show 6 quoted lines
> The ForEachMacros list can reasonably be generated grepping
> the C source code for macros with 'for_each' in their name.
>
> Taken almost verbatim from the .clang-format file in the Linux kernel.
>
> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>

Thanks for CC-ing me on this. I suspect that it was because I show up somewhere recently in the blame for 'git grep' (I believe I worked on adding `-o` about a year ago).

You 'git grep' usage of course looks correct, so this patch looks good to me, too.

Thanks, Taylor

Miguel Ojeda· Jun 6, 2019, 18:29 UTC · re: Taylor Blau · lore

Re: [PATCH] clang-format: use git grep to generate the ForEachMacros list

On Wed, Jun 5, 2019 at 10:20 PM Taylor Blau <me@ttaylorr.com> wrote:
Show 14 quoted lines
>
> Hi Miguel,
>
> On Tue, Jun 04, 2019 at 12:48:14AM +0200, Miguel Ojeda wrote:
> > The ForEachMacros list can reasonably be generated grepping
> > the C source code for macros with 'for_each' in their name.
> >
> > Taken almost verbatim from the .clang-format file in the Linux kernel.
> >
> > Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
>
> Thanks for CC-ing me on this. I suspect that it was because I show up
> somewhere recently in the blame for 'git grep' (I believe I worked on
> adding `-o` about a year ago).

Yeah, I just picked a few names that were related to the file form the log, since I was unable to locate a MAINTAINERS file or something like that. :-)

Thanks for taking a look -- also to Johannes!

Cheers, Miguel

← back to recent threads