# [PATCH] Makefile: use fileno macro work around on AIX 2 messages from 2019-04-18 to 2019-04-19. Participants: CHIGOT, CLEMENT, Junio C Hamano. Thread: https://gitlist.dev/t/50951 ## CHIGOT, CLEMENT, 2019-04-18 08:55 Subject: [PATCH] Makefile: use fileno macro work around on AIX Message-ID: URL: https://gitlist.dev/e/AM6PR02MB4950A1A625EEA54D4423C1BCEA260%40AM6PR02MB4950.eurprd02.prod.outlook.com ``` Declare FILENO_IS_A_MACRO on AIX On AIX, fileno(fp) is a macro and need to use the work around already made for BSD's. Signed-off-by: Clément Chigot --- config.mak.uname | 1 + 1 file changed, 1 insertion(+) diff --git a/config.mak.uname b/config.mak.uname index 41e85fab1c..86cbe47627 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -269,6 +269,7 @@ ifeq ($(uname_S),AIX) INTERNAL_QSORT = UnfortunatelyYes NEEDS_LIBICONV = YesPlease BASIC_CFLAGS += -D_LARGE_FILES + FILENO_IS_A_MACRO = UnfortunatelyYes ifeq ($(shell expr "$(uname_V)" : '[1234]'),1) NO_PTHREADS = YesPlease else -- 2.17.1 ``` ## Junio C Hamano, 2019-04-19 05:01 Subject: Re: [PATCH] Makefile: use fileno macro work around on AIX Message-ID: URL: https://gitlist.dev/e/xmqqimvaegh5.fsf%40gitster-ct.c.googlers.com In-Reply-To: ``` "CHIGOT, CLEMENT" writes: > Declare FILENO_IS_A_MACRO on AIX > > On AIX, fileno(fp) is a macro and need to use the work around already made for BSD's. > > Signed-off-by: Clément Chigot > --- > config.mak.uname | 1 + > 1 file changed, 1 insertion(+) I do not have an AIX box, so I'll take this as-is. Thanks. > > diff --git a/config.mak.uname b/config.mak.uname > index 41e85fab1c..86cbe47627 100644 > --- a/config.mak.uname > +++ b/config.mak.uname > @@ -269,6 +269,7 @@ ifeq ($(uname_S),AIX) > INTERNAL_QSORT = UnfortunatelyYes > NEEDS_LIBICONV = YesPlease > BASIC_CFLAGS += -D_LARGE_FILES > + FILENO_IS_A_MACRO = UnfortunatelyYes > ifeq ($(shell expr "$(uname_V)" : '[1234]'),1) > NO_PTHREADS = YesPlease > else ```