# [GSoC][PATCH] microporject test_path_is_* 6 messages from 2019-03-27 to 2019-03-28. Participants: Mooga, Elijah Newren. Thread: https://gitlist.dev/t/50827 ## Mooga, 2019-03-27 12:24 Subject: [GSoC][PATCH] microporject test_path_is_* Message-ID: <1A5DE2FC-7D94-4785-A915-EA2A71C6C377@m-mooga.com> URL: https://gitlist.dev/e/1A5DE2FC-7D94-4785-A915-EA2A71C6C377%40m-mooga.com ``` So for example  that is git diff diff --git a/t/t2400-worktree-add.sh b/t/t2400-worktree-add.sh index 286bba35d8..fc82965a0f 100755 --- a/t/t2400-worktree-add.sh +++ b/t/t2400-worktree-add.sh @@ -66,7 +66,7 @@ test_expect_success '"add" worktree' ' test_expect_success '"add" worktree with lock' '         git rev-parse HEAD >expect &&         git worktree add --detach --lock here-with-lock master && -       test -f .git/worktrees/here-with-lock/locked +       test_path_is_file .git/worktrees/here-with-lock/locked I would like to hear feedback if I should commit ``` ## Elijah Newren, 2019-03-27 17:05 Subject: Re: [GSoC][PATCH] microporject test_path_is_* Message-ID: URL: https://gitlist.dev/e/CABPp-BE9vNhnN6XdcxnePnXkek0bNogAiA_cKJqZ1-ct%3DQA2pw%40mail.gmail.com In-Reply-To: <1A5DE2FC-7D94-4785-A915-EA2A71C6C377@m-mooga.com> ``` Hi Mooga, On Wed, Mar 27, 2019 at 5:27 AM Mooga wrote: > > > So for example that is git diff > > diff --git a/t/t2400-worktree-add.sh b/t/t2400-worktree-add.sh > index 286bba35d8..fc82965a0f 100755 > --- a/t/t2400-worktree-add.sh > +++ b/t/t2400-worktree-add.sh > @@ -66,7 +66,7 @@ test_expect_success '"add" worktree' ' > test_expect_success '"add" worktree with lock' ' > git rev-parse HEAD >expect && > git worktree add --detach --lock here-with-lock master && > - test -f .git/worktrees/here-with-lock/locked > + test_path_is_file .git/worktrees/here-with-lock/locked > > I would like to hear feedback if I should commit As you noticed from the other thread, there are folks who are now unsure whether this microproject suggestion is a good idea anymore. Personally, I like the test_path_is_* slightly better, but the real issue is that we didn't have that discussion before starting the GSoC process and putting it up as a suggestion on the microprojects page. I think the main purpose is getting people familiar with creating and submitting patches, so I'd go ahead and make this change as well as others needed in that file and submit it. Maybe the patch doesn't get applied but if you've created a correct commit and submitted it as a patch to the mailing list, I'd still count it as a successful microproject. ``` ## Mooga, 2019-03-27 20:29 Subject: Re: [GSoC][PATCH] microporject test_path_is_* Message-ID: URL: https://gitlist.dev/e/BF34A383-7714-40CC-B5EF-4FD20E7AC839%40m-mooga.com In-Reply-To: ``` Hi Eliah, thanks for the advice, but still after I read the SubmittingPatches , and see around the Submitting patches process still confussing for me , there's a better way for explanation as an example Regards On 27.03.19, 18:06, "Elijah Newren" wrote: Hi Mooga, On Wed, Mar 27, 2019 at 5:27 AM Mooga wrote: > > > So for example that is git diff > > diff --git a/t/t2400-worktree-add.sh b/t/t2400-worktree-add.sh > index 286bba35d8..fc82965a0f 100755 > --- a/t/t2400-worktree-add.sh > +++ b/t/t2400-worktree-add.sh > @@ -66,7 +66,7 @@ test_expect_success '"add" worktree' ' > test_expect_success '"add" worktree with lock' ' > git rev-parse HEAD >expect && > git worktree add --detach --lock here-with-lock master && > - test -f .git/worktrees/here-with-lock/locked > + test_path_is_file .git/worktrees/here-with-lock/locked > > I would like to hear feedback if I should commit As you noticed from the other thread, there are folks who are now unsure whether this microproject suggestion is a good idea anymore. Personally, I like the test_path_is_* slightly better, but the real issue is that we didn't have that discussion before starting the GSoC process and putting it up as a suggestion on the microprojects page. I think the main purpose is getting people familiar with creating and submitting patches, so I'd go ahead and make this change as well as others needed in that file and submit it. Maybe the patch doesn't get applied but if you've created a correct commit and submitted it as a patch to the mailing list, I'd still count it as a successful microproject. ``` ## Elijah Newren, 2019-03-28 16:02 Subject: Re: [GSoC][PATCH] microporject test_path_is_* Message-ID: URL: https://gitlist.dev/e/CABPp-BGiP8BZwWQMbYhVQjqq8jZx%2BbbUTfgLaC6ZyukpLErZBw%40mail.gmail.com In-Reply-To: ``` On Wed, Mar 27, 2019 at 1:31 PM Mooga wrote: > > Hi Eliah, > thanks for the advice, but still after I read the SubmittingPatches , and see around the Submitting patches process still confussing for me , there's a better way for explanation as an example > > > Regards On this list, please respond to emails interleaved or below the original email; we discourage top-posting. What part of the process is confusing? Without knowing that, we're likely to just repeat the document as it stands. Also, have you taken a look at https://gitgitgadget.github.io/ (which is a new thing designed to make submitting patches to git.git easier)? Hope that helps, Elijah ``` ## Mooga, 2019-03-28 17:07 Subject: Re: [GSoC][PATCH] microporject test_path_is_* Message-ID: <1B12FDC7-20CD-4044-AA88-AE9A4E942531@m-mooga.com> URL: https://gitlist.dev/e/1B12FDC7-20CD-4044-AA88-AE9A4E942531%40m-mooga.com In-Reply-To: ``` I have done what is https://gitgitgadget.github.io/ but the problem is my pull request not being successful even what I have changed is " test_path_is_dir " in test file "t2400", it returns PowerShell exited with code '1'. Publishing build artifacts failed with an error: Not found PathtoPublish: D:\a\1\s\t\failed-test-artifacts I have contributed before in open source community and I just need a quick review to continue the proposal On 28.03.19, 17:03, "Elijah Newren" wrote: On Wed, Mar 27, 2019 at 1:31 PM Mooga wrote: > > Hi Eliah, > thanks for the advice, but still after I read the SubmittingPatches , and see around the Submitting patches process still confussing for me , there's a better way for explanation as an example > > > Regards On this list, please respond to emails interleaved or below the original email; we discourage top-posting. What part of the process is confusing? Without knowing that, we're likely to just repeat the document as it stands. Also, have you taken a look at https://gitgitgadget.github.io/ (which is a new thing designed to make submitting patches to git.git easier)? Hope that helps, Elijah ``` ## Elijah Newren, 2019-03-28 18:01 Subject: Re: [GSoC][PATCH] microporject test_path_is_* Message-ID: URL: https://gitlist.dev/e/CABPp-BHbEkVfhh_Q%3D_ZD2nNF%2BJ%2BNdNmDL4nR-yH2WGmSvbx0Cg%40mail.gmail.com In-Reply-To: <1B12FDC7-20CD-4044-AA88-AE9A4E942531@m-mooga.com> ``` Hi Mooga, On Thu, Mar 28, 2019 at 10:08 AM Mooga wrote: > > I have done what is https://gitgitgadget.github.io/ but the problem is > my pull request not being successful even what I have changed is " test_path_is_dir " in test file "t2400", it returns > > PowerShell exited with code '1'. > Publishing build artifacts failed with an error: Not found PathtoPublish: D:\a\1\s\t\failed-test-artifacts > > I have contributed before in open source community and I just need a quick review to continue the proposal Please don't top-post. I may have to allow others to respond as I haven't used Windows meaningfully in over two decades and don't know how to do anything useful on that OS, but the fact you are attempting to run these bourne shell scripts with PowerShell suggests you are not invoking them correctly. You'll need to get and use some version of Bash; see https://github.com/git-for-windows/git/blob/master/CONTRIBUTING.md Hope that helps, Elijah > On 28.03.19, 17:03, "Elijah Newren" wrote: > > On Wed, Mar 27, 2019 at 1:31 PM Mooga wrote: > > > > Hi Eliah, > > thanks for the advice, but still after I read the SubmittingPatches , and see around the Submitting patches process still confussing for me , there's a better way for explanation as an example > > > > > > Regards > > On this list, please respond to emails interleaved or below the > original email; we discourage top-posting. > > What part of the process is confusing? Without knowing that, we're > likely to just repeat the document as it stands. Also, have you taken > a look at https://gitgitgadget.github.io/ (which is a new thing > designed to make submitting patches to git.git easier)? > > Hope that helps, > Elijah > > > ```