# [PATCH] fix pack protocol example client/server communication 2 messages from 2019-03-16 to 2019-03-18. Participants: Mike Hommey, Junio C Hamano. Thread: https://gitlist.dev/t/50753 ## Mike Hommey, 2019-03-16 08:57 Subject: [PATCH] fix pack protocol example client/server communication Message-ID: <20190316085707.4151-1-mh@glandium.org> URL: https://gitlist.dev/e/20190316085707.4151-1-mh%40glandium.org ``` The pkt-line formatted lines contained the wrong pkt-len. Signed-off-by: Mike Hommey --- Documentation/technical/pack-protocol.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt index 7a2375a55d..c73e72de0e 100644 --- a/Documentation/technical/pack-protocol.txt +++ b/Documentation/technical/pack-protocol.txt @@ -657,14 +657,14 @@ can be rejected. An example client/server communication might look like this: ---- - S: 007c74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/local\0report-status delete-refs ofs-delta\n + S: 006274730d410fcb6603ace96f1dc55ea6196122532d refs/heads/local\0report-status delete-refs ofs-delta\n S: 003e7d1665144a3a975c05f1f43902ddaf084e784dbe refs/heads/debug\n S: 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/master\n - S: 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/team\n + S: 003d74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/team\n S: 0000 - C: 003e7d1665144a3a975c05f1f43902ddaf084e784dbe 74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/debug\n - C: 003e74730d410fcb6603ace96f1dc55ea6196122532d 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/master\n + C: 00677d1665144a3a975c05f1f43902ddaf084e784dbe 74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/debug\n + C: 006874730d410fcb6603ace96f1dc55ea6196122532d 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/master\n C: 0000 C: [PACKDATA] -- 2.21.0 ``` ## Junio C Hamano, 2019-03-18 05:37 Subject: Re: [PATCH] fix pack protocol example client/server communication Message-ID: URL: https://gitlist.dev/e/xmqqimwg4uaj.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20190316085707.4151-1-mh@glandium.org> ``` Mike Hommey writes: > The pkt-line formatted lines contained the wrong pkt-len. Wow. > > Signed-off-by: Mike Hommey > --- > Documentation/technical/pack-protocol.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt > index 7a2375a55d..c73e72de0e 100644 > --- a/Documentation/technical/pack-protocol.txt > +++ b/Documentation/technical/pack-protocol.txt > @@ -657,14 +657,14 @@ can be rejected. > An example client/server communication might look like this: > > ---- > - S: 007c74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/local\0report-status delete-refs ofs-delta\n > + S: 006274730d410fcb6603ace96f1dc55ea6196122532d refs/heads/local\0report-status delete-refs ofs-delta\n This miscounts from the very beginning. I am not sure where the mistake came from originally. > S: 003e7d1665144a3a975c05f1f43902ddaf084e784dbe refs/heads/debug\n > S: 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/master\n > - S: 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/team\n > + S: 003d74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/team\n This too miscounts from the very beginning of this content; it is likely that it was copied and pasted from the line above, which does have a correct bytecount. > S: 0000 > > - C: 003e7d1665144a3a975c05f1f43902ddaf084e784dbe 74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/debug\n > - C: 003e74730d410fcb6603ace96f1dc55ea6196122532d 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/master\n These are likely copy-and-paste from the above ;-) > + C: 00677d1665144a3a975c05f1f43902ddaf084e784dbe 74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/debug\n > + C: 006874730d410fcb6603ace96f1dc55ea6196122532d 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/master\n I counted these myself before applying, and they look correct ;-) Thanks. > C: 0000 > C: [PACKDATA] ```