# [PATCH] t4150: remove unused variable 3 messages from 2019-03-12 to 2019-03-13. Participants: Andrei Rybak, Junio C Hamano, Phillip Wood. Thread: https://gitlist.dev/t/50718 ## Andrei Rybak, 2019-03-12 14:38 Subject: [PATCH] t4150: remove unused variable Message-ID: <36ad743f-8429-a6ff-7fad-15e5dba01483@gmail.com> URL: https://gitlist.dev/e/36ad743f-8429-a6ff-7fad-15e5dba01483%40gmail.com ``` In commit 735285b403 ("am: fix signoff when other trailers are present", 2017-08-08) tests using variable $signoff were rewritten and it is no longer used, so just remove it from the test setup. Signed-off-by: Andrei Rybak --- t/t4150-am.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/t/t4150-am.sh b/t/t4150-am.sh index 55b577d919..3f7f750cc8 100755 --- a/t/t4150-am.sh +++ b/t/t4150-am.sh @@ -77,14 +77,12 @@ test_expect_success 'setup: messages' ' printf "Subject: " >subject-prefix && - cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF && + cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF This line should not be included in the commit message with --scissors enabled. - - >8 - - remove everything above this line - - >8 - - EOF - - signoff="Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>" ' test_expect_success setup ' -- 2.20.1 ``` ## Junio C Hamano, 2019-03-13 02:10 Subject: Re: [PATCH] t4150: remove unused variable Message-ID: URL: https://gitlist.dev/e/xmqqa7hzfrsv.fsf%40gitster-ct.c.googlers.com In-Reply-To: <36ad743f-8429-a6ff-7fad-15e5dba01483@gmail.com> ``` Andrei Rybak writes: > In commit 735285b403 ("am: fix signoff when other trailers are present", > 2017-08-08) tests using variable $signoff were rewritten and it is no > longer used, so just remove it from the test setup. > > Signed-off-by: Andrei Rybak > --- > t/t4150-am.sh | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Looks good; thanks. > > diff --git a/t/t4150-am.sh b/t/t4150-am.sh > index 55b577d919..3f7f750cc8 100755 > --- a/t/t4150-am.sh > +++ b/t/t4150-am.sh > @@ -77,14 +77,12 @@ test_expect_success 'setup: messages' ' > > printf "Subject: " >subject-prefix && > > - cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF && > + cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF > This line should not be included in the commit message with --scissors enabled. > > - - >8 - - remove everything above this line - - >8 - - > > EOF > - > - signoff="Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>" > ' > > test_expect_success setup ' ``` ## Phillip Wood, 2019-03-13 14:47 Subject: Re: [PATCH] t4150: remove unused variable Message-ID: <936bfc66-c121-a036-4ccf-c9877560bc33@gmail.com> URL: https://gitlist.dev/e/936bfc66-c121-a036-4ccf-c9877560bc33%40gmail.com In-Reply-To: <36ad743f-8429-a6ff-7fad-15e5dba01483@gmail.com> ``` On 12/03/2019 14:38, Andrei Rybak wrote: > In commit 735285b403 ("am: fix signoff when other trailers are present", > 2017-08-08) tests using variable $signoff were rewritten and it is no > longer used, so just remove it from the test setup. Well spotted, thanks Phillip > Signed-off-by: Andrei Rybak > --- > t/t4150-am.sh | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/t/t4150-am.sh b/t/t4150-am.sh > index 55b577d919..3f7f750cc8 100755 > --- a/t/t4150-am.sh > +++ b/t/t4150-am.sh > @@ -77,14 +77,12 @@ test_expect_success 'setup: messages' ' > > printf "Subject: " >subject-prefix && > > - cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF && > + cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF > This line should not be included in the commit message with --scissors enabled. > > - - >8 - - remove everything above this line - - >8 - - > > EOF > - > - signoff="Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>" > ' > > test_expect_success setup ' > ```